Received-SPF: pass (google.com: domain of linux-kernel+bounces-133360-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <564688b7-7d21-414d-9878-5a736777660d@linux.intel.com>
Date: Fri, 5 Apr 2024 09:46:40 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] gpio: wcove: Use -ENOTSUPP consistently
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
 Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski
 <brgl@bgdev.pl>, Cristian Marussi <cristian.marussi@arm.com>,
 Sudeep Holla <sudeep.holla@arm.com>, peng.fan@oss.nxp.com
References: <20240405162521.3774111-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20240405162521.3774111-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/5/24 9:25 AM, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some
> cases and not using analogue POSIX code. Make the driver to follow
> this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  drivers/gpio/gpio-wcove.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index c18b6b47384f..94ca9d03c094 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -104,7 +104,7 @@ static inline int to_reg(int gpio, enum ctrl_register type)
>  	unsigned int reg = type == CTRL_IN ? GPIO_IN_CTRL_BASE : GPIO_OUT_CTRL_BASE;
>  
>  	if (gpio >= WCOVE_GPIO_NUM)
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  
>  	return reg + gpio;
>  }

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer