Received-SPF: pass (google.com: domain of linux-kernel+bounces-133413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d410aa13-0060-418d-bafa-c24f9653861c@intel.com>
Date: Fri, 5 Apr 2024 10:15:07 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code
To: Peter Newman <peternewman@google.com>, Fenghua Yu <fenghua.yu@intel.com>,
	James Morse <james.morse@arm.com>
CC: Stephane Eranian <eranian@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, Juri
 Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt
	<rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, "Mel Gorman"
	<mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin
 Schneider <vschneid@redhat.com>, Uros Bizjak <ubizjak@gmail.com>, Mike
 Rapoport <rppt@kernel.org>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, Rick Edgecombe
	<rick.p.edgecombe@intel.com>, Xin Li <xin3.li@intel.com>, Babu Moger
	<babu.moger@amd.com>, Shaopeng Tan <tan.shaopeng@fujitsu.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@intel.com>, Jens Axboe
	<axboe@kernel.dk>, Christian Brauner <brauner@kernel.org>, Oleg Nesterov
	<oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Tycho Andersen
	<tandersen@netflix.com>, Nicholas Piggin <npiggin@gmail.com>, Beau Belgrave
	<beaub@linux.microsoft.com>, "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	<linux-kernel@vger.kernel.org>
References: <20240325172707.73966-1-peternewman@google.com>
 <20240325172707.73966-6-peternewman@google.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240325172707.73966-6-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1UvazNuVWR5TGd3eDVpV2ZoMyt6T3grN3RQVFljais0cEU1cDFaOXJuVjVn?=
 =?utf-8?B?eWZxdUIrdGVDSHNPSWxUaHVJa1gxMTliQ2l5Q1JTdnp5akZEUEk5SkpEN1dY?=
 =?utf-8?B?WVpXRDNFY0RnM3d1KzR3YVdiK3lMUks3MXZHNHBrckpIV3lMUnBmLzQ4ak94?=
 =?utf-8?B?RklnQW9CNVJCQng1TVA0ZFlNNkgyakdqMjdyamlhT3JWaGMrTCtFYk1VaUF6?=
 =?utf-8?B?QUt2K3BxOTEvdkh2bWZ5YmY4ZkExQUo5RXNGUzcvcWVGMVFCdkt3RnYwbDJm?=
 =?utf-8?B?MnF5ZHcwRnlydy9ZVnYySFhUTkxYS1EzcnNkWjlZU0owQThKYS9BR2swc1Nw?=
 =?utf-8?B?dkYrVUxWQW9saXhTdUtOeHV6aXkzWjFSVkJFbXVBWnVTVDBta0hqUTJ5TkxJ?=
 =?utf-8?B?REVyNkE3bENjaEFrZFdDem0wekYrRmNSZ0hsK3RISmdGZ0ZFQUY0cGowWXpu?=
 =?utf-8?B?YzhETjhEWXNjVHlxbTZ4ZXNzTm9qVDVwRWVkTUtqaWFIaG5XMHp2V0tBalMw?=
 =?utf-8?B?SHI1bWNpQnBEdDV6NHh6NHNxZkhoUXNPY1pOU3pFOWtxd0pFdEtlK2xCSW54?=
 =?utf-8?B?YkFxbTlCUmg2a3ZGY1JTMVcrbHZRWFZMdmkxTkhYMXplS2lXWUdjbHIxem1s?=
 =?utf-8?B?Z241aEEzdlJFTFVZd1JINnY4Uk81dXFTMzcrTStxd2pHbHVsdmJZQkR0a0tF?=
 =?utf-8?B?WDFEZjZjaVNvUHZHOXVJS3I0b2F6UVh0bWtXSDA4OXZCSUd5OThaS3BEZ1RF?=
 =?utf-8?B?b1kyRzE4cjZCOHJzc2RlN2t1aVkwdzE4TFowdktER1Y4cnRyZlhFVlNkeXZI?=
 =?utf-8?B?WnUyazFDM3drVU5Zdjc3d0VEajNnTE9ubWhHbGlYa0dsQ0FadnhFR05nOXpY?=
 =?utf-8?B?djVjUTVVUnA0UWRObFRQUU1HRS84cmRZeHFjRjBlaWpodlE0cFhIZGVqRFA2?=
 =?utf-8?B?ZStBNVdnbTN1c3BhRXRSNnNjYk45U3hSaytGNnhBWUljbGk0MkU2R3J5ZTJW?=
 =?utf-8?B?OFJGMUV0NUY3NlZvYlZjcXNEL0J0OHoyRDNYdCt5cjQ5dDlDMjU4T0M0bmxY?=
 =?utf-8?B?RVc3RDZiUGlFaUViSkZjLzlHNFBhWHExL0tBYTh3azVoUnNCMjdiYjlHMStR?=
 =?utf-8?B?SHNNMWNubDRmMEJWbVFaTTEyMjY1cEVSYnJVRE9aaHpFakxkS0V2bnZPb3FR?=
 =?utf-8?B?OW82TmxWWlNPUWNKQlZnNkNCY3pNNGtML2hWSTVBMXV4NHI1VS9JeGI0RGVo?=
 =?utf-8?B?NjA2R3BaL2lrZTc3cWhxQWhoYTJEeStlRUo0eEZCaFVDK0tWSEJFMG12VEh1?=
 =?utf-8?B?K3ArdTA4WktINVoyMDJLaUpCR0NwOUNuQmFDVC9IMWRZV0Q4NjV1T1pLYTBH?=
 =?utf-8?B?ZVBJcjlteTdJWXJUUk1jajZFampPTllCTHVURElUOWRIRkR5OUIzbWFaN1Zy?=
 =?utf-8?B?VlJKdjBvQWlYUnJIeG01SVA3L0tZemdwV3VEZUhCWDIyNTJCYTNxdFNJSjFh?=
 =?utf-8?B?UHd6QkZJbUJtY0lwajZVbkpkWlFVeXAyREJWYzV3MFh1Q05XRFFUaWlCS0Ny?=
 =?utf-8?B?QUVRM1pyc1JobkIzNEF2Ukc1THorK2lCR3JMempZU0J4YXkvSkZVeVRETEhi?=
 =?utf-8?B?MFh5cUgzRjRFLzN1T3BROGxZUUppK1FWcjBWLzRIMlRoSmJLWnZCVXdDKy9l?=
 =?utf-8?B?WU56cElnS3FGZHpYUzU2QjdodDZnTTBLUFpYVytud0pOdWNHVWFmY0ZhWFdX?=
 =?utf-8?B?L0xyS0RFeUZ5MUg2aWdHYmsrQ0JpUXVUa05yTHVxSTRkZmh3V3lYMGhENWRs?=
 =?utf-8?B?K285aDdZeDRpMm9seVJhOCtKbjNZbUk5WlM1V3oyY3E2ekVjQ1FnY0J6WkZL?=
 =?utf-8?B?ZHFreWdaVWpzam1tY0FYVERPR1ovdUVxdEpXeU9DUC9Jdm45c3M1aVhoWmtr?=
 =?utf-8?B?clNnWWwvRHNTNDZRbG9valVHUkZnZDMydWM2TVF2cTFQTmx1TjRDRHNPczM3?=
 =?utf-8?B?eG0xeXJ3UVBrbnVMbnA3UjBTQWdNbDJEZytxelhmejRRSHNaODkrYktpNzk2?=
 =?utf-8?B?bEJia1RqdU1PT0JEV2NwbU1lUGNEZDQ0d2UzNEVKQWlFUEFZS0RwMG5KeGJH?=
 =?utf-8?B?RmMvMWh1NGhBeXA3NmxtOCtzZXlER0xKcElhYzlZTjZVWnVGNTNha2pZVXAw?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 450bcdc5-9315-481f-3b59-08dc5593f381
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 17:15:11.5496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dg/43YrBjpiNVy84ExfFuIJ6WB2Bk5n7NL8twFlY/v1gr3rPTO8AgjTzjOEx7qGZHg9CCgVzoIul+kSIIe6nNkApD3CK8A+d77AqqUMUFT0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4874
X-OriginatorOrg: intel.com

Hi Peter,

On 3/25/2024 10:27 AM, Peter Newman wrote:
> While CLOSID and RMID originated in RDT, the concept applies to other
> architectures, as it's standard to write allocation and monitoring IDs
> into per-CPU registers.
> 
>  - Rename resctrl_pqr_state and pqr_state to be more
>    architecturally-neutral.
> 
>  - Introduce resctrl_arch_update_cpu() to replace the explicit write to
>    MSR_IA32_PQR_ASSOC in __resctrl_sched_in(). In the case of MPAM,
>    PARTID[_I,D] and PMG are a simple function of closid, rmid, and an
>    internal global.
> 
>  - Update terminology containing explicit references to the PQR_ASSOC
>    register.

fyi ... I just noticed this while looking at the MPAM patches that there
is an instance in comments of update_closid_rmid() where this
was misspelled (PGR_ASSOC) and thus not picked up by your rename
script.

Reinette