Received: by 2002:ab2:5182:0:b0:1f4:61d5:3ad4 with SMTP id x2csp80696lqi; Fri, 5 Apr 2024 10:17:17 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUG1B1CUxSLxO6L7NvOf5i1ue8uHY6ttwZ2K43OA4caSMXVOaJY9s3K6jDXz23XRQxLgGltVbOY1dCXaVPmb80prc5QOMDRII3kwxMFSw== X-Google-Smtp-Source: AGHT+IHEf9w38lESLY6cyCUoIAv7SJVb6iE785ft4QERQcWjUQbOosiulmZ2IMtD7IozgQ/pwwlE X-Received: by 2002:a17:902:e3d2:b0:1e2:5ad8:8139 with SMTP id r18-20020a170902e3d200b001e25ad88139mr1520030ple.37.1712337435902; Fri, 05 Apr 2024 10:17:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712337435; cv=pass; d=google.com; s=arc-20160816; b=tmFgX60t9U/JgZDQ6tiJvbFLkRlpN38cqSsVRyVa4ZD6iHuQBk1F+kHU2Sv59fIkgK DvyPVPrPnerj8g1DTEKVrOx4c8UdgbOH9RIYAFKVeHoTS+PchzFJK5fZkocF7xhibcUv Gr8pOPa9mFMVm8V9ZHyMK6SwNwZobhDKnuqeOi0mcrzhBiPOOw6DYO1kqiCDt8evZR/f +JhRu9psGtlMQQku5hXTJY/YuyG1GzrIqlTJu55FnKCiqbOoIKcRnrRALZgnBLL57Zij ++LkhtECRrUiDKMjOSBeOynaMnWJ2TbbyGZqCJkH/H6SCLJfrs55DqHZoHZS6XmvoBSN unSQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=mIxKX8sXCljWhbiYRGP69nDjgvboBFfZR83sar10Edc=; fh=TU23MGx7iY3BDcDOBpwwyJWRfrd/QDwqF+4SYJ3AUIQ=; b=r3RD47wnknDSFlnep+GRswgyqlceO/QezFKkvgMZsbCmTButj9nNQGTz6mkYiGaUEI KRzx6OSQDiPFGA7WoY0rrzR8S6ptMED5++1iRp7HO3CYlxu/GW3+W9sXY1SQy4DI1jg/ KDBSVJ+aaHrIID1Akx+OFjoqBfcQxiXQaQWk58Ed9Z1V8Rcxo9zwfutgMgbFpMMtKzWW 8c6/FqouNpuG+AwpgDb1uQICP7/c/cjPe4XNwZElCg88AlZILZKH3pNQQb9w2l0eHRTM zYZny8zlFMLVsFYAD9ZiO52ljPsNldC90o3ZNqrjw25by0x8xPaEolq3jCDSzVirdW9F F88g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=niema7Rp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-133400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133400-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i12-20020a17090332cc00b001e208929fa5si1672421plr.538.2024.04.05.10.17.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 10:17:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=niema7Rp; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-133400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133400-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A9611B26F79 for ; Fri, 5 Apr 2024 17:10:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 297E0173343; Fri, 5 Apr 2024 17:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="niema7Rp" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42B0A17333B for ; Fri, 5 Apr 2024 17:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712336953; cv=none; b=LhYUBRNUquMi5hp/vZBKJfkp/ceBX22W5WSyI5XxdThf95qpZaKWAmRdR4j1f9u0WWcf+/MQZYLqJIqacHbUTU0IOGktOXuQj1qH37pEKm+lAe9biXzDMGlZQdcim+0+ubPbGOSpURbIgAFBAVkS2iB8i/c9m5I10ye+jL1B+ZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712336953; c=relaxed/simple; bh=8t2H8FLs/1/uH2aIckaTpiaoX1z48XV57VOz781Bu7k=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=MGrKE/NtQNlpiE5FtSXR1bSzOBT3v6JzTguj+c7dR1Wks7oBcsZvmWl3LLf2KQewejH2/vt31ashcf3N5QYWrI7eb8RNapRUsP7fgQ3iMOptKmqNpY6U+M5oefOeGmZpagZPK0KNwgQwEaBhOL56MtwDEToXIQsdRySj1NGaZIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=niema7Rp; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BCAEC433C7; Fri, 5 Apr 2024 17:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712336952; bh=8t2H8FLs/1/uH2aIckaTpiaoX1z48XV57VOz781Bu7k=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=niema7RpOjQRX0mF+8zXga2Ek+PXt1OT186fSnAwFgJXx5m56RbEDz2AQzOuFCPXO B1Rjhqxglpl/8njLO+brFP7Nm4bQ99DEryCK14l2WyKQOdChnNV/wlagvXHfBkzNKJ LcMNZyJpB1/F+tzpl2o/FXDar2XfD3pWio41vU1ut5/l87110O3pzTw65KScN7a3A9 DinCApdIb4i4q5IVEOxIC+O/L03m7gx9QID9sHgFNv7+0zkA6AVevQHt22iOYkOIZ7 Cbieh3HznQg4oxU2+8VT+LJamzPUGsrPTYVjwtsq0bJ8PFoTAc+70xKz/OpzegpfPk pIiNh8qqf4Sbg== From: Vinod Koul To: Laurent Pinchart , Kishon Vijay Abraham I , Michal Simek , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de In-Reply-To: <57a3338a1cec683ac84d48e00dbf197e15ee5481.1709886922.git.u.kleine-koenig@pengutronix.de> References: <57a3338a1cec683ac84d48e00dbf197e15ee5481.1709886922.git.u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH] phy: xilinx: Convert to platform remove callback returning void Message-Id: <171233694977.304553.16769485052582751352.b4-ty@kernel.org> Date: Fri, 05 Apr 2024 22:39:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 On Fri, 08 Mar 2024 09:51:13 +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > [...] Applied, thanks! [1/1] phy: xilinx: Convert to platform remove callback returning void commit: 7dcb8668aedc5603cba1f2625c6051beff03797d Best regards, -- ~Vinod