Received: by 2002:ab2:31c4:0:b0:1ef:b27b:cc29 with SMTP id d4csp1065498lqf; Fri, 5 Apr 2024 10:26:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW3q7O4VRTwPl8/rlsGrfZM4o55s3FLt2bous+xk8yb3Op08xkL6b9olX8+qWMh38lJKmhvP7noIlOpgz0xvNc2c8WRmpNrmULGunqzxg== X-Google-Smtp-Source: AGHT+IF3wvUkfwo05LQLZv/FDLqcQnRTtSFLkIYLigEf1Zv7VILQFu71/Zs0L5tq0h0OjstWdb6g X-Received: by 2002:a17:90a:3904:b0:2a2:bbdb:c4aa with SMTP id y4-20020a17090a390400b002a2bbdbc4aamr2004317pjb.30.1712338008205; Fri, 05 Apr 2024 10:26:48 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v8-20020a17090a6b0800b002a25ed32020si1693180pjj.182.2024.04.05.10.26.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 10:26:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-133412-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133412-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9E7A8B2790C for ; Fri, 5 Apr 2024 17:14:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 85C1B171670; Fri, 5 Apr 2024 17:14:22 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F1716C858; Fri, 5 Apr 2024 17:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712337262; cv=none; b=FosKjcjEo03eYs9SYjUzzWr9aRBxnKS3zzR/Z+NzzG2xySeRsHyr4h5seLwu9hxL317j6z0gUI5d8RcNbejrA/lVxNxeC27Ie+h+aONw2ZhIZQEge/w7TNVU77gmYe4NdMjnZMsOeon16JHe3PPHaf1hyC+iBOUMHwuE2y4tcnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712337262; c=relaxed/simple; bh=PS5evwJ8xyi+GjWxAU4gBBflc4VGXU88R/XiJlorDvQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ie16h9NrFqwr0JlbAmbs0F2xy5KphbGzrdJOdAo+PfOqu294Huek5u7zxMcIFvxwzfDwPg85JlLx7/f1k1WC/RsvfGXvESnKsKZBv/65GT1YYl5GM7RQg3Qrtx1jnlAqIlNtd2YFRAjIH2ZEtQNyrQmb6ulLdssGaUNI1yp59FI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: B/jJA5c9R2yy4rIvTzuYDg== X-CSE-MsgGUID: tdmbOsdIRKqZ0FSC78MqJg== X-IronPort-AV: E=McAfee;i="6600,9927,11035"; a="19031169" X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="19031169" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2024 10:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11035"; a="915259793" X-IronPort-AV: E=Sophos;i="6.07,181,1708416000"; d="scan'208";a="915259793" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2024 10:14:13 -0700 Received: from andy by smile with local (Exim 4.97) (envelope-from ) id 1rsn8k-00000001oG4-1imE; Fri, 05 Apr 2024 20:14:10 +0300 Date: Fri, 5 Apr 2024 20:14:10 +0300 From: Andy Shevchenko To: Vinod Koul Cc: Thomas Richard , Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v4 08/18] phy: ti: phy-j721e-wiz: add resume support Message-ID: References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-8-6f1f53390c85@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Apr 05, 2024 at 10:14:09PM +0530, Vinod Koul wrote: > On 04-03-24, 16:35, Thomas Richard wrote: .. > > +static int wiz_resume_noirq(struct device *dev) > > I think this should be annotated with __maybe_unused No... > > + .pm = pm_sleep_ptr(&wiz_pm_ops), ..because of magic of PTR_IF() here. -- With Best Regards, Andy Shevchenko