Received-SPF: pass (google.com: domain of linux-kernel+bounces-133436-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 5 Apr 2024 10:45:05 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Alison Schofield <alison.schofield@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: Kwangjin Ko <kwangjin.ko@sk.com>, <dave@stgolabs.net>,
	<dave.jiang@intel.com>, <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
	<dan.j.williams@intel.com>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel_team@skhynix.com>
Subject: Re: [PATCH v2 1/1] cxl/core: Fix initialization of mbox_cmd.size_out
 in get event
Message-ID: <661038a136a79_1578629429@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240402081404.1106-1-kwangjin.ko@sk.com>
 <20240402081404.1106-2-kwangjin.ko@sk.com>
 <ZhAhAL/GOaWFrauw@aschofie-mobl2>
 <20240405174056.00005422@Huawei.com>
 <ZhA25pRuyiHJWcLj@aschofie-mobl2>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZhA25pRuyiHJWcLj@aschofie-mobl2>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dNmCCp8fYkSFcrapNZk942GQIgUOPzK63TxEFhguTfarG7ct03hTXGMg3Xkj?=
 =?us-ascii?Q?Le14gUy4nDESVbaafTv8OQcPKvXcNFnNiVtvQY2IW5R8jgXgEDBTG7XN5JLj?=
 =?us-ascii?Q?lOQz7RkzzJzUYcE3eAqzQEd7NBK8/TO1CAwq2pNLv4yo2/sckxGsK2259Y0Z?=
 =?us-ascii?Q?aiSqWgq/UCiLWFHvBAqPdIcfjexTo7pFlAkX+tPtXRLbRGF2+TkfsIKqBK5q?=
 =?us-ascii?Q?hg7732Ck7fDRzLqLAWh5gk4yUfPV1mYS0WJnrfDZ8/5mx9pSxypZY62yOmfG?=
 =?us-ascii?Q?nQCXR050lKpK2WjsEsIKsN7nkKP72/70oynIBA6vmkVIf9SzQKmZ1aoai63t?=
 =?us-ascii?Q?eb24jua+U4Xilnj6zVA4/vgQLeciTv1+RNZmmgO24GdGC0DWIsG0PQ1SbPk3?=
 =?us-ascii?Q?gQGKahTnl3c1t2SsiCPVRDmChrK/+q9go+hZCFOFPugSr2oirwrGEC8hqZg9?=
 =?us-ascii?Q?d1inixJXE/MAU0eoNrpWeuLh/gDzf34JTO+craifW0yWJkolnDPARIbHHZye?=
 =?us-ascii?Q?sTcDBDiOwojaCsWulR44J8HpZAaksQRYZwMQ4+b8FunHBRO/X1M0pSMDm8YL?=
 =?us-ascii?Q?wxrrGo+bPOiSHYwkFfJ4DxbHtsvp0GuUTOCipkHQ0WKLQb3+OeuZLQy4hPOD?=
 =?us-ascii?Q?zZmC80ZNY7i0ihEDdIqeA02H+vsa9N1ixSC9EdNhpJ7aCmRcnm7SSvAqA9hO?=
 =?us-ascii?Q?NH2poTr1nDdXPafhYRJ4PRvtGb3nVkMossDkDoUSDED373evTantsqL798zw?=
 =?us-ascii?Q?QM4rTRKyiQiI88Udt09//hU/pzYrdJNbWTsXJ/eETMfeqdCTNaH33trsEmuJ?=
 =?us-ascii?Q?GYjMofylQKvY9Oys7jf7k99DCFtJKMShLAnd6SjXiV8mope8qYZLXfXdRNwU?=
 =?us-ascii?Q?dPTOTFz1ZCjWZITPs8/no8dokJ2uFC0SvKpb932+uSFa8G02YBTzaEvCejeX?=
 =?us-ascii?Q?j0zu+83KadfH7X579EMj3T9CkLJ5tBBKti5glMfCw+fwr9SVq50SBhZmscn9?=
 =?us-ascii?Q?pPqrF8HMBS5oMqGprSA+Aua+YoyYcfQ1NPn6MRiXOBPla8kaXuILBI6lVDit?=
 =?us-ascii?Q?ng+Ki0PCMTvopQlWtYsWdPGErv+ho8Xk1TqfVyb6biE/ie2+DgvMLs033MOu?=
 =?us-ascii?Q?SMdik3jhI1xFsHMEJB966tvVO4to5NXvUt/Da3Duxe6g/9J8xsAt4GF/ZdMs?=
 =?us-ascii?Q?EAYntTRsDuoioS6NZDDbh202byuouiFoJ0amfodi42d5/Odtvv70q3/aUNrn?=
 =?us-ascii?Q?O2aN0KUEgp4BYvsDwtSYaLWEq09TLc/EotCJllDAkqJQbGBeja/aNPuqryz7?=
 =?us-ascii?Q?VqFBCF+jtdCMwTmRjfeVHN0hw+rh+d6ngqwwjySoT21qRE64qOU6odNZxFQs?=
 =?us-ascii?Q?BloF1NbZtM2e92pdUxMhoZ2Nq8H1rdD1fP/qVG7T+0UCEaCw/mnkS30UnkT1?=
 =?us-ascii?Q?UGWvbIJTw6bOZXQhQDRwHUNxj31tV1GEno17S9vxXmt/uKHqxzU/jPB49APF?=
 =?us-ascii?Q?8KmvF8Z30J7zNNgb2jNS+Tm5MO0gevU/dQCHx1A6Q4Q07yXPX80gDwAZ9qz8?=
 =?us-ascii?Q?BQdIFHl4Y2bWC0AUDttzqGcdOEBIdKKAvTmuA0K7kx//cU152LvrtcZqUHXY?=
 =?us-ascii?Q?/w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ab54ddf6-dcac-4add-5cc8-08dc55982226
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 17:45:07.7660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TAgnwaqH+k3y3JMmWrGKH3ZtKzE9LZW20dbeTkQNhAPq1IEIV7YxdPhgXfDbAWf0RfiBIrW+JkdoTRwI1CJdS0dQdIGFuTQWjl4WI7WCWoo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7181
X-OriginatorOrg: intel.com

Alison Schofield wrote:
[..]
> My thought was 2) device bug. Bad device is returning payload length
> that exceeds what pci/cxl-driver can consume, so gets ignored. Am I
> worrying about debugging the hardware needlessly? 

I would not go so far as to say "needlessly", but the number of fun and
interesting ways that hardware can violate software expectations is
myriad, so it will always be game of after-the-fact quirks and fixups.

A payload truncation would seem to fail safely in the sense of no buffer
overrun and no stale data exposure. Still a bug, but no riskier than all
the other potential hardware bugs / spec violations.