Received-SPF: pass (google.com: domain of linux-kernel+bounces-133463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 11:19:23 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <ira.weiny@intel.com>, Fan Ni
	<fan.ni@samsung.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"Navneet Singh" <navneet.singh@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Davidlohr Bueso
	<dave@stgolabs.net>, Alison Schofield <alison.schofield@intel.com>, "Vishal
 Verma" <vishal.l.verma@intel.com>, <linux-btrfs@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/26] cxl/region: Add dynamic capacity decoder and
 region modes
Message-ID: <661040ab52a14_e9f9f2943c@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-4-b7b00d623625@intel.com>
 <1c7f63c5-1b7a-4f7b-9d48-4dd8b017d7de@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1c7f63c5-1b7a-4f7b-9d48-4dd8b017d7de@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bGHeAvT3y4qjprQAFzsj14BKPWba+AJyhZK2GqBGjRBZXhDAC4dTiVlc6YYt?=
 =?us-ascii?Q?m62ofL9yGkj5B6c8tWXJc88+h8iyAb1qs3sXSpz8Z47YQqGxDvo0J9wG39yu?=
 =?us-ascii?Q?CA0xwttu9dTDjjn6WV89ypwVzTaT4bmOFcOAAjZ9ycHfRRiLujUqJE8cclwA?=
 =?us-ascii?Q?k97Xv+YcJAGxyhszF417adTZu5d5F+KZYkWNyd9cVpFzNw5/KTPUsVY03tDx?=
 =?us-ascii?Q?zrfPRXlHLzPqoHR5lM8HrXmLWAiyHhsXOYjJrstQ0UwEvXvgzBTBo/0x3JG+?=
 =?us-ascii?Q?M0V0YGHh/sMn27lmNeBUAAMVoqllX9+cryPEWvM5wz6K/uUW2JTF5qUTwGCg?=
 =?us-ascii?Q?D3yz4GxEfikLo8ZDD1s/a52J9cxJR2yYUoQFMWgpTRSRntyEmG1njIu43eoH?=
 =?us-ascii?Q?VFhUzRB8yI4Ok6w3ZbWzDPYBvWssQ/8fVALpN4sQbJKPDSJPLIbXdKpFh/D+?=
 =?us-ascii?Q?GWSS/Y4wcRdkULzIRe4Gz66pVSPVR1QTEqWwjFEpuHfx7YSpZYvk6AGUT4mw?=
 =?us-ascii?Q?VwviAfaeGL1voKkxvU/uNwdeGnRNfhDJk6e8lP256JbIMpMVPdz2Mt+/SSzK?=
 =?us-ascii?Q?DiQgjnyhLn6L7qSgFKIWpSpzDEahiAbsvIJ6NF6RMq3JdCfnR6G3+OLshkwF?=
 =?us-ascii?Q?+JWsRZWdTyBFvSIpFc5m5m/1W3dqc81Bf3Ypi4YJU3Gxc/5ZsexPeNzduDSG?=
 =?us-ascii?Q?v9X5HsryzPwydQz1pL/beohT0Rvwn6CUgWIOfRUam4zsaNdknYBqvB2UEonb?=
 =?us-ascii?Q?1X6uo4n1Xj4xiOQNAPgfi49eks4LEBXMWS2KYANkXxnOp4iGF3cXDqh7mn8B?=
 =?us-ascii?Q?EDclHgy8Y/v39IDdzaR1Vva8X490ksg6qtTn+NHo1UzUnlZ+soKuR8qdGfPh?=
 =?us-ascii?Q?zWy2eyRG2f0e4enn/1LkCGeLObFVB4N6T+q7QhTWOcv/kGnPRVqI4M+1Prq2?=
 =?us-ascii?Q?tiWanOLo4NVXlb58jA0MFMajtvGloWpwmtTCMeM4KNFot4c3ofOWmi5sQZF3?=
 =?us-ascii?Q?5DflXdHS7V/42WqAKyS9MsKW/WojD/5o/Vw88PYmzAvfYvifQLhe8zTkl8No?=
 =?us-ascii?Q?fnSAS9/Tkp15SwgZpwsQf8n73rK6ipu7u2jakw9H79PJbW8SRvIB9u0t0klS?=
 =?us-ascii?Q?SCtYgJ6vpoqnKBkHI6D36OYX+i1nO8Rg3hBzGn/sAyp7m2OvT49Cp00/hV/Z?=
 =?us-ascii?Q?K6P/V/j//HWnNXA1kc6/Vm06rHZLsuh/LlKSfUl/cgZA8Y44c0RQq/rHPmx0?=
 =?us-ascii?Q?r08+bytZBJ77am/P9KZVaUxUQS0bUcL38jOnmT+/yqAy3bEAWttabUUYCyYP?=
 =?us-ascii?Q?67ihgmq+WW1w17szheqXuS8+5Rlb1RQ70Y0S1YyaDZKTB29xeSXDByegzf8+?=
 =?us-ascii?Q?Vz42licssiqR2s70kB2s/iO9gDhOKCySC7szgvAmLz5ZAJcjIXiOrDI8LY6N?=
 =?us-ascii?Q?mfBXvqh+BcXVQTx/UlWfDx1eyMfi+J0lipSp2UV1ZF31d+Gn9e4VUGE67K0c?=
 =?us-ascii?Q?heb2eO63N1chgMMGs6rxZjxTrPl7RfR8Q+3r8t3xr03HokS+mSBpK67YGcUW?=
 =?us-ascii?Q?V76osaoXqiqN2N2qE4a8hSBYSx6fdbqiNWUpFX22?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e51b4dff-1901-471b-9702-08dc559ced59
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 18:19:26.6294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fi2+hedl5S8JYR0M4sCGXGNOOjmlGueEsh5enRTiQAYSlivDfZmigLCIwcA23SiW6rFD/YQSBby6poVoFhZDDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8440
X-OriginatorOrg: intel.com

Dave Jiang wrote:
> 
> 
> On 3/24/24 4:18 PM, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > Region mode must reflect a general dynamic capacity type which is
> > associated with a specific Dynamic Capacity (DC) partitions in each
> > device decoder within the region.  DC partitions are also know as DC
> > regions per CXL 3.1.
> 
> This section reads somewhat awkward to me. Does this read any better?
> 
> One or more Dynamic Capacity (DC) partitions (and decoders) form a CXL
> software region. The region mode reflects composition of that entire software
> region. Decoder mode reflects a specific DC partition. DC partitions are also
> known as DC regions per CXL specification r3.1 but is not the same entity as
> CXL software regions.

Yea that does sound better but I think this builds on your text and is even
more clear.

<commit>
cxl/region: Add dynamic capacity decoder and region modes

One or more decoders each pointing to a Dynamic Capacity (DC) partition form a
CXL software region.  The region mode reflects composition of that entire
software region.  Decoder mode reflects a specific DC partition.  DC partitions
are also known as DC regions per CXL specification r3.1 but they are not the
same entity as CXL software regions.

Define the new modes and helper functions required to make the association
between these new modes.

</commit>


Ira