Received-SPF: pass (google.com: domain of linux-kernel+bounces-133510-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Andreas Dilger <adilger@dilger.ca>
Message-Id: <9F887394-68D4-4C2B-A5FA-1CA3D83C0E31@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_14FE9033-705D-4B95-9114-3A0DB8FFDFB4";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v3 04/13] btrfs: fiemap: emit new COMPRESSED state.
Date: Fri, 5 Apr 2024 13:10:50 -0600
In-Reply-To: <ed3a3c3edbf01b728c20c0718d227ebb79611f47.1712126039.git.sweettea-kernel@dorminy.me>
Cc: Jonathan Corbet <corbet@lwn.net>,
 Kent Overstreet <kent.overstreet@linux.dev>,
 Brian Foster <bfoster@redhat.com>,
 Chris Mason <clm@fb.com>,
 Josef Bacik <josef@toxicpanda.com>,
 David Sterba <dsterba@suse.com>,
 Jaegeuk Kim <jaegeuk@kernel.org>,
 Chao Yu <chao@kernel.org>,
 Alexander Viro <viro@zeniv.linux.org.uk>,
 Christian Brauner <brauner@kernel.org>,
 Jan Kara <jack@suse.cz>,
 =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>,
 linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 linux-bcachefs@vger.kernel.org,
 linux-btrfs@vger.kernel.org,
 linux-f2fs-devel@lists.sourceforge.net,
 linux-fsdevel@vger.kernel.org,
 kernel-team@meta.com
To: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
References: <cover.1712126039.git.sweettea-kernel@dorminy.me>
 <ed3a3c3edbf01b728c20c0718d227ebb79611f47.1712126039.git.sweettea-kernel@dorminy.me>


--Apple-Mail=_14FE9033-705D-4B95-9114-3A0DB8FFDFB4
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy =
<sweettea-kernel@dorminy.me> wrote:
>=20
> Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>

I would recommend to merge this with the 05/13 patch that is setting the =
btrfs
fe_physical_length field.  Otherwise, by itself it would be confusing =
that the
DATA_COMPRESSED flag is set on the extent without fe_physical_length =
being set
to be able to do anything with that information.

Cheers, Andreas

> ---
> fs/btrfs/extent_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 9e421d99fd5c..e9df670ef7d2 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -2706,7 +2706,7 @@ static int emit_fiemap_extent(struct =
fiemap_extent_info *fieinfo,
> 			if (range_end <=3D cache_end)
> 				return 0;
>=20
> -			if (!(flags & (FIEMAP_EXTENT_ENCODED | =
FIEMAP_EXTENT_DELALLOC)))
> +			if (!(flags & (FIEMAP_EXTENT_DATA_COMPRESSED | =
FIEMAP_EXTENT_DELALLOC)))
> 				phys +=3D cache_end - offset;
>=20
> 			offset =3D cache_end;
> @@ -3236,7 +3236,7 @@ int extent_fiemap(struct btrfs_inode *inode, =
struct fiemap_extent_info *fieinfo,
> 		}
>=20
> 		if (compression !=3D BTRFS_COMPRESS_NONE)
> -			flags |=3D FIEMAP_EXTENT_ENCODED;
> +			flags |=3D FIEMAP_EXTENT_DATA_COMPRESSED;
>=20
> 		if (extent_type =3D=3D BTRFS_FILE_EXTENT_INLINE) {
> 			flags |=3D FIEMAP_EXTENT_DATA_INLINE;
> --
> 2.43.0
>=20
>=20


Cheers, Andreas


--Apple-Mail=_14FE9033-705D-4B95-9114-3A0DB8FFDFB4
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmYQTLoACgkQcqXauRfM
H+C+JQ//RVIWVVU/mmIMIfM6I9hUuz7AfHU8nZHDzMf0XKVq1fPsPxlz3WC0eqzb
N63IB1Y3xTT8BUPsdhOcXiC0Q5SDrROjCOh2CMRJRP/SgeywDX0+li+M71DeeHMW
sL8gzCbjhZ6lHI2Minq2RVg3ZsJWbgr22+dFhbO+sIGlz1pHJb8rydIIqno9I40R
PuZD4dcDqktEBOpZgaZL/OcL2umYLxC0//7rWiYrzfTkuCfu6Otg/f4UfoPrnGfC
IwLknC6eji2x6CZTvz1iCYExpIJxRjNLpHN8QQs32rgVSXmA381ozvky63rRfSS6
LepXDGf8L7p4YaLJLyOfqmj+mFCO8UW7uVJPH4n1PBJprNFYrhRkZE0iL0IHA2Ac
R8yPgy4AVHHf2k9fqKnWT/5e9or6lSV4v6/xEC+UxoVspWqgBjqmb/x78S5PzwSY
jEmEV2iBGV7wgXU7TCF5oPfRli4Ot5CxnpNRbAHGdsIZmrepducQZhZ57ERjTqRh
uSn82O4EAjULOLFdaBZgSCU/u96PPd4Y7WeRKH6PygtKtCi2EODw6NONuF5Q8SVQ
PzQXbvmyP4JyU0K/UaaQQMFFLWjQlnkhqoZzxeieoVQ9ejl+8NKFNnkdnweNSRB0
RLt57nqqwJAbZjX8XYBpO2i5zTuN/l0/QTP/Y9ZQFy2vE++z44g=
=ixIP
-----END PGP SIGNATURE-----

--Apple-Mail=_14FE9033-705D-4B95-9114-3A0DB8FFDFB4--