Received-SPF: pass (google.com: domain of linux-kernel+bounces-133184-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <aac4b3ea-72dc-4afd-8f1f-06821de953c4@linux.intel.com>
Date: Fri, 5 Apr 2024 07:45:29 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] ACPI: x86: Move x86 stuff into dedicated folder
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Zhang Rui <rui.zhang@intel.com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
 linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>
References: <20240404183448.3310449-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20240404183448.3310449-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/4/24 11:23 AM, Andy Shevchenko wrote:
> Move x86 related modules (which are solely for x86) to the dedicated
> folder.
> Note, there are more modules, but they are related to tables and
> potentially might be used for other architectures in the future.
> Hence touched only non-table related code.

Except the blacklisted patch Nit, rest looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> In v2:
> - fixed acpi_lpss_init() stub visibility (LKP)
>
> Andy Shevchenko (4):
>   ACPI: x86: Introduce a Makefile
>   ACPI: x86: Move acpi_cmos_rtc to x86 folder
>   ACPI: x86: Move blacklist to x86 folder
>   ACPI: x86: Move LPSS to x86 folder
>
>  drivers/acpi/Makefile                            | 7 +------
>  drivers/acpi/internal.h                          | 3 ++-
>  drivers/acpi/x86/Makefile                        | 8 ++++++++
>  drivers/acpi/{ => x86}/blacklist.c               | 2 +-
>  drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} | 2 +-
>  drivers/acpi/{acpi_lpss.c => x86/lpss.c}         | 2 +-
>  6 files changed, 14 insertions(+), 10 deletions(-)
>  create mode 100644 drivers/acpi/x86/Makefile
>  rename drivers/acpi/{ => x86}/blacklist.c (99%)
>  rename drivers/acpi/{acpi_cmos_rtc.c => x86/cmos_rtc.c} (98%)
>  rename drivers/acpi/{acpi_lpss.c => x86/lpss.c} (99%)
>
-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer