Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp69561lqe; Fri, 5 Apr 2024 12:57:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXdjjy5TJDAmLp7tf+KMpu61qNGbSYnmZSyOxKZVGLGeTBfiHrgLW9aPDtYA96e+7cUaqBnhtD3T2WPNDgRc5aQnsIOn1+VOxIpXnK8dw== X-Google-Smtp-Source: AGHT+IEbY7MvwuD3aRCkaXnLe/oWkKW3dTubF+4ZOBmgy7TGgzA8FTD9bq/IZV9gfSs46aa+57vV X-Received: by 2002:a05:620a:4048:b0:78b:5569:fddf with SMTP id i8-20020a05620a404800b0078b5569fddfmr2938462qko.53.1712347073881; Fri, 05 Apr 2024 12:57:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712347073; cv=pass; d=google.com; s=arc-20160816; b=KxA+v3QZ59mdkC8lDQHOSgxS2uJmN0cRAV6r73yuUiDBV5nW2CWGWDLIXFwKrjkSJ3 yHdBv+y1aVWgzrAJTC0/eNnJoqrtiZOWi6ZviGy9JYNAMErwYs61vnfb3c5EaimwxFWY zqvdugGWBhWicyoEvAIE3u27pPnFNaWW389GSFkdEzM8VWYDNK/bgF0Cxv0JcxDhNlV9 pXXQuc5F2P91k4E9ykN21A3zPr9e+fAKucP65JVnI8vXPJ8khVLINlt8vS+/YBeLIr3y iqkIm6TOQpmAqTt8nSqclZ0ilSLlHlG7MFthGb1hYjL9XD0yjYwAA1WE4IqJ45LMPA4u Is0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; fh=clpg/u8fyA1uvWwSwse1jc84b4cwhJZALGp7bjDMZmc=; b=Wy0CqIO4RIWyu1dwoHGSqgXXDE818Z2w4ZogMj2vfn5EeAyQzhrZiVdT0HYI7ikmVl IOaOj2Dqe4xHV3mNd0X/YyUujvCBqsMxDqF8KwyqmHdVpgdnGO8bnyJAo4o1Vfl3US4u aq3wZY8hw9JWFqpFQlvXZtA4JAbpzpXPqhWBOP+OYTgUQv5VEP0f1l18qk+7aWEfQDDE xDfcuqy98oYemKB9fhn8jUO77+HhPhR57dOZBco20xNBsyxDSGJQ3MWzurkHYYnS/cJG wovMy21JmyK7YB33/147D5y54WuPHDw4eo+5bNIpQEME6LQqvtlBBnNcD1BnF3hOk80k 4mIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JZHxay92; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-133541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i6-20020a05620a404600b0078bea10047bsi2922123qko.242.2024.04.05.12.57.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 12:57:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JZHxay92; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-133541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 96F9D1C213A6 for ; Fri, 5 Apr 2024 19:57:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26C9A173347; Fri, 5 Apr 2024 19:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JZHxay92" Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0530315F40B for ; Fri, 5 Apr 2024 19:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712347066; cv=none; b=q7JRlLfRqlJXtILEyaJ4IXmtazBHPxv8FQ35g0f82Jjq1pUSQXF4qYd3o8a5tAzemT6nY7uj5cbV0OSOCPzAOdFZLDUUlFVEnCYT5/GousnYDZrLI+6u3gOFXrrce4BKu69l7Zqi7wzJTMQy2f1LOy7p1QwPBy9Xd4x8qf2Uy7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712347066; c=relaxed/simple; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rFgD7svHLnsXcK7QmKlsSVUyWw4unSou7B2p6y7hp/cH9R6/MIkeTNV89aKfAQjF2YkEcY7sS8EyTYxQnxrB27/QdQbK/i1zNF8sO2/d9+2pGE2vcijHZv+Qi9KzBjHT4XrIM7RODnL8PQefQcJVgYgxVbZzlEJdtVNRaGjHmJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JZHxay92; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6962a97752eso17215466d6.2 for ; Fri, 05 Apr 2024 12:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712347064; x=1712951864; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; b=JZHxay92Sg86m2wQMO4K4uFqm65LAlg6+zEdKkdRGfw7ICxd/B9zQuek3EcTthIQq6 6/cEDDhaTVvD0xtgPC+qaK07ZfHrO684Ii0b4GUMm9qKBIiw/GbehZ+YH8nNz1OFjpg1 jrLym18HtBTdr79IKjgEfBo1wyookIsJOHnxj/Iz3WguIVIfczV+42UlSxugTdd8mwHd ncPcrKnfKT25KPSBl5oIc4ecJsL+YRwGr5RklzsoXfugMsrCUn5gP3xcq8I8KCS7D8qF RLGP7L2P5nce3N6Ck7U1FsR7DEUgFDkiohvh5b5ttOl8La7npB54BJPh32PBFXPF6rp4 0Ssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712347064; x=1712951864; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i4aU/UJRGWn3roF1gYrAQyoBo6RFX+MLKL0nbEEnYFc=; b=g+LlBc7wAL56ve6bm4IFvbQHVI5PnrY2MA8fxuK3rhuKhV4yim0GgkQpxCUtldE3xx xO80LOgTeByyaAG1bZPrzL4wweidrvkwZhOVi7vF9HBUxEdJM+s2oKgQZ3itOVSLxtT5 WH+Ngi9/O4uPIMMlKWZHUP1PUnHjFJyWQ67aqFuXnPEx34MtVdPcOQ9SwONVoXnjGnS8 NzWR5Wt9tpOVpPFPLOG8c+JkOVIadeoW/KeF1GFih0QJP46dO9KpEmtqJS0HsLfM5Go2 R7j6xXX198rM/QR3mcU5kHNoXLAJGZ8JqgWPiwbd3wpUU3uSznI/i5B8o+sy+GweUxlY I04Q== X-Forwarded-Encrypted: i=1; AJvYcCUcAdizzZfVl+OZz0KEZsLuPS84HwvQW0ekyG4rjcDTBRRCwZS1aYd/qmnpLhozCzB9ZqTGLy7MVrOHh7hLXfASuBsngocT1u3ZWjqr X-Gm-Message-State: AOJu0YygIDB13u5aepnsVA7K9OnzLjcQsNzCw1XvNadxj1JXq9WK8vGx 8we5rOI1X0S2XgcmrMJ/JDrcbwuwWuBMG8IMPm8kLcRbi2obS0rQjvlkMtlBm6fyBLuf3/u62Z9 2C0u1RaebAZ8xyZGiue9NLmQFYG4= X-Received: by 2002:a05:6214:246d:b0:699:3f45:44ae with SMTP id im13-20020a056214246d00b006993f4544aemr2973295qvb.6.1712347063962; Fri, 05 Apr 2024 12:57:43 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240405053510.1948982-1-yosryahmed@google.com> <20240405053510.1948982-4-yosryahmed@google.com> In-Reply-To: <20240405053510.1948982-4-yosryahmed@google.com> From: Nhat Pham Date: Fri, 5 Apr 2024 12:57:31 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: zswap: refactor limit checking from zswap_store() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 4, 2024 at 10:35=E2=80=AFPM Yosry Ahmed = wrote: > > Refactor limit and acceptance threshold checking outside of > zswap_store(). This code will be moved around in a following patch, so > it would be cleaner to move a function call around. > > Signed-off-by: Yosry Ahmed LGTM. Reviewed-by: Nhat Pham