Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp84950lqe; Fri, 5 Apr 2024 13:30:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWxvTy1UkFNYK4UQXk1IQ+pf+3ktzi0f6ss2Cbp2Qlu96okKt3bcqoj7ZaFvupmey+1tcastT+88VF9bwZgsDCoOF0zQSV9IFMeXzjuMA== X-Google-Smtp-Source: AGHT+IGX6xly+BpZ5vByc5jpuvr+OgUxUdTDIVKATYPDGr7tRQKtH5RJNr2HMgNAAO8TfSNfhehN X-Received: by 2002:a17:90b:3795:b0:2a2:53ee:bd08 with SMTP id mz21-20020a17090b379500b002a253eebd08mr2465994pjb.8.1712349030079; Fri, 05 Apr 2024 13:30:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712349030; cv=pass; d=google.com; s=arc-20160816; b=gL/rdJU509b/vrlhcYrJuldnP3hUvdZAEzv9sskn5hKIWn2O5hB84LC4ORU+6mEJq8 O8QWUnBLj2olKQ/Gu/kZa/mmc4xO6UzwhENqZmFxS7c2HGJtntcv0A9PDatEMdRAH2W+ z7WbSyzFS3ujfVd324gs+aRS0QYOqx1m+voq5Tq8iZZ9QIubOPSHwKXd/8kI4FBhNOzv kSZECzxATcFWtsDv99lsjGpPxYxobHsGgtK37+aT1yBOETdfkou8N7JZk+35YA0/1EUR o0KZFqxNqFcJG/ilGeGB1FpzGhjngJokGRbY/zgLTiz9cG6lpvyk22ztryTv05Tfs+kL p7Ng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; fh=EPPJc3H1RUKpmbXFOydaW2t8oJxyDVfLQyt8F3qPgL8=; b=irAUVDQjk27ds1bRlcWGCTWiG7sN0l1n33wcv4WDl8h8c/jls1XGcQw+jchV4VIEju ZihIMktGvQmygfoKApyrAKKYrA666VSspnrD8OTe7mTP2Weqi4RhU/9clNIDUZwtg7MJ coHBrGN1QUfxFgwfPnExwfEqi4eSsfyYywwGkwdMzXIwXsrVQI4bDUsmkjiVeGJgf+7S V/DMgFSeFNQH8Zp2OkliID/P19+SDg8D+plbNktUSaQv6XLYsfaEpE6WtAoxG7Tn8lG3 bEZXZ75L5XTbhBtAaJf4n2pjKFS71XJEg7BJfS6WEU3OYfrr+vliShz0FqDP4ssXAPhc KJzg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="a/EVNn90"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-133564-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133564-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z24-20020a17090ab11800b002a3f003170esi1737885pjq.109.2024.04.05.13.30.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 13:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133564-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="a/EVNn90"; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-133564-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133564-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 387DBB22226 for ; Fri, 5 Apr 2024 20:30:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E359174EEC; Fri, 5 Apr 2024 20:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a/EVNn90" Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8B91C6A8 for ; Fri, 5 Apr 2024 20:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712349021; cv=none; b=K+zYx14e6CejUSb9JwQiOIc6a2IdC6HOLr44hoYmYzeXJGD12RBqMp3Yy03/KJOz8CM1wF11rTLe5psm75kduAyqzJJpKAd1gbZnmrEsVa0p1GbAz0p1i79JFEwuCnU6F70LqjlpNFMUOJ11NOvzFDHSA9jpf4Vjmi3Y5RRoYvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712349021; c=relaxed/simple; bh=nV9Y5sZu3ZPCtOva3EsmstVhIY4akSsXCrbWmGpcqII=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=UoWaT2bjggaE2/7adqswUTkmIugxsk5iM5zIOcfOy7IUEEx9qq0mDy34ithJ7yUBxMdqoTfqU1Ah4gJuKGwtWTzB3Z6fB8Stp613X8dLFEzdA5KPymFsEYegbKhrcMalv36T1hg6uC6LP+4vhnn9rQUJ7orEWDzzMAdhVubn64A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=a/EVNn90; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-516c97ddcd1so3198366e87.2 for ; Fri, 05 Apr 2024 13:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712349017; x=1712953817; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; b=a/EVNn90WRiXj9Vw0QiTi8Q6AErYMnjvoCvIFDXeoV3Xy5iRGFT1jHIlKhwgl5YyOh YNWctOY2eOqx+dT053BAiWSYDrOrhWVX4C3iDbdDwkjpIvVTr8OX0Umxhc5/Mpm9Wu1D jW+4j/LOI4coMyvjrX17DhRv0X1zH7UFjLfb3Hy+4ckwf5eIv6Kv0n5r++H/ydniIFkD h7tTa+ugZ0o1yGrxPkjCj3aDnkdAp6BDfrO3bnt6p5pk8rcMMw8tOq6yNXipiFK0ANsq tiFQFXk+6Bwzd72jihCiSZota+UB8dtKKfck1yMwIMCAs3IQPg9KHwjuWfyHUQ4hePeh ip8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712349017; x=1712953817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M+jEmOFEjTU7lwjjt1V5FPrXRPUYL1ukEXhP8ohspNk=; b=vyvupwbr/sWd2EybnR0EWq9vI8s90O2pKilqBU1EuYLAuzB7rU7JInoi7Va4uJQspV T09akuafCU06cZRNSpS8O6Rc0Qb1GueljVpJ1VxKw6EhA2PX7FC7+pEUw9xVh0oaFJ5w V2snjjB+LXpXnRD5v7Bt5gokR8ysmXQZqwHjmbPckfFZqG8EdZVgiMOnmuIMFaTrecU8 uY8jWWY8y4gtYIjQQfNb0Nssffpwgi+Ut2riXaIsVLKDNJEI7ICVeV83FZeCmW4XAkUM GMmPhknqnSB/9g+8mTW8cCTJtVioY/snuXrP6hMS/GLtvUCnKsb+J5MmvsDlztwpULUf UfwQ== X-Forwarded-Encrypted: i=1; AJvYcCVG3nCAoKyjWVpeCs2zkCohZBqZPPtvOOEAp3D4IaGkgNhE/67ZZllLMwQQZ4LZev+DeNwxSQRQhYzQSNnptQvltlMki6Jy1mBw+Nr/ X-Gm-Message-State: AOJu0Yy7/H5GgtStMYZ/+iW+KtrJwnA47TcAjHOBo1Vuvm/2SKaLGb5p QweRQgMLuNnJRs/QhAl6/bUw19A80h9j/6xedU0SjK+u811o582Yd5NLDOlI8GIOk8f2DBr/Ecz C9LueOxmC9+b+adSr4lm5zBaIAXjCw5kfkW8I X-Received: by 2002:ac2:5964:0:b0:513:edf4:6f20 with SMTP id h4-20020ac25964000000b00513edf46f20mr1622327lfp.54.1712349016554; Fri, 05 Apr 2024 13:30:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240405053510.1948982-3-yosryahmed@google.com> <202404060445.zMPxumi9-lkp@intel.com> In-Reply-To: <202404060445.zMPxumi9-lkp@intel.com> From: Yosry Ahmed Date: Fri, 5 Apr 2024 13:29:38 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm: zswap: calculate limits only when updated To: kernel test robot Cc: Andrew Morton , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Johannes Weiner , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 5, 2024 at 1:24=E2=80=AFPM kernel test robot wr= ote: > > Hi Yosry, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on akpm-mm/mm-everything] > [also build test WARNING on next-20240405] > [cannot apply to linus/master v6.9-rc2] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-zsw= ap-always-shrink-in-zswap_store-if-zswap_pool_reached_full/20240405-133623 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-ev= erything > patch link: https://lore.kernel.org/r/20240405053510.1948982-3-yosryah= med%40google.com > patch subject: [PATCH v2 2/5] mm: zswap: calculate limits only when updat= ed > config: i386-randconfig-061-20240405 (https://download.01.org/0day-ci/arc= hive/20240406/202404060445.zMPxumi9-lkp@intel.com/config) > compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0 > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20240406/202404060445.zMPxumi9-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404060445.zMPxumi9-lkp= @intel.com/ > > sparse warnings: (new ones prefixed by >>) > >> mm/zswap.c:132:15: sparse: sparse: symbol 'zswap_accept_thr_pages' was= not declared. Should it be static? Yes, I already have it static for v3, which will be sent after the discussion on this patch settles.