Received-SPF: pass (google.com: domain of linux-kernel+bounces-133567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d103fdc2-e7a1-4658-88ab-22929ae48a06@collabora.com>
Date: Sat, 6 Apr 2024 01:38:06 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 "kernel@collabora.com" <kernel@collabora.com>, Shuah Khan
 <shuah@kernel.org>,
 "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-mm@kvack.org" <linux-mm@kvack.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in
 ksft_exit_fail_msg()
To: "Bird, Tim" <Tim.Bird@sony.com>, Shuah Khan <skhan@linuxfoundation.org>,
 Kees Cook <keescook@chromium.org>
References: <20240405131748.1582646-1-usama.anjum@collabora.com>
 <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org>
 <SA3PR13MB6372E672EA40B403EBE588EDFD032@SA3PR13MB6372.namprd13.prod.outlook.com>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <SA3PR13MB6372E672EA40B403EBE588EDFD032@SA3PR13MB6372.namprd13.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Tim,

On 4/6/24 12:36 AM, Bird, Tim wrote:
> Sorry I didn't catch this on the original submission.
> 
>> -----Original Message-----
>> From: Shuah Khan <skhan@linuxfoundation.org>
>>
>> On 4/5/24 07: 17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then this added prefix
>> doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed"
>> ZjQcmQRYFpfptBannerStart
>> Caution : This email originated from outside of Sony.
>> Do not click links or open any attachments unless you recognize the sender and know the content is safe. Please report phishing if unsure.
>>
>> ZjQcmQRYFpfptBannerEnd
>> On 4/5/24 07:17, Muhammad Usama Anjum wrote:
>>> "Bail out! " is not descriptive. It rather should be: "Failed: " and
>>> then this added prefix doesn't need to be added everywhere. Usually in
>>> the logs, we are searching for "Failed" or "Error" instead of "Bail
>>> out" so it must be replace.
> 
> Bail out! is the wording in the original TAP spec.  We should not change
> it unless we plan to abandon compatibility with that spec. (which I
> would advise against).
> 
> See https://testanything.org/tap-specification.html
I didn't know that exact words are coming from TAP. Thank you for catching
it. We don't intend to move away from the spec.

> 
> The reason "Bail out!" is preferred (IMO) is that it is less likely to be emitted
> in other test output, and is more 'grepable'.
Makes sense.

> 
> This would get a NAK from me.
Let's drop this series.

>  -- Tim
> 
>>>
>>> Remove Error/Failed prefixes from all usages as well.
>>>
>>> Muhammad Usama Anjum (2):
>>>    selftests: Replace "Bail out" with "Error"
>>>    selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages
>>>
>>>   tools/testing/selftests/exec/load_address.c   |   8 +-
>>>   .../testing/selftests/exec/recursion-depth.c  |  10 +-
>>>   tools/testing/selftests/kselftest.h           |   2 +-
>>>   .../selftests/mm/map_fixed_noreplace.c        |  24 +--
>>>   tools/testing/selftests/mm/map_populate.c     |   2 +-
>>>   tools/testing/selftests/mm/mremap_dontunmap.c |   2 +-
>>>   tools/testing/selftests/mm/pagemap_ioctl.c    | 166 +++++++++---------
>>>   .../selftests/mm/split_huge_page_test.c       |   2 +-
>>>   8 files changed, 108 insertions(+), 108 deletions(-)
>>>
>>
>> Andrew, Kees,
>>
>> I will apply these to linux-kselftest next as a series since these
>> changes depend on change to tools/testing/selftests/kselftest.h
>> and need to go together.
>>
>> Are you okay with that?
>>
>> thanks,
>> -- Shuah
>>
> 

-- 
BR,
Muhammad Usama Anjum