Received-SPF: pass (google.com: domain of linux-kernel+bounces-133569-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Mekala, SunithaX D" <sunithax.d.mekala@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "David S . Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>
CC: "Neftin, Sasha" <sasha.neftin@intel.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Bjorn Helgaas
	<bhelgaas@google.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, Zheng Yan <zheng.z.yan@intel.com>,
	Konstantin Khlebnikov <khlebnikov@openvz.org>, Heiner Kallweit
	<hkallweit1@gmail.com>
Subject: RE: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime
 resume for ethtool_ops
Thread-Topic: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime
 resume for ethtool_ops
Thread-Index: AQHafwQV/Uu+l7+5s0Kiy5T16ALscbFaNAQg
Date: Fri, 5 Apr 2024 20:41:15 +0000
Message-ID: <PH0PR11MB7522DF37FA0185E56DF02C27A0032@PH0PR11MB7522.namprd11.prod.outlook.com>
References: <20240325222951.1460656-1-helgaas@kernel.org>
 <20240325222951.1460656-3-helgaas@kernel.org>
In-Reply-To: <20240325222951.1460656-3-helgaas@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dqx5tKyU6gieO1kVirEiPtgziE/3SzsK6Fc+GhgD+undaL9lIpUtcP1zZ939?=
 =?us-ascii?Q?ZO6zrCDtkH2uXC1l3xXnVfQfzLYzxaJnTmzAUPOVpYTkhMwmCzeCbXyuieL+?=
 =?us-ascii?Q?YI4z0CY2H4bbkIdx53QbIpBF0gcZ8qxwYbWbYhgFF6aH/4s+s2uDMnu+2qR8?=
 =?us-ascii?Q?7WIiIFVKW4RvSI+G1jm42IUAGdc40AqnHQCsvQtNkIIklBrXmwDyE482JHK7?=
 =?us-ascii?Q?QVCuLd8qHS+dVvuPZ5owI4PRkeZ8TGm2rBcuig04BHZe0uhn5eW4q1zbSpMs?=
 =?us-ascii?Q?ItBRoIpfeNogPXjKfdDFXN6sBh3+abnyhPECrnMMKQ5xuyLnRjkrEuiOB2Ix?=
 =?us-ascii?Q?HOcnTDcXzq0245i7PLBqTrH3K5ziDn+MaXDUD4tUUXdOklritMulM5EAQWKk?=
 =?us-ascii?Q?MmPn1G7wOGDjQaC9CV69JsYeGiTxvQKiMyoRgbBgxyN19+6UF//G03iyrvgz?=
 =?us-ascii?Q?Z+QOzt+lvGXkVDGtNKHvG7IoJkNS6ly+HZQlM8efRsicRgjqqJjMqNU+bxHW?=
 =?us-ascii?Q?zYruOtcR/jFiX7i35Y51AzgY3yvbISfN79OEak53IkNuFI1hIlGEQkf6xyn5?=
 =?us-ascii?Q?SV+Y5Xh8D4S1T6E9zE2WrCPWvUrnJyt5Qxa1BGf38xJgBgyIXEA2QUKdTOVH?=
 =?us-ascii?Q?WsJGv8sA7VBP/vlqyYCtmhsDWiT4Bvc/YNUFEer54ypxmCIj9EwjAf1FQHK+?=
 =?us-ascii?Q?2b5xj7JhhPwKbtqQVd0w+QPX58DW0shO9iT8uLcRoPazlBuUWUPsgZlUR4g3?=
 =?us-ascii?Q?xhQHiE4s6sv7GT4aloBCsioTKTjj8i6gdLGkXuTbnC4rTKWnffLkNdappx15?=
 =?us-ascii?Q?TcBOnsz1qyISQmgiplkq3g5I0e0kcWfoViA/7TFb5GBaFMKGRBCsL13Ba1H5?=
 =?us-ascii?Q?gO372cDs1OpZ4w85ldCl6/zKk4GagyJaqPTXEN5/blNuEHOPCHQfXqMCEGoZ?=
 =?us-ascii?Q?858G1TtY+6qUyWjRr72JBmL+eJAgg3QE9ExGzCOw8oO8hORg4qQRK0b0t74c?=
 =?us-ascii?Q?XhA7BnZiXxwOHmYsvrt0YOvSjS8Thh9x3Y5JJvygpSSXLZaihE5TiPCZbnPL?=
 =?us-ascii?Q?EI+5dnBTGaLMqmNkK4ww69i7tvnf+5ZzFv8FjHsUnNFrylDFJAhb9VqLocSH?=
 =?us-ascii?Q?Wfxw9lsOMoPwZ/kZ0D530uGvPf578WDjTZtfdOat0B0azP8XTmimYmfTN+3Q?=
 =?us-ascii?Q?nGI7IKKaxIxyeGFlQ9hFCo9ifq9gNoXiye9JJavijHBBqAGB05QgCHVD+V/b?=
 =?us-ascii?Q?uirl7ZJAAAobVIOhb8h7kn6VAdE/Q+bbcr0CsnENYZ++yOrG+vwGO2FfyVeM?=
 =?us-ascii?Q?iblmQiMPusFJkKl5Prvs9oS7WaWM1Ft+auMLX9q10j6/vW27hRhqlmjqk5b/?=
 =?us-ascii?Q?OYji/PP7vsFSzi+mRs0VUH/gUUdEy8QWE7X+TS5p5S2McTLyW2+rqEEYLKZn?=
 =?us-ascii?Q?2jrDQbaYmis69+0v8LeObZwAZJK13NvSYF2Xe5XSPMtsTcgGIyrfy3vWDbq8?=
 =?us-ascii?Q?HakootxMpPQNWqKXakuu04UXXrCNi+K0Pevhm56f/o2mDh/Iv1mFUkrIJrkP?=
 =?us-ascii?Q?/2VgMqnERkaA4aXU38z8lf9YagN5RUKYrzEEGGKO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7522.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97593be8-c8a1-426b-1b59-08dc55b0bd73
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2024 20:41:16.0368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W3Fp03aMJrhCsLsOGME4+5a7tarHeJcbD3HZNTXTcImVufHlV2xiNzQpSi2HImCXUB1qd27nMcAumdqTTiafLdDMs4IFrcSiKHefqqRj7mw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7348
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of B=
jorn Helgaas
> Sent: Monday, March 25, 2024 3:30 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S . Miller <davem@davemloft.net>; Eric Dum=
azet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <=
pabeni@redhat.com>
> Cc: Neftin, Sasha <sasha.neftin@intel.com>; netdev@vger.kernel.org; Wysoc=
ki, Rafael J <rafael.j.wysocki@intel.com>; linux-kernel@vger.kernel.org; Bj=
orn Helgaas <bhelgaas@google.com>; intel-wired-lan@lists.osuosl.org; Zheng =
Yan <zheng.z.yan@intel.com>; Konstantin Khlebnikov <khlebnikov@openvz.org>;=
 Heiner Kallweit <hkallweit1@gmail.com>
> Subject: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resu=
me for ethtool_ops
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> 749ab2cd1270 ("igb: add basic runtime PM support") added
> ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
> resume suspended devices before any ethtool_ops callback and allow suspen=
d
> after it completed.
>
> Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
> ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path=
,
> so the device is resumed before any ethtool_ops callback even if the driv=
er
> didn't supply a .begin() callback.
>
> Remove the .begin() and .complete() callbacks, which are now redundant
> because dev_ethtool() already resumes the device.
>
>Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worke=
r at Intel)