Received-SPF: pass (google.com: domain of linux-kernel+bounces-133702-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <1707982910-27680-1-git-send-email-mihai.carabas@oracle.com>
 <1707982910-27680-8-git-send-email-mihai.carabas@oracle.com>
 <7f3e540ad30f40ae51f1abda24b1bea2c8b648ea.camel@amazon.com>
User-agent: mu4e 1.4.10; emacs 27.2
From: Ankur Arora <ankur.a.arora@oracle.com>
To: "Okanovic, Haris" <harisokn@amazon.com>
Cc: "mihai.carabas@oracle.com" <mihai.carabas@oracle.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "joao.m.martins@oracle.com"
 <joao.m.martins@oracle.com>,
        "dianders@chromium.org"
 <dianders@chromium.org>,
        "ankur.a.arora@oracle.com"
 <ankur.a.arora@oracle.com>,
        "mic@digikod.net" <mic@digikod.net>,
        "pmladek@suse.com" <pmladek@suse.com>,
        "wanpengli@tencent.com"
 <wanpengli@tencent.com>,
        "akpm@linux-foundation.org"
 <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>,
        "catalin.marinas@arm.com"
 <catalin.marinas@arm.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "tglx@linutronix.de"
 <tglx@linutronix.de>,
        "daniel.lezcano@linaro.org"
 <daniel.lezcano@linaro.org>,
        "arnd@arndb.de" <arnd@arndb.de>, "will@kernel.org" <will@kernel.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "npiggin@gmail.com"
 <npiggin@gmail.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "linux-pm@vger.kernel.org"
 <linux-pm@vger.kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
        "juerg.haefliger@canonical.com" <juerg.haefliger@canonical.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
 <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 7/8] cpuidle/poll_state: replace cpu_relax with
 smp_cond_load_relaxed
In-reply-to: <7f3e540ad30f40ae51f1abda24b1bea2c8b648ea.camel@amazon.com>
Message-ID: <87r0fjtn9y.fsf@oracle.com>
Date: Fri, 05 Apr 2024 16:14:49 -0700
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?1rbX/tAPUfKMjmAr6d9s8SyhDZyHq1WGGXMLiAtQ4XZaHpwkyBm9rJ5M5Ue+?=
 =?us-ascii?Q?PDXdDRsP3yB+GjSUlbnib2/V7wyYtaoJvxyLbmOHH3XgIMOwnSpDD80iSYE5?=
 =?us-ascii?Q?bROcE+J9hCXLWJcqWI1K0t2fvAiZlKIb1HclmHFVVRTG0PoDZ+ADxYNEwzEs?=
 =?us-ascii?Q?vHXNNI73ioU3w1d3YyCuSeRpwrVhgwPG73Bh7qUrMdvem4UMkfpvejgTnJsr?=
 =?us-ascii?Q?Dy/wQMyBd7G8rW8clUeQ1SD/j0r6vxm8AfR2B6kAZTMZ8tP60JGrY4VHk9m4?=
 =?us-ascii?Q?D3SR6hbMU/euJt7fJIF/4TNnjesUse5dGXBGVnIs2/dGZi/KavHT0eMk9pw2?=
 =?us-ascii?Q?WwIehzreqKq/M6L6gP/zBt7Af2d5xsMdY8vFVybiFf1m3ZcCMIfZUQKsRsHA?=
 =?us-ascii?Q?5TosUh/oibbTvd0ZbHzQCepr5g0LyByg4wgiXN33Z00bUyxBrT/cWLgSkzoa?=
 =?us-ascii?Q?q3h51f5F99myjFL8HMD5q39g49fz+yj6D7ps0YcDTtHcf2+Ya9CWcMsdWbdU?=
 =?us-ascii?Q?fCwoCJ2faxD4Y4Q2mVeZYi80vSwzviBadwIR1ffT6hyCQZx8IOfB8d1BiT05?=
 =?us-ascii?Q?62Yl2SfZnPGM0pmELP0YiDwQFyCepYwIJDjiECPvbZu2VFz0DqmABHv/bPVR?=
 =?us-ascii?Q?HuAEduGzVPrR0sK8pSibWEnenurUWauEXbfrqzjp3P6zFwEV1SW+KngL9YlE?=
 =?us-ascii?Q?KBwFtWkJnCpvO9g4kDEkPU9WMKQNTMoNbbBIincbwKggdVd/hdOsrULZNlHc?=
 =?us-ascii?Q?wbJVtpOtkLZRxvcSIP257hHT3J1LO9RjIw0Exc0sjaQpcisZfWNEh9ZSCmnb?=
 =?us-ascii?Q?eAjvNDgZvKQPbgHE+FZ8ROE5r/Xz0snGjYgyM8NrmNGo7RwPS0jahJDEmpY9?=
 =?us-ascii?Q?ti2tT1Yu0ZS1qQ2oZuZfn+LmkFBfy0x22w4yrL6azAGEQfdZCSzyte4QJs73?=
 =?us-ascii?Q?tyT77/p4/mOHeu2ND4JTz8eQcWkAsD3A4HcgNuTHGQvvFqRkCZRLEOwcsXtc?=
 =?us-ascii?Q?MNzz5hLlCmhkjPUzNaBpevAnw/0fW9BEVCY63V+IWhm7zZWY4P8RNZkHuIyX?=
 =?us-ascii?Q?k716HaD645cJvD0IjiMNIATmh2cF4ylnvlhUM1SYIuXZGJ1IPEtC/LcHvZrO?=
 =?us-ascii?Q?ywK5NG1AckX31/NRALN57Y8UOWFOYLyMr1mQNO/o4rQ49tTW8kR7LrLGI9O9?=
 =?us-ascii?Q?b6Vj+zZGm5BzINRZ6a+NkpNAl78+KstBPZatYgzGtKMiN/lRA8m1VjVFHUfo?=
 =?us-ascii?Q?QiOhkLSuj0+s37sI0DGAHBaJCgjXT+lnBjRF82t5gblz9eAkSYH2hYriYpLx?=
 =?us-ascii?Q?MF8djE7DAB1cZ/Y937RkzpqdXfhakuPgbqYYx8t0/NzvRPSbx2vKXvRMgo+K?=
 =?us-ascii?Q?b/cYkAlYRuiCxJ5Kqm01fqsi7bkKWorpc38+yyU57OFNuwsOOckPF3Kq+37k?=
 =?us-ascii?Q?2U1DMPTheIx2EiiXt1Per//cSHeep1z7HwE0m80Ps9SLP+KJHhU2SeF5k/1B?=
 =?us-ascii?Q?fxmT2xgLWR+Pj4yfAHGu29E0iNGsMu4562YLCNySkjZQauwR4h70h3sXq/7H?=
 =?us-ascii?Q?nQSmAeR4QqkQFqAJig6hM9IhMgyJ4ZbUkxp/+ZI0mo1s+DvwUvh0N4SrQxlN?=
 =?us-ascii?Q?gQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	pTG+c0OpV8VbGnQA9x4oOCOrHTmieeWXQffoftNveGlZ59YuM2ShyKRmvB3QG/ElgHSpHsXhpviaja/JQwsL5yGZCJQxQOYPyEUQFFh8Dbc2zegFKHAN2oYdVcUGMvG8mrykJYjE7h/cL10bNA6thfJPDOwVV87VgO75UkGvXA4I0arUwTfWkaVCH/ZezNNqPeDio2hqsnstXseUsB+EQ+98do63y9Ly149KCImfNFSRO/54VMnPIhu1ljri0RshjeIIdRY44Y/MTHS+xFL4Tg3AIXjX3w4fqtxM0T38i36+O5ynpRElo2M8a7APKC5b0VVjZDG1yFUf3o4Py03ifFaKSw/UH3gXkYfDll9Hn209IH0FOkTnbEzzz698RiBEpLCnUnLBcbkB7rfTkS2wHDrnRgMuCBz82OYNAYlGdErWf11r+Ldmq3ZE9trEgoqWj2seTjrlGHmkCTSJlZ4DHYeBzVRfLwe+EWcdINCVWd6rRitK1QyGN+6Gmf0rjct27zzqKBxALHW9Xm4fW1Qlv5hjQSTfEi5baMTBSRVywEU5D/vDLdIEX/O/CA3UojIFqKf2RNTRIfh3KNFfTkwWYu1PLC8AgkhGvDyOyK1QP2E=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0592899b-9881-4838-fd93-08dc55c615f9
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 23:14:04.2444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YjYpXidC2rRuMl9P77+Ut7v6ILFTSytgl6vVyw4PMcTCM8J4VzPTwiCszhzj2CiO9x+btY+xnxQnC64JamBM97xrNXJjTi6ziF8ow++cEQY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5868
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-05_28,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404050167
X-Proofpoint-ORIG-GUID: Xivgl_nI13iEgjgHJCptWL4kdF74p6Mq
X-Proofpoint-GUID: Xivgl_nI13iEgjgHJCptWL4kdF74p6Mq


Okanovic, Haris <harisokn@amazon.com> writes:

> On Thu, 2024-02-15 at 09:41 +0200, Mihai Carabas wrote:
>> cpu_relax on ARM64 does a simple "yield". Thus we replace it with
>> smp_cond_load_relaxed which basically does a "wfe".
>>
>> Suggested-by: Peter Zijlstra <peterz@infradead.org>
>> Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
>> ---
>>  drivers/cpuidle/poll_state.c | 15 ++++++++++-----
>>  1 file changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/cpuidle/poll_state.c b/drivers/cpuidle/poll_state.c
>> index 9b6d90a72601..1e45be906e72 100644
>> --- a/drivers/cpuidle/poll_state.c
>> +++ b/drivers/cpuidle/poll_state.c
>> @@ -13,6 +13,7 @@
>>  static int __cpuidle poll_idle(struct cpuidle_device *dev,
>>  			       struct cpuidle_driver *drv, int index)
>>  {
>> +	unsigned long ret;
>>  	u64 time_start;
>>
>>  	time_start = local_clock_noinstr();
>> @@ -26,12 +27,16 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev,
>>
>>  		limit = cpuidle_poll_time(drv, dev);
>>
>> -		while (!need_resched()) {
>> -			cpu_relax();
>> -			if (loop_count++ < POLL_IDLE_RELAX_COUNT)
>> -				continue;
>> -
>> +		for (;;) {
>>  			loop_count = 0;
>> +
>> +			ret = smp_cond_load_relaxed(&current_thread_info()->flags,
>> +						    VAL & _TIF_NEED_RESCHED ||
>> +						    loop_count++ >= POLL_IDLE_RELAX_COUNT);
>
> Is it necessary to repeat this 200 times with a wfe poll?

The POLL_IDLE_RELAX_COUNT is there because on x86 each cpu_relax()
iteration is much shorter.

With WFE, it makes less sense.

> Does kvm not implement a timeout period?

Not yet, but it does become more useful after a WFE haltpoll is
available on ARM64.

Haltpoll does have a timeout, which you should be able to tune via
/sys/module/haltpoll/parameters/ but that, of course, won't help here.

> Could you make it configurable? This patch improves certain workloads
> on AWS Graviton instances as well, but blocks up to 6ms in 200 * 30us
> increments before going to wfi, which is a bit excessive.

Yeah, this looks like a problem. We could solve it by making it an
architectural parameter. Though I worry about ARM platforms with
much smaller default timeouts.
The other possibility is using WFET in the primitive, but then we
have that dependency and that's a bigger change.

Will address this in the next version.

Thanks for pointing this out.

--
ankur