Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp162186lqe; Fri, 5 Apr 2024 17:02:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW4xEA8qLXFY+OJzu6NrXTk8uXxXSzVLmL64kqdi83nMxRCUqWM01jX/Aa+CjNZ0d9oiL4uealrGDCKWPipOXgTQsPhylt6YYC2F5U5ow== X-Google-Smtp-Source: AGHT+IFl8A9RdWF/kxvxuauooAI2QqDq3sffebRFEe2Ls+LhbxfXILF7TtlvrKofsS9vhQtpxPbt X-Received: by 2002:a17:906:29d5:b0:a4e:57c5:e736 with SMTP id y21-20020a17090629d500b00a4e57c5e736mr2193435eje.25.1712361754926; Fri, 05 Apr 2024 17:02:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712361754; cv=pass; d=google.com; s=arc-20160816; b=ogogjVCTB+9sCUW5Sp5fMPx+YXLXcsJ2LYAhUIGuNuqgQl+6RIj8zD1tQgnKZ7XSzm FBJVNNPg7OryS0eDUuuF9a3doG5X5kdeXkSem/+x0helCv3oz5plm3+e7wI2eYCKPbtr Tc19GCPXwZ+VUddQiuQEItDKXotypasrITXrydn0oyA/Vd9tfl17m2O/IZWTCDX4OdDm v1+KHaiFPNY4vvFM5JT8H2OBDZis3hprR707YdbRnvozztXO5fb/SVmAAf4gR8tRm9JC bamVyFGjkyNChtVgIiB7dQQ7unbaBv2/SPx1NC2Ij4BgJpspvCefF9lBrLIFVeewFNz8 JcwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=PXekh14e5Dg+R5HZ+AYmLOJmzOiuzWVnbCpjT3dz/ec=; fh=6ItT6a40bb2SjcEub3w2uacgTqy3t+UXXWJueNXo/1w=; b=NAI1kqVZ2QoYA6IgQulY5+dOReY8d7Y5z5hjTVZGeLCrqbpYxZchchCFjviS8z9ZMV DgasLWL2/Ptr8e+oygj09eEXuc/wNU/fbsAmrxUaURpxAtUQgL3QzYKL+Vmm8hxiWTxU Gyi/yZLQIeICYCJxsX2/PGbljTXDsK/3tQ3U6m2xUJEloXgqny0CI0rY5HKjehzuiqnS bLywEeqSxcld5yg63COD+o2FlWgjSCAsKbbZfF3ZxNb5CJhiFUQVp8dXyGJIPHLJ3ko3 vx7vhBw0tdOj+HEjDDMIROmY3hTkPxBYRj+ogh526jYWWEq/vNxyfKPP2RyY/ee+rYsD oECg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=irl.hu dmarc=pass fromdomain=irl.hu); spf=pass (google.com: domain of linux-kernel+bounces-133726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133726-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id le3-20020a170906ae0300b00a51930774a4si1164902ejb.615.2024.04.05.17.02.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 17:02:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=irl.hu dmarc=pass fromdomain=irl.hu); spf=pass (google.com: domain of linux-kernel+bounces-133726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133726-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=irl.hu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A42851F229AD for ; Sat, 6 Apr 2024 00:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B9A93FB1D; Sat, 6 Apr 2024 00:01:53 +0000 (UTC) Received: from irl.hu (irl.hu [95.85.9.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D081E533; Sat, 6 Apr 2024 00:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.85.9.111 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712361712; cv=none; b=BcbkEXDYb7kEOinlg10PBjQjLTWmLH4rB4hv2Sdr5cpvyDpSq2bQANtSW9Z9S0n8BIUBvMQKy+RwYk3T++Y0+JUG4t0cntTOz+wfAliCEtSF//IvyZF1xgdvhbR1kGDkaF1vNp01OBdrOf4FSwe+IwSjuy4cG/q8KV1TBrbaT9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712361712; c=relaxed/simple; bh=ReyZ/SK2T9RJMzqGhOr+f/IyAMkYqv/fQkx3qjS6WBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Mime-Version:Content-Type; b=TwmICj7IsWCuQ8DFOLtzJlSkA2xXlxyZcD3Veyze+hbxlFKVRSAKvR6RWSSEq9CKGHNop0kn9y9ZWPCN5WI8Adf3irpi8ceMTYAjDopNR9ySFI+KKbUF+kjz+8XjWsxEZnVipg76+bCTOmkisTBhvk8Wcpu1QdY7aJoLrd8lQUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu; spf=pass smtp.mailfrom=irl.hu; arc=none smtp.client-ip=95.85.9.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=irl.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=irl.hu Received: from fedori.lan (51b69f53.dsl.pool.telekom.hu [::ffff:81.182.159.83]) (AUTH: CRAM-MD5 soyer@irl.hu, ) by irl.hu with ESMTPSA id 000000000006F9A2.00000000661090ED.0025D582; Sat, 06 Apr 2024 02:01:48 +0200 From: Gergo Koteles To: "Rafael J. Wysocki" , Len Brown , Ike Panhc , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Henrique de Moraes Holschuh , Daniel Lezcano , =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Cc: linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Gergo Koteles Subject: [PATCH v5 3/3] platform/x86: thinkpad_acpi: use platform_profile_cycle() Date: Sat, 6 Apr 2024 02:01:33 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Some Thinkpads have a 'mode' button that switches between platform profiles. Use the new platform_module_cycle function instead of the existing switch-based one. Signed-off-by: Gergo Koteles --- drivers/platform/x86/thinkpad_acpi.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 82429e59999d..771aaa7ae4cf 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -11190,23 +11190,8 @@ static void tpacpi_driver_event(const unsigned int hkey_event) else dytc_control_amt(!dytc_amt_active); } - if (hkey_event == TP_HKEY_EV_PROFILE_TOGGLE) { - switch (dytc_current_profile) { - case PLATFORM_PROFILE_LOW_POWER: - dytc_profile_set(NULL, PLATFORM_PROFILE_BALANCED); - break; - case PLATFORM_PROFILE_BALANCED: - dytc_profile_set(NULL, PLATFORM_PROFILE_PERFORMANCE); - break; - case PLATFORM_PROFILE_PERFORMANCE: - dytc_profile_set(NULL, PLATFORM_PROFILE_LOW_POWER); - break; - default: - pr_warn("Profile HKEY unexpected profile %d", dytc_current_profile); - } - /* Notify user space the profile changed */ - platform_profile_notify(); - } + if (hkey_event == TP_HKEY_EV_PROFILE_TOGGLE) + platform_profile_cycle(); } static void hotkey_driver_event(const unsigned int scancode) -- 2.44.0