Received-SPF: pass (google.com: domain of linux-kernel+bounces-133752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
To: Andrew Halaney <ahalaney@redhat.com>
Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam
 <mani@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin
 K. Petersen" <martin.petersen@oracle.com>,
        Hannes Reinecke
 <hare@suse.de>, Janek Kotas <jank@cadence.com>,
        Alim Akhtar
 <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        Bart Van
 Assche <bvanassche@acm.org>, Can Guo <quic_cang@quicinc.com>,
        Anjana
 Hari <quic_ahari@quicinc.com>, Will Deacon <will@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Manivannan Sadhasivam
 <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com>
	(Andrew Halaney's message of "Fri, 29 Mar 2024 15:46:42 -0500")
Organization: Oracle Corporation
Message-ID: <yq15xwvs3fl.fsf@ca-mkp.ca.oracle.com>
References: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com>
Date: Fri, 05 Apr 2024 21:09:06 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?xIDLKGagk5qwMHM9GRqKhqdYfRaS5xoTSEemitSLHIrZ0OOxQdPf/5ZhVeAt?=
 =?us-ascii?Q?KgnEnc/YKn6HQ9c+k2bFKxKhT1OCCjBZa+ZMz0u2cd3X+NTIcgZqHvRm+wka?=
 =?us-ascii?Q?uxEH7TIEMeLtcm+JASXVMq1J9MWTm1UCRYW/p4wP/LHVOwX/rivNMwiJxPCQ?=
 =?us-ascii?Q?+vK8nVMEJLgcb75bng7Ye2zSZuxENvI1TX5sT4RGecQCPzwBu+dBnb2yr4V6?=
 =?us-ascii?Q?7jG+uOcYFGZl759nHywfVf1OSsNhtaK8hwden6mfwuFODKOLwulaPIVA+/fI?=
 =?us-ascii?Q?3N27Vmq4/U8kjbg+CeZ1m/4Zh7aV48bQ4C3emJgD/5WrYlvGJkcxU6vvMl55?=
 =?us-ascii?Q?GlPv+CDVqb4ILoda7KvsNO5vqwoAkLEezOGIPhyFn1pVK9j4Zcaiptb79mmD?=
 =?us-ascii?Q?jevD3mHP9oO8n2fYBeOlVzGeIwGnFo3A0lO3Nw77/cXwfKPwqWxOffFH6bdz?=
 =?us-ascii?Q?zh8hmPqNMybTysskICzxSK/ABa5VRTizy8KdiEL14qb6DjbMnFl26afqs1DP?=
 =?us-ascii?Q?HvaXRsv6XLK38jq+8L9WHI+7YsNF5acNBtq9uVlg5sAKJWIBcXPbJXGytgaM?=
 =?us-ascii?Q?5xg5RIihxmv7bTOlfvYya87m1F2ig5/OBXRqy1cAMR8I5oIi51LwV8qs+CmZ?=
 =?us-ascii?Q?NbUit35Gggcqj3m0BpXdUVE3HstK3oB76Z1UWe/lSb49VuPNFNxv92A8yh42?=
 =?us-ascii?Q?RCiLwWHN8droSpQPclrrxaAyx6+zh7K+o932NNpAsaugp0HitYkpkateU+XY?=
 =?us-ascii?Q?3dSLZ+IJklWiEV7dot7W+FCM9/upKNda/B+YJIOM6ASAVbT/SXAvOyv2jPnE?=
 =?us-ascii?Q?5VXSssL2oBePfKiAeUNH9RwZwSHG7+vHVgklNlimouiz0gh4jmb4nGUV4O1g?=
 =?us-ascii?Q?hUR7exPv8J7FHh0oISG1eCjpmm7f353ZUKVKlLPj17IjGYHYIsnnYSqLtg2Z?=
 =?us-ascii?Q?x/C7TxmlEeCLm8j8KOFbVmKAaIlhPlquYaNmrM1TQSUglD7CPMX1mOl+yiEG?=
 =?us-ascii?Q?vY4JIgwztKdmf7DW9CR0GvWMsLe1oiq5akH3zP6EU0dPIgR3UX/85e3G54bL?=
 =?us-ascii?Q?a4R+trKxz/uGUC9dEC5jenNk88Lh0aDLRzHd6+UtMvYO8zt35kGj+N5AQ8fo?=
 =?us-ascii?Q?9APwMjDl8NohmuIMvndeYATQgmyBCdLv6aoRRplzrP1+EEWNOC+jeab18OWA?=
 =?us-ascii?Q?uFF27tBpXD3Ab5s1f2A58tNLBecsdp49opi6vZFQ41FmWK7jaH3343wJpgHl?=
 =?us-ascii?Q?ttfAp6iYEOS7ZQKy7aC1Hy1NH8AZqCnw5csMZfhalhndN4PtwCNvY//v4YOa?=
 =?us-ascii?Q?Kjs4VI5Fg+VBjzbszRY8Msx8sCuhOLT/8PpjpThuqupO1VihxM8RoQ9p41uY?=
 =?us-ascii?Q?wztle6MWLLGHGI91R3Ucl1rsJSjJ4MpRs/gu7kTc65Lupc4pbPm1+ijfXOR+?=
 =?us-ascii?Q?6B9cvln6fdNvjUmezYl8j/yu6svNorW9F2IjhZpmYWxDLgA1U1h/iIW06OsE?=
 =?us-ascii?Q?qlCWPf4ROxgultpGR6jxtC9peelnl8l1Z/z792iAJDCXCSEE8i9Gw1iE4jAe?=
 =?us-ascii?Q?j16Bj/q0Flfly8svjLUKgnc6TTa7MwbpzFKSGCwTROCbhShbgq2+3gGrYAje?=
 =?us-ascii?Q?EA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	VS1dn4PQ8z3ChrQSwKiTGfAk/IaYnPhkJfEgZiVKmvm7pHwkqxSlwV8QvZqEvJWDvfnf1i+BeQwFHztTnRG3x28PgKoBMTlrvNqoD0bf+RmQ32U5IvlZ9hh1/0eOgYBI3625IJSHJrOhG8G6iR3TQmaDeTkC5IV10cnnrgLS94KjPRcozfCT4R6FgHi9QB5gntHruGkGUcpaMpot/ze6V7kpms2lOQ42Re8wBCVj3jofjwxg6KGq9PoV5C6ktlbiSTK+NRSxWMb2HNSLlYGZra9Lpvjf6Ujz4Yq7lABOSyrCcvrGqhQjqFbjQtGf0rj8iizHPcXP7cnZursdzw+6VUoMZ8tSAOaJKRfkUjVBI9TV/o6K1l+JkK2BaaINXTVL38JKAZWrBiVFoCA0Z2+mQ2hjOV6opPXbSpUkWDtZWqIuYcFROebSDRQKq8nM5ZQOiGim0dSB5GsbJ9zbc+8vaKL2wixgIcv8TUAfVNitxEmwy4fSLR/baxrIfI+JNnwawmISc7sf1WIs2zTDvWtNqrrVZc2FhZM8IVcO9UT1OPWhfqgDeK0Kb8DfjserAZ+XPVnmI6C7vQoqW8XimoU0KzlghGW9YzE2u8mzURscRzk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f257769e-1c1e-4c44-7ae5-08dc55d628ed
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2024 01:09:07.8821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dxVqZ98Cb5hpbigVms1ROIH3379MpfZmkhTYFVkiqm/Euy2nydAtOdyN1HJhKkGNeIIuNJh0DJZkj9YLIgsPrWeao7g2FGsn4q3zkcRDJZ4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7514
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-05_31,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404060007
X-Proofpoint-GUID: -5zjXq93gYw_T9z4nLFUcRA3ShIcanUd
X-Proofpoint-ORIG-GUID: -5zjXq93gYw_T9z4nLFUcRA3ShIcanUd


Andrew,

> Please review with care as I'm not all that confident in this subject.
> UFS has a lot of mb() variants used, most with comments saying "ensure
> this takes effect before continuing". mb()'s aren't really the way to
> guarantee that, a read back is the best method.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering