Received-SPF: pass (google.com: domain of linux-kernel+bounces-133758-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Manoj N. Kumar" <manoj@linux.ibm.com>,
        "Matthew R. Ochs"
 <mrochs@linux.ibm.com>,
        Uma Krishnan <ukrishn@linux.ibm.com>,
        "Martin K.
 Petersen" <martin.petersen@oracle.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Nathan Chancellor
 <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Bill
 Wendling <morbo@google.com>,
        Justin Stitt <justinstitt@google.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] [v2] cxlflash: fix function pointer cast warnings
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240404161524.3473857-1-arnd@kernel.org> (Arnd Bergmann's
	message of "Thu, 4 Apr 2024 18:14:58 +0200")
Organization: Oracle Corporation
Message-ID: <yq1il0vqnzv.fsf@ca-mkp.ca.oracle.com>
References: <20240404161524.3473857-1-arnd@kernel.org>
Date: Fri, 05 Apr 2024 21:27:45 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?4xwyU4EaEQBkPvuPYvYfJYWpZz7sk0Ga+DAUV5MfSxAduy1mjCw1EjtMsLw6?=
 =?us-ascii?Q?DpBGPcS/PQoSVEB0uYhQJd39fpRJ+cCDsroFgHQhigUby+d2kI7wdXK+hVg1?=
 =?us-ascii?Q?d7Pxh5dM7DxUvH7IIEjTe1pCWK7YC+liXex3C1GpmHHTA0efQ+ret9TNJ/Sy?=
 =?us-ascii?Q?ADHbUHPuRoVm7mYjuPM45vAyUpx0fSRu6vX7Fqs3+wkP0kQqDLI0J7puQDOh?=
 =?us-ascii?Q?wQI9lIVtdk5+MVMWwFWvbFarl/qtpMql9lftju73lzgG2ZhFfdefTrPcm7i8?=
 =?us-ascii?Q?SQ37LhooQzyvVV6mD86u+UJbZmfactAgNz8ilGEQtxgsrL98P3kqtjfyKRYF?=
 =?us-ascii?Q?mkNsGX8ggdjg7WbnBxcq8WKh2NGXcy0/3z0gHMBHOY3+lm6gRNm7W7YFwizu?=
 =?us-ascii?Q?F+SnKxLOZfQQ7si+4ixKU4W4SCb7w9qRjrEHYsSXc+ZmwoC4EeW7IISi6pw0?=
 =?us-ascii?Q?/1rbeyNocu5mKKXtnGkGv2hBMM2rFaRn2x8Rc5axNxD337OKbcoYCdhAeuzH?=
 =?us-ascii?Q?fFZ2bUXHNAPKNmN/ETnQYP10iQiSU2MDf/dTq/jYXOxhxH5FuUpRny1hOyLp?=
 =?us-ascii?Q?u/DIQjRkcJ1+JrEH1uEoaFCYftc1RSaV/ISzrivoCgeWZL5Grd0rIJavhoBJ?=
 =?us-ascii?Q?S8xrmMOaPJsoYNJZSnOqDfZvKAWrr16AVIVVxdj/aV4gwqtaxbe+jBX7dSLe?=
 =?us-ascii?Q?p9DrgA2G33MSOPdFOmTPaQNolQ2zBHr+WZiZLt6gMtf00DJiEUb0AP/ROj/c?=
 =?us-ascii?Q?eZ13UIGHc2QXc4cOLiE73NCM/kltBVOBW2CPgHYqiFXT4E/q2LF2bMT9G2vl?=
 =?us-ascii?Q?WcDFbgsdwDqb3/06r8yR67q8wc+cSoz/XZ+sPUudAhGlRtbPdbrEm2KkihTk?=
 =?us-ascii?Q?yG9OYGlHZ5x0NZpibkrkI9CQUWRixDlgRnUQbUcRLkJeni2IS8awqHj7uFbk?=
 =?us-ascii?Q?bMe3XgAhjt9QKNI46am+HahnzkOmsTTjBeouo0r8DuFriA+ZFW3DSvTyCOX9?=
 =?us-ascii?Q?1GIbqLqfXRbHH8nR3iadTf0TNb+WTGVWWyXsXfYHJd/SZBaCC4cAhJho6IZv?=
 =?us-ascii?Q?bNCjF4TFYBo1caXrUU17rt3Af8jtpcbdSOXwTRZLSnUWrk3yEdknKGls6YaW?=
 =?us-ascii?Q?KGzmfc8W38vbb4qV8g93m5CccRYFum5l7T4ytc6X/Q9OQ9Iq5+yAnKrZUthe?=
 =?us-ascii?Q?K5B8rUc5JjY1dkNQwpjfup+7mwIcEip9VkzsfA/F/NrdVTXIcSqRKtxfs8Sj?=
 =?us-ascii?Q?H/5fqWp375Y8sC1YGGi1O9XnAbL6g/va+Cl5og7OGOVp5vtscScvaKGq2rqm?=
 =?us-ascii?Q?fmvWcgCLAtFc8RUuBVkYGh1g1qYJGW2k0572dmMoRWrnYegZ8bh/YcyV8ppI?=
 =?us-ascii?Q?pbjwpLmXqFM9QKp/OaaslMs99f0YmCU5zRwEE7IaTQoGoNB+7BR8F4B9hdiH?=
 =?us-ascii?Q?OOfQljE5lCeS11plfYB66seozQvflkwgYJ18Xtg3x4eJ0tXvcLshnz3FBPE2?=
 =?us-ascii?Q?3GEnZ/l9pMTR/qm7XzZELbI6R0KFmCKTs5kkzjqndHDTR7ToBzPP1nPRqZai?=
 =?us-ascii?Q?Y0656Z1+Sdm/8WgimowTQZWuqWLxquBTj7wEY3qq9FGU4TsWHZTUK8/VSyL0?=
 =?us-ascii?Q?1Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	LS3xRURJwQT6+ESwm/niUBxzjHTsEVXoekkIUGRwi8/SXLzFq7Su9/PI/4fWOXxlaetTRZyM5OaXEpxloJ7snfxh6bjZdY7kT/CJgHdDxKrBHnQnTaO8rR2jPjggZQxC33JO126GTeHZCoJTYY85J6Myuy1DhJqt/ziQQf0dHSngPXjF4O8AombNiavAUszD+udIvkNwq80/lNdB3/8VQf4/5nb3FZBhfYMt9xbvw7GJ+tfydKYW5qa0+86HYOHJXr/5GxQqTHPP42dwoQ1cYiIci3ibEDaXHSsCb9qWbXQ6aLMsGQ12imKXVrK/lSeNPk/KEXJvk3Vrt/JAwARZ+MGzdr7RrNPmV+MBtyb59Cq01VCRO8KS9OiCDOMtKZt+6yXAWdghCdIgDR/OVQu51ww8JD1Ext28HhysjvNiTgiLYSdrpZsp/9Cv3SjOSlFuMlgmQLNAKjTrZRMX6S8C5G8uhPaaxQ1qsUDsSimJtd1jHt5LZ13Il9MWoDEhG33VdshdhWKTsyNf7SZH2KO+sljYIWSssxRltBs7gUvYC/8iFisRY1rbk0cWg91/oIbuiUQJTLNhbUw7c19TXsp8ht6LTQJVZbIXMt17+DhjnkU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 762c0d62-267f-4f36-554f-08dc55d8c41f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2024 01:27:47.3218
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MaCIImx4xAsWIFRQ2P17vS8S0teA13EQ66C6EJIkzjooLzekzGQybZ+7kr/DemClM3V77iCcQtL2z+zcoKGndCpJJoDH1VJ3MPXwhsekY0A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5557
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-05_31,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 bulkscore=0 spamscore=0 phishscore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404060009
X-Proofpoint-GUID: bMxyp37XVFPLbLAg0LIHmP43tlY5i9L8
X-Proofpoint-ORIG-GUID: bMxyp37XVFPLbLAg0LIHmP43tlY5i9L8


Arnd,

> Calling a function through an incompatible pointer type causes breaks
> kcfi, so clang warns about the assignments:
>
> drivers/scsi/cxlflash/main.c:3498:3: error: cast from 'int (*)(struct
> cxlflash_cfg *, struct ht_cxlflash_lun_provision *)' to 'hioctl' (aka
> 'int (*)(struct cxlflash_cfg *, void *)') converts to incompatible
> function type [-Werror,-Wcast-function-type-strict]
>  3498 |                 (hioctl)cxlflash_lun_provision },
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/cxlflash/main.c:3500:3: error: cast from 'int (*)(struct
> cxlflash_cfg *, struct ht_cxlflash_afu_debug *)' to 'hioctl' (aka 'int
> (*)(struct cxlflash_cfg *, void *)') converts to incompatible function
> type [-Werror,-Wcast-function-type-strict]
>  3500 |                 (hioctl)cxlflash_afu_debug },
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Address these by changing the functions to have the correct type
> and replace the function pointer cast with a cast of its argument.

Applied to 6.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering