Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp197223lqe; Fri, 5 Apr 2024 18:59:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVjWj+JeZbiDpLHAGo0cz9Bns8bamfO9De2BErAOyk5gTHLuRpHkn8zLslnNXJW6YM3BJFW4PLAP4RDrH629goJvOVtxv0vR31UjyoLzg== X-Google-Smtp-Source: AGHT+IE9aiavcfb8d98jHd/8NzVmWvtUdSjgR7yWmQLL3U3rf1tpIWKvfmnYc+t7xCLY8VPyj+8T X-Received: by 2002:a17:903:249:b0:1e0:b6d5:bed with SMTP id j9-20020a170903024900b001e0b6d50bedmr3537273plh.5.1712368792054; Fri, 05 Apr 2024 18:59:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712368792; cv=pass; d=google.com; s=arc-20160816; b=F/OeF2yOksdxYLUnn6KuKTFEY3KTRXsXfmjyCRmygf1kU9ogiFqVhHSg9w/Qnw2Go3 VOSMynJSA3aSc4a+VOOpn7oFr0e6TxrLsP7hA6v14O7ZUYb7k9sK5Zp9uCYq+f9es72J s/JGd5N7TQYyxf9UaPjrc5aAQZW6hTpPamo5Mjk2uhhyi/Z8PW7luyOr6jVMj/ejT8hV UGAtR3SThZ4IBned37E6umV1i65GTewy5KC/jvLud9aeJWed4SyzFSbPOelEX3+NNtfD nfgTQ52SO7oG4uCx4HHf2D+JkrYPRbZai0lJz330njoe57TtJxvplg9gbCib/GwFUp2D s6QQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=JrIVJnIlZ2irb8MalvkujLN8fFv5qjkoRcrej4VnBOg=; fh=dlem5Yw3ZurdGVIBv1+eCZujsB7anRuM5j7VUmGIRH8=; b=ivycxpAxh7DPDOBHP53CuK7Asf+SFtDmXMK8h8C8DGXutnds+mJl36okFE2v7jp5L/ qCPCxNz3b59gKXro6PNd1di8hD9/3WMM1/pDh7MNTUhtggzqauFtb9EnUgUJXJR9s9v9 eGrHOLTU6nuhef5BhxID932CA3IRNAwoX9yHxLtHFatven/5uRYZs2Y/hBdfvOO8CKyf K6gfil+4/BrhwAr8YOfv9FwTgGZLB7QDYMtk5qmhrTpK71P/mF7vL6FKDxgqq32LTC07 4pXM/HDmUXbPqlH6gpP4qKU3xWN5oe1CMBsnO5tyvBGV68gqH1olPtQvAcGqUirn2bLx zzJw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=T6PPfuHf; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-133763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=oracle.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v11-20020a170903238b00b001e211a290f0si2323681plh.347.2024.04.05.18.59.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 18:59:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=T6PPfuHf; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-133763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 01E9AB22993 for ; Sat, 6 Apr 2024 01:59:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 41CBD17556; Sat, 6 Apr 2024 01:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="T6PPfuHf" Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82532125DC; Sat, 6 Apr 2024 01:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712368773; cv=none; b=UmGgOCSbsmjSwYasqCRdjMOwXhgBdNgYZOZJnYBaLjpyyIZoand2s0PGWSV85UwA4C+2MiuN9GLsGxqzU5/9Giw8IwSeLemHeu7nC4xAirHdje6SQ8tGD7BEeNEqAD254zDTU3SL97ILFruuLI0hKeMJIMg3zSLvte1+t1YpqQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712368773; c=relaxed/simple; bh=Z7VCcSKqAqefSjmsmcNaIRDZm19lO+XBUKel61A0WCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QIgFQxe6UyQe8tAvtOdm62BIwTtAONmK0TJcz5ySKj0lD1aw+ds4NJWzBnmypvturarQ1CpuYuviEO/ozHI2RQHgrCh8Sr993+86Oh63zBUkvh56XvIhLya8wVlKvgFu+4n+JZVbzNKY+NuZxK/p5FFrOPXD+vkrMwBjSnyJbx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=T6PPfuHf; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4361iHBc024192; Sat, 6 Apr 2024 01:58:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=JrIVJnIlZ2irb8MalvkujLN8fFv5qjkoRcrej4VnBOg=; b=T6PPfuHfv4wO2CsQJIDJyrUJ9U2FuDP/9WpbDqwyrZUZybylCYcJk6LXZS5oud+/xsec oCrw1jMQ9WC3TwOovHJ4fx8FWR4TVcrLWaP5WhBpWDU66L4B0YRatiSYsEEf9d0AZ1yz n7kQQSQEgSbs+LHSrC44XWYJGd1w4wG9314OoT4n6WS/C4HNSyIm6/dtc5EcYgIEuHYt Hp++3KDhOy0oSxXy4+/KwCEx1Ymw59+ABw6UFPas6zFlULcxQN2NJW885CMncAQQKZtO 6BZG8AUajMswFVssE9uCvrbIazeIkUp/qNI71AeJxOO3fHwF8QX0z1Z7iTZ5D/6SaYu0 Ww== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xaw02006w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Apr 2024 01:58:56 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4361XVQd032535; Sat, 6 Apr 2024 01:58:55 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xavu3rer6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Apr 2024 01:58:55 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4361wqvb000912; Sat, 6 Apr 2024 01:58:54 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3xavu3repx-3; Sat, 06 Apr 2024 01:58:54 +0000 From: "Martin K. Petersen" To: Quinn Tran , Dan Carpenter Cc: "Martin K . Petersen" , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , Himanshu Madhani , Larry Wisneski , Duane Grigsby , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats() Date: Fri, 5 Apr 2024 21:58:33 -0400 Message-ID: <171236847476.2627662.10581186530455800083.b4-ty@oracle.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain> References: <5c125b2f-92dd-412b-9b6f-fc3a3207bd60@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-06_01,2024-04-05_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 mlxlogscore=635 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404060013 X-Proofpoint-ORIG-GUID: 6Q3V5RB-qL-JeDFNg1it--MnBuCI3wtO X-Proofpoint-GUID: 6Q3V5RB-qL-JeDFNg1it--MnBuCI3wtO On Tue, 02 Apr 2024 12:56:54 +0300, Dan Carpenter wrote: > The app_reply->elem[] array is allocated earlier in this function and it > has app_req.num_ports elements. Thus this > comparison needs to be >= > to prevent memory corruption. > > Applied to 6.9/scsi-fixes, thanks! [1/1] scsi: qla2xxx: Fix off by one in qla_edif_app_getstats() https://git.kernel.org/mkp/scsi/c/4406e4176f47 -- Martin K. Petersen Oracle Linux Engineering