Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp199541lqe; Fri, 5 Apr 2024 19:07:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXFX8rsWWlMDjeghLam9UBRlIEbbwcwANGM7CWCcAV21WgLrtiQ07jMGn82gQuc3nBbBfURp1yD4FSY/cOuhIZz4QuXqm0kXPgM0hWlMw== X-Google-Smtp-Source: AGHT+IEsh5/25EGb3dREdKl6HxtzcmlP5luD66njLhcio6xUpzdbrPugBVnftMv6Cc00cbJaRohm X-Received: by 2002:a17:90b:1bcc:b0:2a0:2fb3:c1ff with SMTP id oa12-20020a17090b1bcc00b002a02fb3c1ffmr2989998pjb.15.1712369229994; Fri, 05 Apr 2024 19:07:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712369229; cv=pass; d=google.com; s=arc-20160816; b=oz9mpxx7FPQrTIH0KXkwkRbMml4/vm+D4qYgliKUxGPDC382dGE76INfDbXRLEjqWz t0QdnL5/04e/KFuZ130yN2kHw+jXEBeK1La8HcGKkZOuxLrQD+8faG3WdDkvkNdZUtlW Y54DIYitdTmEkQvmraxDsI3w9Tl7suMaBlnG0mpFk5765PbyX2IhXBT3BruEo56HvW0o 9DcxnCZRl5aNteGExk845o5ZjfZEt41+wxVqhscw/+295aZatxU3r3vmZMiY5xr2qjQB AmZ46j3u4AtACWOoMNXCmABBmAAjuQjRz5ID7Q43z2F76kB869Tpm+nZmo3IFI4U0faE fuFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=ef5+3CH6LeOgjKhuTScYGIub12ur0Qg70xfmZlVajOg=; fh=N2YZpM3g3XYPDqG1QpGwRi02Wp4B3zoQWl2FnF4GwKU=; b=kpHFza14Uwt+0QB4u4TrPSGwjrbgSWEPrEMUD5j4ttYeezZ2X/7lo4lLntRLjWdi3S 2CVQ2JZBRQw3bS+GQEIFwHW9+bSNj95wSfHSjhcd8ADrUz4eMewfRScpvPvFv9cv7iTk X+G5yFnFbhU3nV918J2/IaR5zbJtvo3JYDAQ8IM/gYUYiOM+DOzH6QZ7MUZ1EZfXbYW7 rva0xb0zzZ6fefxFuHfbWw5sYkeswb3bEQGN6XwBjvCl6J64t3gBCfji/RZQ5ApLjVzl //HFRVGAdwa9/JHWi/AAcejXlTXbLQR98Z8CHT9Kuz6yKL8VA0jLINSOG/TOgBdFpRX8 4jZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=v6gGufni; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-133764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133764-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id c11-20020a63d50b000000b005e83f34efa0si2345251pgg.185.2024.04.05.19.07.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 19:07:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=v6gGufni; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-133764-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133764-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B0F53B2295F for ; Sat, 6 Apr 2024 02:07:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 230D9125C1; Sat, 6 Apr 2024 02:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="v6gGufni" Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4FCCC8E1 for ; Sat, 6 Apr 2024 02:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712369214; cv=none; b=fzrVtKI3OFHPE9Bk7c75OZXG2lTNDG/sT4GMVtw2SsbAgUJmDqMQ5KY5EhFwtauoR2yg1t4zyGVScOTV7TxU/JVO8u/huqyUOL092BTAIs6cs4rc80O9zGr1fTdwO2s1ctsOrRV74KCUm/LmXBy1PnGddX+4LtENpv4HeT+n0B8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712369214; c=relaxed/simple; bh=e5EXRkMuQtcY4FFU97cFwK+6ZxBGztReN24wshOxQy0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rNZ0Ui32vJA1D2rj6xBjq1nW+kHuAmjg9H8znEdFWVVYYlMJqqqpc9ZBAZ/qCnt9UHoykISU5nFiZ/nSZlHt/nItYiQFxUjOt5rT8lctOYzRR2IrOte0mqX4hOz6BwmV6xblAmrGYiRrRmWwnShm2cd/uvJ8FtncXJ/R9v3zdF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=v6gGufni; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7d341631262so47484139f.0 for ; Fri, 05 Apr 2024 19:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1712369211; x=1712974011; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ef5+3CH6LeOgjKhuTScYGIub12ur0Qg70xfmZlVajOg=; b=v6gGufnicAEAhOuCdXEobKx5BsOkcvq6mtHZHi0fY4ix8tX1md7i6+k7eEgNVaqhOi 8yqBHAE1IF+x0lHeunfEmQBFBUk6F7VNhMzX4XcOaAfhL04M2QWJ3G20lkDFI72LhV3O IvqIEtMzzme/htx6fJziUh4nQoERCTiGppA8XfLUBusX1um54jrihaXwsSJUlEZVYe3a KafIZh6Zx3n6aNuYQ2ATVZOpGYe58q+8NNg+YDMCLETv9Jwc5ktqVBjyrA1kOSDKp2o0 FZT70aN29TT4tXmpWbWnF9TKoowJAm/CQBtyGYCkXOx9fcQaFW3iKxXxh0s4kNvk/339 d9XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712369211; x=1712974011; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ef5+3CH6LeOgjKhuTScYGIub12ur0Qg70xfmZlVajOg=; b=e28XTfDSrrub4iwwMK7zfDjB2Xc/YSZUdXKsNZz0h87R2YWwrtZCRk2Y3D3YmDgRpj E2D8rQHq02qvrY1hzaf7H7nChlqZn+WUgpqqiSmJ8CLOL9STXob83Km2w0BO2J2oZRCK R4988btnmo6lw3CV8SMojjmk2pJLvxJPR3BRqzZhhlYNg+vXZCihEBWssCLJeJNo5Cpa +yQC8TI8FUV5B1LLo5gIZQM60E4kkFVh8eihSE2DzyUIJ/aASlwiIoiN4sxYxqw698OT Egr9RJaeJCD6qF7w7c3SeFzHcJGKE5fWmy5SxJhFO684cbl4LvTMbmYKYGgSYY+vW+et hfsw== X-Forwarded-Encrypted: i=1; AJvYcCUrkamSJo4Ig58XEFqODTZX0fyJmhyr3o773mCOgQm03uuOT7seVHc+5LAe/LoyZgan6t2k6Snx4VKTsx0X4uLq+g0Nd5kRq5yt/mM+ X-Gm-Message-State: AOJu0YzHe0QTqSjRl0cUVxUxOTvOuZKjm70YwOzHJDqhM2DTeCTlKf3k FkavqSZ51CWUZNLpvFOdT9gULRbgZ1coDWDsUg1o9Sv/Wf/rulwbuSS9kGt0n3c= X-Received: by 2002:a92:d986:0:b0:369:f53b:6c2 with SMTP id r6-20020a92d986000000b00369f53b06c2mr2663931iln.1.1712369210867; Fri, 05 Apr 2024 19:06:50 -0700 (PDT) Received: from [172.19.0.169] ([99.196.135.167]) by smtp.gmail.com with ESMTPSA id s5-20020a92cb05000000b0036a0e23db86sm612548ilo.33.2024.04.05.19.06.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 19:06:50 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 20:06:38 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure Content-Language: en-US To: Alexey Izbyshev , Pavel Begunkov , Olivier Langlois Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240405125551.237142-1-izbyshev@ispras.ru> From: Jens Axboe In-Reply-To: <20240405125551.237142-1-izbyshev@ispras.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/5/24 6:55 AM, Alexey Izbyshev wrote: > This bug was introduced in commit 950e79dd7313 ("io_uring: minor > io_cqring_wait() optimization"), which was made in preparation for > adc8682ec690 ("io_uring: Add support for napi_busy_poll"). The latter > got reverted in cb3182167325 ("Revert "io_uring: Add support for > napi_busy_poll""), so simply undo the former as well. Thanks - ironically I had to hand apply this one, as some of the commits you mention above are not in the base you used for the patch... -- Jens Axboe