Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp217312lqe; Fri, 5 Apr 2024 20:20:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOiZGEYLHowE2PAU297MB2uvZrpyIeubhyBcnJnLSbqvdtzI2gWzbhUiCKfAyWZXkWiTYtImdM5XEbDvjeo2O/l+jPyiEjPKzUWI87ww== X-Google-Smtp-Source: AGHT+IG2OT9Pb0hwY0GUH+SSmqGZwTeRI2faW8Kug+P5J/W3itw5sBoB7BlktR51rbqW/vdyhuyP X-Received: by 2002:a50:8a81:0:b0:56d:fca8:d209 with SMTP id j1-20020a508a81000000b0056dfca8d209mr2131321edj.10.1712373602350; Fri, 05 Apr 2024 20:20:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712373602; cv=pass; d=google.com; s=arc-20160816; b=GXM5UBcPjQoigK0eWk58xjkWf1BATF/fTf10lhbyiRAT+Vf552JV2aYfN5rIukJ8zx YOfNso80GIk6Bd1Lvw2RYf5+ZFUGNClrayelTjYipcxsQokjESKQbEf2CpM0HQHO6ZrV xxxt2w1ZJoECt7rv25OF/0VtjNAsKE9OfrqaNTtnRfXNyJdOCb+cGE9dhaz2hkYmPbLs 7K2m2RTeBlZ7aS7wh971II/vMBo/0mBoAwFUMFgnEYVHQa/z8tixZpBvdDC2r/2C/Wx8 2g9bMySf6vV5+OZjgVeDN67WklCUbSv9HIHviqzI3tBQcQZotHtp+/G9b/bFww82oP1U IP5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:from:date :feedback-id:dkim-signature; bh=9kul5wYSciMTZEU/ffUWZ8gwme9HjWu3Wnb8YIqDLsk=; fh=+ZPh4J3rWFQe91irTbFSmXppvEry6u5jIty/bxtsGrw=; b=RLN/Bmt2GHT/PywW1Ca7Dh1qMqbP3q4Or299YiHzqJ/0HFF7bPASh4csPeIoBAB2Fj 7luhStq8ytPa9/Wtc7rc6NMNnm2BV1ey4/0Zw8Z3a3vtWcFyvZ75in3DlXfwRTf6OEEK jHwaZkt6eID+Tu23n5UBbuFYOW8w7wDw7v9G/QYxXvIK3iLbdtjgQGVwNgOb7/mUjXBX Y3eHimXp9IF3VXyF3NIET3njcNkclXlHDnp9vfQ2WYobYvs/SnHfMBjpefjBNjloObsh hnG0+xHzcACJ+5v1IOMW5ekeqvvFvs6pjkjTuYb/O1bYUxgp/vGEYTOkknDjjtUzKfK/ 7d2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ooTiwkUK; arc=pass (i=1 dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-133783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133783-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f13-20020a056402354d00b0056e0c72ed6csi1336070edd.532.2024.04.05.20.20.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 20:20:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ooTiwkUK; arc=pass (i=1 dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-133783-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133783-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 15FB71F22122 for ; Sat, 6 Apr 2024 03:20:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 08350179AE; Sat, 6 Apr 2024 03:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="ooTiwkUK" Received: from fout7-smtp.messagingengine.com (fout7-smtp.messagingengine.com [103.168.172.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC775748A; Sat, 6 Apr 2024 03:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712373592; cv=none; b=og4LzN3w0u+Ydns6AjvBWQaIsI2uC7yHoYWZKAvJMP91rCUqjWombp02UQK4vLyoLHKWC5Q5JyYJiybdKrn0kZjGqtT6dKb7pUfJSYK8rZ6NLz4/9qS1UtbJFEJTALy11DcDMWbzFF4Q658cePrddWyEVlQ89zQT7C7ZE5/X1EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712373592; c=relaxed/simple; bh=RuI4VwdgharvMxl9aFCQfXwEYjnfZ5btGReh837FzQY=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=hFRTYRRB1DPTHcaStiKG1sHas9A7hU6joGJH/vzjy5A7toVoi7IaeH8PkMBfU1+FPrz3YX88/1Us67Pz7dyEYLTFR8+jsFMZm96p5k7yuQ+8pX6ElE6od05W83kXw2uYvqAsMIonK7AMBHLKtkU3RQ7ptT+mZ9BpSS8+z2zwbiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=none smtp.mailfrom=linux-m68k.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ooTiwkUK; arc=none smtp.client-ip=103.168.172.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id AB0F913800C6; Fri, 5 Apr 2024 23:19:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 05 Apr 2024 23:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712373588; x=1712459988; bh=9kul5wYSciMTZEU/ffUWZ8gwme9H jWu3Wnb8YIqDLsk=; b=ooTiwkUKPhqW9zfzDZVT3t/TwKbGTeukyQ4L0eHI7FMv fu2q2wSYhfbk2jjYyI79BJ9vJ5UB4/FWTSOjn12RWZ/kxPypStmk6egXL5gHeDok Iocho1g/7BznBTiKa5E4QQVq+pXilIyNR5+Ijbxp4QN0RAqt0E8sTNM23+ZSF7Ra ojM7WTN9HlJPvg01UFgme3wy3+WzWBYQXSOCuVBejHua7G9sefeUdklA9Dld3i9+ 7x4WzRhlxgXoysfUO+r2ms3FKpTumVIOY+eYv1ZvNnAxCuXE2ofJMCZNc6fwajWj CePqWoYYYT/OXE3GQI8GbkBa80qBAmFs0Hv6+M1Qfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeguddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevufgjkfhfgggtsehttdertddttddvnecuhfhrohhmpefhihhnnhcu vfhhrghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrg htthgvrhhnpeelueehleehkefgueevtdevteejkefhffekfeffffdtgfejveekgeefvdeu heeuleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hfthhhrghinheslhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Apr 2024 23:19:44 -0400 (EDT) Date: Sat, 6 Apr 2024 14:21:33 +1100 (AEDT) From: Finn Thain To: Michael Ellerman cc: Greg Kroah-Hartman , Jiri Slaby , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, Benjamin Herrenschmidt , Andy Shevchenko Subject: Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood In-Reply-To: <87v84w7be3.fsf@mail.lhotse> Message-ID: <2cb53463-897b-8f3f-7238-9fe87622b54d@linux-m68k.org> References: <0df45bedded1249f6c6ec2c2fb0d9879da1841b7.1712273040.git.fthain@linux-m68k.org> <87v84w7be3.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 5 Apr 2024, Michael Ellerman wrote: > I assume you have tested this on an actual pmac, as well as qemu? > I tested the patched driver and its console functionality using Zilog SCC hardware in a Mac IIci, as well as QEMU's q800 virtual machine. That should suffice from a code coverage point-of-view, since pmz_receive_chars() is portable and independent of CONFIG_PPC_PMAC. Moreover, I don't know how to get my PowerMac G3 to execute the kludge that's to be removed here. I can't prove it's impossible, though.