Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp352340lqe; Sat, 6 Apr 2024 04:12:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUKelrhAuWZ/EvT0kk8+Nt9T2oXBBUqTApFBpVq4erLvTFrKyIy3du6mVflY66+Ru0F4/Itdl27D0VzRF/Hs+kZiThtbp0EUE+OOkIeiQ== X-Google-Smtp-Source: AGHT+IFmo6F5EjEdlmP66wmUDZbWVz5zKBFLN352k/TViXa0aLBz0lVPUW7DU4hWFT9niQ9CXdce X-Received: by 2002:a17:90a:e2c5:b0:2a2:3252:cb83 with SMTP id fr5-20020a17090ae2c500b002a23252cb83mr3723339pjb.38.1712401953897; Sat, 06 Apr 2024 04:12:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712401953; cv=pass; d=google.com; s=arc-20160816; b=PF/cCh2EniNqdN7AtWMo7cvvmW1j8x1V8NpA4hyc8wR7//8l+eRWrsvi46P3DTDw6l ASjBw95x5ZDxGcFGXyndkoU9276OpdSWbmL3gjHU6QTYSG1Okm/9ZPy3gMw5KP3fiv7K j5rJcg+t2imFAJgcWS/kMBCjWNf2XMg/dZDZ54Q8TKSNutSj05JEROxwxDoIxF0NVdum PZvTTwrgsfFoWwV2rg42EvfCjAW25prvOrvQNO71DFEbUqK5RMX3ocmYa2qDs30cg78+ Zb9E4180vd3Jg9ZP2KpSF11UR09bbddAUgcIKUmxKo20h8UD5uGW4JY0RyiE6G1I5gpr 1hOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:message-id:user-agent:references :in-reply-to:subject:cc:to:from:date:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature:dkim-filter; bh=6wci41eDzOFmYi6xp+siMj+Kcr1MZCDRbXEFul7wU0M=; fh=6Umzf8lL1XfTOCvdrvSsbakAMO0CWTd//FSSHcg1ZYQ=; b=adpI7XfYh1eFkmgYqfsJsUjtzrfx62mYrJaqL9Ekq/7zvdHw+pw5NeXC5JYbHGUFTW WHyEFJKsxWPqGhMMqHyj7bWaP+B5ba2KtSzqG1vKOa6FMz4vohKh5DBHAflRpH0zVjJ2 QBvWTR1ywEwVJmgyuZLI++bKSoOjnamgasA+152tPJiLAvg64mj5Exm8U84rbCcLSZkN bajBSc8/LnkpW/cxCeo7FWJO9qiO/yBmk5Squ8L16fgLG2JfwAeoTp+gCZdMxS8K858K N/2avSioChORSIIl+yTybY/ZWnNnA0Tm/eTAiklaBPPmIqf8WTwtmR/A3A/gzHBENjwN rYog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Rrsz1hBG; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-133900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id rj9-20020a17090b3e8900b002a288d30f1bsi5482365pjb.36.2024.04.06.04.12.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 04:12:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-133900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=Rrsz1hBG; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-133900-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-133900-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AD687B21B21 for ; Sat, 6 Apr 2024 11:12:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EAB5A2C1A6; Sat, 6 Apr 2024 11:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Rrsz1hBG" Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B27762C182; Sat, 6 Apr 2024 11:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712401942; cv=none; b=mc9NpyT9QhklRg4h8yR4d1Ylc5P+AZCRZzkU7Gd9vQSwmrTYR7a88mHlEN+nyl9TiniF3X0hQQQLEhN91OO3cY9VTovWxMfj1SVqbSDqfrgHrF3v9rqzD3T6aCjlKoH+BBDqUb2zU6l41DrbwHpjIvm6NH8B9f7scYdJM0DkYDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712401942; c=relaxed/simple; bh=/Na42PaebErLTeUeIhSCBAG010sjkEo4nu6zNSWufjo=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=gM2st2gEK8thPn0c9hl1RfK8A+c7fq3ODiOUTlBP7M0L6nb9FyD1oyzy4yAenJ02ymotllXK1Gi9UNY3MB97amYNtsVc6Uosr2FO1gQNb/FA44P9jS0jplTBHGK75MlHg/z0TuuKUaqUbHl0IFEs4TOCevNzLOLhn3QzC6u9CJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=Rrsz1hBG; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Received: from mail.ispras.ru (unknown [83.149.199.84]) by mail.ispras.ru (Postfix) with ESMTPSA id D3F2740762DC; Sat, 6 Apr 2024 11:12:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru D3F2740762DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1712401935; bh=6wci41eDzOFmYi6xp+siMj+Kcr1MZCDRbXEFul7wU0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rrsz1hBGN6GVTvOyUZEqiDZDuxT3KigQLq8ra24Nv9F7SGP9jGQ8Sj/75ohJ2bg0T AUS60CW5/zFjLtKEbGmCvkG82SGWh7MLvYOR6fokRnu6GcgxCm4lRYJYteG7/7Hk2X xcJpCGtDXp07N9xgUexQmCqcEpWSOCaBIbxJKdoM= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 06 Apr 2024 14:12:15 +0300 From: Alexey Izbyshev To: Jens Axboe Cc: Pavel Begunkov , Olivier Langlois , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure In-Reply-To: References: <20240405125551.237142-1-izbyshev@ispras.ru> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: izbyshev@ispras.ru Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-04-06 05:06, Jens Axboe wrote: > On 4/5/24 6:55 AM, Alexey Izbyshev wrote: >> This bug was introduced in commit 950e79dd7313 ("io_uring: minor >> io_cqring_wait() optimization"), which was made in preparation for >> adc8682ec690 ("io_uring: Add support for napi_busy_poll"). The latter >> got reverted in cb3182167325 ("Revert "io_uring: Add support for >> napi_busy_poll""), so simply undo the former as well. > > Thanks - ironically I had to hand apply this one, as some of the > commits you mention above are not in the base you used for the > patch... I used v6.8 as the base, and all three commits mentioned above are there. However, the patch indeed doesn't apply to the current tip because of post-v6.8 changes, sorry for that! Thanks, Alexey