Received-SPF: pass (google.com: domain of linux-kernel+bounces-133986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sat, 6 Apr 2024 16:46:33 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
 linux-kernel@vger.kernel.org, nuno.sa@analog.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/1] iio:imu: adis16475: Fix sync mode setting
Message-ID: <20240406164633.76e3601b@jic23-huawei>
In-Reply-To: <00ed6785db2b43ec3727f42c71dc2c8dd1b627f1.camel@gmail.com>
References: <20240405045309.816328-1-ramona.bolboaca13@gmail.com>
	<20240405045309.816328-2-ramona.bolboaca13@gmail.com>
	<00ed6785db2b43ec3727f42c71dc2c8dd1b627f1.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 05 Apr 2024 09:02:33 +0200
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Fri, 2024-04-05 at 07:53 +0300, Ramona Gradinariu wrote:
> > Fix sync mode setting by applying the necessary shift bits.
> >=20
> > Fixes: fff7352bf7a3 ("iio: imu: Add support for adis16475")
> > Signed-off-by: Ramona Gradinariu <ramona.bolboaca13@gmail.com>
> > --- =20
>=20
> Not sure there was a reason to drop my tag... Anyways:
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Missing -S on b4 maybe?  A special parameter I save just for you Nuno ;)

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

>=20
> > changes in v2:
> > =C2=A0- added u16 value to call __adis_update_bits to fix build error
> > =C2=A0drivers/iio/imu/adis16475.c | 4 +++-
> > =C2=A01 file changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
> > index 01f55cc902fa..060a21c70460 100644
> > --- a/drivers/iio/imu/adis16475.c
> > +++ b/drivers/iio/imu/adis16475.c
> > @@ -1289,6 +1289,7 @@ static int adis16475_config_sync_mode(struct adis=
16475
> > *st)
> > =C2=A0	struct device *dev =3D &st->adis.spi->dev;
> > =C2=A0	const struct adis16475_sync *sync;
> > =C2=A0	u32 sync_mode;
> > +	u16 val;
> >=20
> > =C2=A0	/* default to internal clk */
> > =C2=A0	st->clk_freq =3D st->info->int_clk * 1000;
> > @@ -1350,8 +1351,9 @@ static int adis16475_config_sync_mode(struct adis=
16475
> > *st)
> > =C2=A0	 * I'm keeping this for simplicity and avoiding extra variables
> > =C2=A0	 * in chip_info.
> > =C2=A0	 */
> > +	val =3D ADIS16475_SYNC_MODE(sync->sync_mode);
> > =C2=A0	ret =3D __adis_update_bits(&st->adis, ADIS16475_REG_MSG_CTRL,
> > -				 ADIS16475_SYNC_MODE_MASK, sync->sync_mode);
> > +				 ADIS16475_SYNC_MODE_MASK, val);
> > =C2=A0	if (ret)
> > =C2=A0		return ret;
> >=20
> > --
> > 2.34.1
> >  =20
>=20