Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp535914lqe; Sat, 6 Apr 2024 11:35:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWagTvq44aJ7kOPdcc9lLscJXd1ichjjp01B9/ZkXfVk/j9rDQ5cjpgjtirhHUpOfBAF2A43lffY2JcgRVXWd7AnwIkZiG0csdnfLE4Hw== X-Google-Smtp-Source: AGHT+IGXXGlJxmBCa3H93+eCfbeEwxkAlm+BR818iiuEWf+8QniX7bMseiaLgA/p3eIT2jR6pX5O X-Received: by 2002:a17:90a:ac08:b0:2a2:ffa4:8429 with SMTP id o8-20020a17090aac0800b002a2ffa48429mr3774711pjq.1.1712428525827; Sat, 06 Apr 2024 11:35:25 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id z21-20020a656655000000b005dc12b1dd59si1232996pgv.128.2024.04.06.11.35.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 11:35:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134057-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=EwwkuCxw; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-134057-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134057-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1F160B224ED for ; Sat, 6 Apr 2024 18:35:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6859E481DE; Sat, 6 Apr 2024 18:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EwwkuCxw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689BF1E86E; Sat, 6 Apr 2024 18:35:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712428515; cv=none; b=pCkkMSmEXWtJh5Xrk2ZQBI/4ALTGFBL97/BQJxCBTOQvof19Bi6XQV2vt436FMwB2MHEqaFAq368K7Ty3c0EcAvECt7wZvlWBc+vlDrAvscgWQJruKZSq+yUy3sYuYC56iXTh3nHtSw9MusD3SsGngCrpNuqPrxz17y1ZdAQ9So= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712428515; c=relaxed/simple; bh=JJadtLGGQU8Da7vaVgG5DqXtyVsPFDQjEHLVDvlD7dI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hu6PIVTEa/iZ5YaEWDTbBsFWfItJn4oAzVVYFSIZwa6nXn73aX0HXd6RdY1aD74cBAp040RY+ekt1RDxttwOyUZKIi+Zk2f6I2SZWBJWdTp8N2u6ihp6nHf6YUtX4XHIalC2VFEzepI8kWQyCeo5O1zOUz6DhI9+/Fw7Ntya+YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EwwkuCxw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0EE9C433C7; Sat, 6 Apr 2024 18:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712428514; bh=JJadtLGGQU8Da7vaVgG5DqXtyVsPFDQjEHLVDvlD7dI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EwwkuCxw0LPpMhXloIykbX0iRg9kDG2/A+sszXhH/h/arXdpLmXgM5lzqhWBb1FEi wRnXxP+Ic1pGkQtK3KwMjEURdpMN8q8gGmDo5UjpTmeYWKDGERg/1NusTO7GaoJjiW +IY2ROGO3v8hK+w8vrVVURIo+WEyzBYKXJRRIHJL2ixxEd7yRGiuWRmWuxVgXI5PS8 ZPT9DjnbCD4uFuHe2WWgDc5sMqOIHDPMI+zWcoATln5hdDHtAjw/E9yjJqOrUHdC4W 3iJlF/YbZ1/jH+nR6Dyl/1732DqpnGN9Ao/AjpZQsww8PIxQld1KAT47ZarOZT9VS0 x/K/8NzKuEFZQ== Date: Sat, 6 Apr 2024 20:35:07 +0200 From: Andi Shyti To: Nuno Sa Cc: Petr Mladek , Jonathan Cameron , Lars-Peter Clausen , Olivier Moysan , Jyoti Bhayana , Andy Shevchenko , Chris Down , John Ogness , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/4] dev_printk: add new dev_errp_probe() helper Message-ID: <42sw4ugekugyqzjylsci6tvw5zfxlwz6ypnetnau6dyqnrqfiq@5jde2w4etpfh> References: <20240404-dev-add_dev_errp_probe-v1-0-d18e3eb7ec3f@analog.com> <20240404-dev-add_dev_errp_probe-v1-1-d18e3eb7ec3f@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404-dev-add_dev_errp_probe-v1-1-d18e3eb7ec3f@analog.com> Hi Nuno, .. > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */ > +#define dev_errp_probe(dev, ___err, fmt, ...) ({ \ > + ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__)); \ > +}) I have a whole series adding a set of error oriente printk's. But for the time being this looks OK. I just don't like the name, the 'p' is an important detail, but a bit hidden... how about dev_err_ptr_probe(...)? Andi