Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp539507lqe; Sat, 6 Apr 2024 11:48:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFsbGox/O62uMPynd6MLv6cpKFCdrTt1yJIbbIlk+GQgzV+cagTm0MF9WgqFmt/hrkgSC2KuJvU2rjfmIj+kwBXJWRAdiurbiMPA+e2A== X-Google-Smtp-Source: AGHT+IHAC8W/N3xb/DSh5CwQn+3Y+AAd4dmqzUmEHH4ppa4L2dJdvzCXsMUoXX5buOax3n95DjNL X-Received: by 2002:a05:6512:3123:b0:516:b4e1:9b12 with SMTP id p3-20020a056512312300b00516b4e19b12mr3507988lfd.34.1712429307674; Sat, 06 Apr 2024 11:48:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712429307; cv=pass; d=google.com; s=arc-20160816; b=tSlJ5ApZTM80YuozaG/J2u7lJSNKqaFTmQ2CKu1QIbxG1+M8uSqP2Hhy9Y9sJvSRSc 8M/fZtavs6BOxcCmE5vCpyzYvVX5EVlwYGU8fTR5DLNmI9TTx4+yhWNoui2H3aLDByGK X+sIGEc+PEeJLYSF6sD435gawHGdsdH0PnUJ3vZ7wcqpeRtwHb7nHYKgCqoXLpYw5txK 1/+QXP37Hb0AoH0P9LVb/L56F0C5OmG1jeNNmO57zbGiTfjBvB0QDE1X6wvtHKpeX7OM Koz38BEExSDJYGNMf0xzvHtoWp+3CZzJlsCCJ0ypBY1JJ7sRs+9euMJ/FJLki/QM20cn T77w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:dkim-signature:date; bh=JkJ7awgyjocGhExtmI0IDac+uVE+RlqQYYJBf5DuZq4=; fh=uuFaPttWFrU2/ng/EYzNn1dRK5JKvOhIJHZbWgbiobc=; b=Yol4fQdScjWr7s3NrdOTBptYvknD4ZjBapxFkiEIJ4UMfOn/6Fn9eZ/CXOp6/PRheY 10gEIVLV47eqykvjUH2YrH83O8R739pNk7Bv1tN/x1jf48IrsJgDCFTq3r7yFubHAI1B ummCqZFca4+6YhgRPtToCY4UKlccROaJITLRahCdHe5F8EA9MN0lA09oJofNrWC+O8Bt +sm//4RWsT66DCf2BjDjjbhwb8tLKNBWlRpoFADwrwo95PydfB0hCkn50NKezdHpYm0M JbLfGqunLRONCaAs7QrZQIzAhE04ASBvfGSHA2R244Pk5l4ES8MYDP8vr6vmOpNokiKN nNsQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=pCMnijP8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-134061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134061-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id s21-20020a056402521500b0056c2c992e79si2136085edd.9.2024.04.06.11.48.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 11:48:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=pCMnijP8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-134061-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134061-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6479F1F220BA for ; Sat, 6 Apr 2024 18:48:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7AECE4C610; Sat, 6 Apr 2024 18:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="pCMnijP8" Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC1D4596B for ; Sat, 6 Apr 2024 18:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712429300; cv=none; b=T8kMMjxwN/PWjVf7gWybnuS+xpdGdMctKGoaqaxtt0TAvxyylLA8lPd4pSLxyu/7QQsyYDwHJdYYw39oIlMYLXcuBlaIx9VHBF2/A71zREtmRtlzceBgPiF3XBZjDDm8H1uJAmySd0tSCoEkw7BZlM2ZvqQ23I7wfXp76c0DXNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712429300; c=relaxed/simple; bh=JkJ7awgyjocGhExtmI0IDac+uVE+RlqQYYJBf5DuZq4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iWQU1vF+ecMXfFlXavKQYBcqc6V3vWQEEfRU5G9JcDZJlWadQhEs4LkeU6mqcBzPz3CgxuQc4ey+O/JGI91jnAczMVjEQubZO19O92UtKngBQta4QL4y0qWIGKzt6tqRqnQWqqSc+r6c30h8caTCPfQBq9g/RVAObovnsK1RC8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=pCMnijP8; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Date: Sat, 6 Apr 2024 14:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712429295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JkJ7awgyjocGhExtmI0IDac+uVE+RlqQYYJBf5DuZq4=; b=pCMnijP8skWXiWntA/2D771ghSaPHh5ZwlBPv314cVMEzn1ZDgz8AUVguO2f2aQL/J0RF7 NrC+tsBQev8vsoIwm74bxaqFaVc5kid9MQ+x61BJprgAkCXIIyigmhoKZcBXOybdiUmp94 AGBIIOyth5YoNU+D9CeOhezBB6KNWFY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Thorsten Blum Cc: Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcachefs: Rename struct field swap to prevent macro naming collision Message-ID: References: <20240406141919.248148-2-thorsten.blum@toblux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240406141919.248148-2-thorsten.blum@toblux.com> X-Migadu-Flow: FLOW_OUT On Sat, Apr 06, 2024 at 04:19:20PM +0200, Thorsten Blum wrote: > The struct field swap can collide with the swap() macro defined in > linux/minmax.h. Rename the struct field to prevent such collisions. Same as in lib/sort.c, so what's the actual reason?