Received-SPF: pass (google.com: domain of linux-kernel+bounces-134115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
	<krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo
	<shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi
	<cristian.marussi@arm.com>
CC: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Topic: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Index: AQHah1U59RmV1LBnZEq28+9F7LvjPrFbFSOAgADj6VA=
Date: Sun, 7 Apr 2024 00:51:32 +0000
Message-ID:
 <DU0PR04MB941719A18C3F749E7D180FD888012@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com>
 <20240405-imx95-bbm-misc-v2-v2-2-9fc9186856c2@nxp.com>
 <9aab8dab-27c4-40b6-b1d5-0a2babe0700d@kernel.org>
In-Reply-To: <9aab8dab-27c4-40b6-b1d5-0a2babe0700d@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?VlMODbN5Ph+KR5xSvkNGJtARkHFVINXtyaO3YAqRjXuFPvEQILIFYgvAoXVk?=
 =?us-ascii?Q?hKIEwdUh+ZSNV5mYeuAIMUGhDn5Q1wQBDBG5JeSdA1UoOEfS+Vps8PWrNvHf?=
 =?us-ascii?Q?3XO+NdyrIzPz4v4wOQzyTgDZULo2zn6nUnWFguwOhpbOJ96GbEHsfjQzdAge?=
 =?us-ascii?Q?NHFT6slO5UTfJkpEC3+8mW6X8wAWZkyLbaGWArFDVifH8oHm79aukzQWdTj+?=
 =?us-ascii?Q?BYg2pqcFO6IXajH99dCWGw0tqp0cZSMxMczLVpKQYBttOyR8ClbsdhivNDln?=
 =?us-ascii?Q?FVjUy8PyPmcR3/v2OJN6+CXSJjSQyE2tChZlSTlfbY4DLNJtXGbY+ci4eJG4?=
 =?us-ascii?Q?f5+CnIsbssk93Ac5Jpr5Nas8QBg9sSy0gxzZXqJip6W3OQtfWoeWdHIYu1T6?=
 =?us-ascii?Q?eC3TctuXIwcxD+sj6E5dOJpizN6o9Duffa+fcrvtH1aY2ggXLr3flrYOXX47?=
 =?us-ascii?Q?q7eWlAzaFbRHf4PR0elZm0vXdywviYNoq/cOVut7beUU34LVU5fdto8gLEN2?=
 =?us-ascii?Q?wAhqrbQvH3waX+U8hh5mPhZF6/tITD1y4vKwI0FXt7j9csDEGa1Kif3y+Lss?=
 =?us-ascii?Q?dYQhGIPItcgm72lrZ+XzWuCu3GxbjNiCt6l5GLRIvDfxtfx0WicHyYfOVf0f?=
 =?us-ascii?Q?d89rwF/QaJjQUrZo434fUI3pvCSLFNSnpLE0Nu2twzxaWo/oypyR9tu3bChJ?=
 =?us-ascii?Q?BlDB2Lvr/rH4XragCr3Ld8I/9VSoVsYm66m0o+RvcUvosnhxLKWjOzaKn1tF?=
 =?us-ascii?Q?DlcIrGXyDcUrdnSdW99Eu3BRNW2Pa7v5WJTWYysKS2P1vWNJNUNF0SVMAxHX?=
 =?us-ascii?Q?IKr2Ia9nSg4z1JSy+FFC4NFcOvhdzZgPOFsFl/Y5YF5WKESIR+3069lBWvYw?=
 =?us-ascii?Q?NaUvlglKfEk6YbH8Ws5zXJn+PJC1JXdh52DCbfhpXKulyYMrgEdN5QPJVO/G?=
 =?us-ascii?Q?ejTVG69uSd+JmXMbASgo2MwWZlk31LU7QD0aF6gCbwwJ1AGH5+g7QEV7wCgZ?=
 =?us-ascii?Q?V682EeB0wDRw7FJRT30Mezxros9OAh4ZXxGrhU5uIadARA4LLimGb24j+HKV?=
 =?us-ascii?Q?9+IfODC3Ed/2mBi646dmiFc0aDkiQWW502DoGCmJP9IVcf4c5BrvLQmzt+tN?=
 =?us-ascii?Q?DtJi8UP4ohnoEtoRXc2ld6dN0oI4QC6lP5fObS3DbFHEB5nyxBQ5PUCvIA9X?=
 =?us-ascii?Q?01fbQ6AtoWSDY+JUmnZamlbHiS8lEPXDdxB8ERGXrHbEuhYTHxjxaUPVihpe?=
 =?us-ascii?Q?KJdKwciQIsk975yvDa1wgTPbHkNtjDnZ3S5accn/CVrSEOrXSons/J0rhgyO?=
 =?us-ascii?Q?ZPTFd2FhNoemtURQYbo5a19iDDXgkMg0WXb3oV66ElrsFK7zC+yE0b/W2Uai?=
 =?us-ascii?Q?56EZklk34ertxBPvPjDc1EGhgPlTJMDgLBijbNgkLa6QTQQVH7aKp7IRjAfE?=
 =?us-ascii?Q?ZYo3eBogmtSHJsxu2kvyFln9FdoouPpdPg0NwgQuk7hhym6xKkMZF/p5HkpL?=
 =?us-ascii?Q?zlbUj20/7amU9/VHAL9/creKcZ4NGeeCyduFJvx9zMo2guzuBxaKSc5JRl2R?=
 =?us-ascii?Q?wctNYMvz54KEbLL2SOk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49f822b5-ccbe-4ca4-4a26-08dc569cde86
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2024 00:51:32.7420
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1aK6KN3eZifcbTiyNWMSmrjVrQ6kNR6Nu9Dhff0e1aq7Z4DiArr3r6vJtBNfUsZsaVq+R6N1gmXP9NtUTDGi6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8486

> Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extensio=
n
> protocol
>=20
> On 05/04/2024 14:39, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add i.MX SCMI Extension protocols bindings for:
> >  - Battery Backed Secure Module(BBSM)
>=20
> Which is what?

I should say BBM(BBSM + BBNSM), BBM has RTC and ON/OFF
key features, but BBM is managed by SCMI firmware and exported
to agent by BBM protocol. So add bindings for i.MX BBM protocol.

Is this ok?

>=20
> >  - MISC settings such as General Purpose Registers settings.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/firmware/imx,scmi.yaml     | 80
> ++++++++++++++++++++++
> >  1 file changed, 80 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > new file mode 100644
> > index 000000000000..7ee19a661d83
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > @@ -0,0 +1,80 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2024
> > +NXP %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> >
> +cetree.org%2Fschemas%2Ffirmware%2Fimx%2Cscmi.yaml%23&data=3D05%7
> C02%7Cp
> >
> +eng.fan%40nxp.com%7C5d16781d3eca425a342508dc562910b7%7C686ea
> 1d3bc2b4c
> >
> +6fa92cd99c5c301635%7C0%7C0%7C638479981570959816%7CUnknown%
> 7CTWFpbGZsb
> >
> +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D
> >
> +%7C0%7C%7C%7C&sdata=3DmWNwPvu2eyF18MroVOBHb%2Fjeo%2BIHfV5V
> h%2F9ebdx65MM
> > +%3D&reserved=3D0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=3D05%7C02%7Cpeng.fan%40nx
> >
> +p.com%7C5d16781d3eca425a342508dc562910b7%7C686ea1d3bc2b4c6fa
> 92cd99c5c
> >
> +301635%7C0%7C0%7C638479981570971949%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiM
> >
> +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> C%7C%7
> >
> +C&sdata=3Dv4XnGG00D4I8j5MJvDUVYMRTm7yRrvz0V3fUyc5KAAA%3D&reser
> ved=3D0
> > +
> > +title: i.MX System Control and Management Interface(SCMI) Vendor
> > +Protocols Extension
> > +
> > +maintainers:
> > +  - Peng Fan <peng.fan@nxp.com>
> > +
> > +allOf:
> > +  - $ref: arm,scmi.yaml#
>=20
> Sorry, but arm,scmi is a final schema. Is your plan to define some common
> part?

No. I just wanna add vendor extension per SCMI spec.=20

0x80-0xFF:
Reserved for vendor or platform-specific extensions to this interface

Each vendor may have different usage saying id 0x81, so I add
i.MX dt-schema file.

>=20
> > +
> > +properties:
> > +  protocol@81:
> > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > +    unevaluatedProperties: false
> > +    description:
> > +      The BBM Protocol is for managing Battery Backed Secure Module
> (BBSM) RTC
> > +      and the ON/OFF Key
> > +
> > +    properties:
> > +      reg:
> > +        const: 0x81
> > +
> > +    required:
> > +      - reg
> > +
> > +  protocol@84:
> > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > +    unevaluatedProperties: false
> > +    description:
> > +      The MISC Protocol is for managing SoC Misc settings, such as
> > + GPR settings
>=20
> Genera register is not a setting... this is a pleonasm. Please be more sp=
ecific
> what is the GPR, MISC protocol etc.

The MISC Protocol is for managing SoC Misc settings, such as SAI MCLK/MQS i=
n
Always On domain BLK CTRL,  SAI_CLK_SEL in WAKEUP BLK CTRL, gpio
expanders which is under control of SCMI firmware.

> > +
> > +    properties:
> > +      reg:
> > +        const: 0x84
> > +
> > +      wakeup-sources:
> > +        description:
> > +          Each entry consists of 2 integers, represents the source
> > + and electric signal edge
>=20
> Can you answer questions from reviewers?

Sorry. Is this ok?
minItems: 1
maxItems: 32

>=20
> > +        items:
> > +          items:
> > +            - description: the wakeup source
> > +            - description: the wakeup electric signal edge
> > +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > +
> > +    required:
> > +      - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    firmware {
> > +        scmi {
> > +            compatible =3D "arm,scmi";
>=20
> > +            mboxes =3D <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>;
> > +            shmem =3D <&scmi_buf0>, <&scmi_buf1>;
> > +
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +
> > +            protocol@81 {
> > +                reg =3D <0x81>;
> > +            };
> > +
> > +            protocol@84 {
> > +                reg =3D <0x84>;
> > +                wakeup-sources =3D <0x8000 1
> > +                                  0x8001 1
> > +                                  0x8002 1
> > +                                  0x8003 1
> > +                                  0x8004 1>;
>=20
> Nothing improved... If you are going to ignore reviews, then you will onl=
y get
> NAKed.

Sorry, you mean the examples, or the whole dt-schema?

Thanks,
Peng.
>=20
> Best regards,
> Krzysztof