Received-SPF: pass (google.com: domain of linux-kernel+bounces-134116-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Peng Fan <peng.fan@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha
 Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Sudeep Holla
	<sudeep.holla@arm.com>, Cristian Marussi <cristian.marussi@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>
Subject: RE: [PATCH v2 4/6] firmware: arm_scmi: add initial support for i.MX
 MISC protocol
Thread-Topic: [PATCH v2 4/6] firmware: arm_scmi: add initial support for i.MX
 MISC protocol
Thread-Index: AQHah1U+Ouni2yxGIkadGTHqoE9cS7FZ4lEAgAIamiA=
Date: Sun, 7 Apr 2024 01:03:55 +0000
Message-ID:
 <DU0PR04MB9417A07F56B7E14DAB3DCE2188012@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com>
 <20240405-imx95-bbm-misc-v2-v2-4-9fc9186856c2@nxp.com>
 <20240405164414.t3fqhnwudxxt2ozv@pengutronix.de>
In-Reply-To: <20240405164414.t3fqhnwudxxt2ozv@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?qEBxaDubDda93aj8damHYOjCVlkOSERdUbzirhrDQ9P4e5cQDUd6Oc8cWlR5?=
 =?us-ascii?Q?I8qMwbK1NhXrxwsAkZwxuB6BC1fBoXHg5o52iZPSIXCCW1QKRpgaxRDx6OyY?=
 =?us-ascii?Q?hCPLl/AiFJ/VgNuZQ9UmyAzqFY/EAWnK99d/GUp1VXB68gpbZcwTdeniRnvd?=
 =?us-ascii?Q?Y/sc3NqQN9sriKotjhAXmOP8nxnQppz1uv/mP7CQNg6zBoL0DQpAXFmU8f0t?=
 =?us-ascii?Q?lwdxU2LayXN8y4JsWdEHlSBo9tKb8Xw3tybz4fhUp6BGY90hy3pIgtszpsIf?=
 =?us-ascii?Q?UypMrdaa6UEs2dJED5/PJreHRmY7Sr7IlP/dS84Mr0cuvkhg7wFYcQQFCmTI?=
 =?us-ascii?Q?bRj69D1YomtoWNQhMuYweBky+If2XtOGLY3QdUmwSke49yZAAvZXs+x+wqKL?=
 =?us-ascii?Q?EdRutQNoUmhL+8zvmxroxWYCN0a97VYxUGbzBEip/SRLBxkfKfXoG2oxGOBg?=
 =?us-ascii?Q?j8rGnWI6PaICMJAbZN1a0BYy/7pza5WUv3UNoRyj5SvbNJnYElKnK/0m+fZV?=
 =?us-ascii?Q?raP5IO/XezfIoR7Gv4BBhnM+Z4fjWJJnjq1mzyNKBMIe7rtZ6uf7FrK99vEl?=
 =?us-ascii?Q?ext58aWpowbjqYQCGKSwSY9ZDIzEundjmwCwbzNXneoFiT74K80+JsAvG4am?=
 =?us-ascii?Q?gVW7ad4eL3j/gNyjVsZo4sPIburkv8D7BEp+Fr1EYkhpQJ6Ds9VPyL6fSOwB?=
 =?us-ascii?Q?39LaWE1DgNu0+n8rep4XeuwCTyNY10ScyxQ24qumTiqqDfntH+fZ+97r8o8b?=
 =?us-ascii?Q?NMOK+jGDtS5O52oTdg7sqJBnHpWJsgwjNrbketbIxToqvKKsuywhxDrW4jVl?=
 =?us-ascii?Q?kJTVaOymnnWz2oLWqkWOHa0dcKQHze6Jc//vGvveXQlJfN2dNPG09NwYcHDp?=
 =?us-ascii?Q?ReGC8OKqBy1uN7Cd8ifuQ9kZjWAp1w59hTyaZUmKquamdUCLbX4XwrjNpoqB?=
 =?us-ascii?Q?Q5zuououPYxgg15jG+ohsxgzXVNOV7u0W2Ce0+2uSTJx8ybdjdUCml+lhYLx?=
 =?us-ascii?Q?NYvJKBgx64q9zYphtm3p0wVMlL1+jJzR0rQKN7Xu1NfUKW0X3aTyJb8Oro/x?=
 =?us-ascii?Q?8axDcl1ea7/vmNlWn42ScpGzuIeQoa69EzP2D8rv6elmfoxP+CSdjg2OyyKM?=
 =?us-ascii?Q?kLTuWxPxk18yTZmtDYnqQhchaq1s5JGuMoVZVbjkhY4vN9jnEMZ61qBayVJy?=
 =?us-ascii?Q?V8fw2OgYBHuq38CDJjbdjbynaRpYipa7aVLZo5LTeBJpcSzE/A2WjU7hlMRb?=
 =?us-ascii?Q?2hU+9ftgc7ni2sKDS4wgew3mdnKWXiA4AFWG5TPI54Um/nMcg4nLA7iIrs+o?=
 =?us-ascii?Q?0u8Crve2QSTgELwsCg69kQ2uXDxNNRT8wAVw/RbPfm5X+1kMaB19IK5XyWOo?=
 =?us-ascii?Q?RvoXEbjlrpT9gmnwHRm98IMHaV3gYc4BJ9ucd5PKTPAOIJ+mahVpKKnrKpFf?=
 =?us-ascii?Q?thEMTO8OYbnAk4YnX6K8PAo8h+IjDujTgnWP9HAddfGhe7W5mX0EoR3QijkH?=
 =?us-ascii?Q?WrfUSEtXmwuedxhqdc+//oeObtC0Kc1fdvmRHdLyuNWkqkIUmmKgRySn09Jg?=
 =?us-ascii?Q?FpTgql56cSOxEYYFmx8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3dc1fd2-3b0a-4d6d-624e-08dc569e997f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2024 01:03:55.9565
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bh7zcQLaSkYinuobciE/8Tmv75pfqBS6+16TPfZoAlHwJ+RzTl30DRAiv+ZLzWr9wV/zs6m5Jfxe0fbt0H/tXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7141

> Subject: Re: [PATCH v2 4/6] firmware: arm_scmi: add initial support for i=
MX
> MISC protocol
>=20
> Hi Peng,
>=20
> On 24-04-05, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The i.MX MISC protocol is for misc settings, such as gpio expander
> > wakeup.
>=20
> Can you elaborate a bit more please?

The gpio expander is under M33(SCMI firmware used core) I2C control,
But the gpio expander supports board function such as PCIE_WAKEUP,
BTN_WAKEUP. So these are managed by MISC protocol.

SAI_CLK_MSEL in WAKEUP BLK CTRL is also managed by MISC Protocol.

And etc...

I will add more info in commit log in next version later, after I get more
reviews on the patchset.

Thanks,
Peng.

>=20
> Regards,
>   Marco
>=20
>=20
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/firmware/arm_scmi/Kconfig       |  10 ++
> >  drivers/firmware/arm_scmi/Makefile      |   1 +
> >  drivers/firmware/arm_scmi/imx-sm-misc.c | 305
> ++++++++++++++++++++++++++++++++
> >  include/linux/scmi_imx_protocol.h       |  17 ++
> >  4 files changed, 333 insertions(+)
> >
> > diff --git a/drivers/firmware/arm_scmi/Kconfig
> > b/drivers/firmware/arm_scmi/Kconfig
> > index 56d11c9d9f47..bfeae92f6420 100644
> > --- a/drivers/firmware/arm_scmi/Kconfig
> > +++ b/drivers/firmware/arm_scmi/Kconfig
> > @@ -191,3 +191,13 @@ config IMX_SCMI_BBM_EXT
> >  	  and BUTTON.
> >
> >  	  This driver can also be built as a module.
> > +
> > +config IMX_SCMI_MISC_EXT
> > +	tristate "i.MX SCMI MISC EXTENSION"
> > +	depends on ARM_SCMI_PROTOCOL || (COMPILE_TEST && OF)
> > +	default y if ARCH_MXC
> > +	help
> > +	  This enables i.MX System MISC control logic such as gpio expander
> > +	  wakeup
> > +
> > +	  This driver can also be built as a module.
> > diff --git a/drivers/firmware/arm_scmi/Makefile
> > b/drivers/firmware/arm_scmi/Makefile
> > index 327687acf857..a23fde721222 100644
> > --- a/drivers/firmware/arm_scmi/Makefile
> > +++ b/drivers/firmware/arm_scmi/Makefile
> > @@ -12,6 +12,7 @@ scmi-transport-
> $(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO)
> > +=3D virtio.o
> >  scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) +=3D optee.o
> > scmi-protocols-y =3D base.o clock.o perf.o power.o reset.o sensors.o
> > system.o voltage.o powercap.o
> >  scmi-protocols-$(CONFIG_IMX_SCMI_BBM_EXT) +=3D imx-sm-bbm.o
> > +scmi-protocols-$(CONFIG_IMX_SCMI_MISC_EXT) +=3D imx-sm-misc.o
> >  scmi-module-objs :=3D $(scmi-driver-y) $(scmi-protocols-y)
> > $(scmi-transport-y)
> >
> >  obj-$(CONFIG_ARM_SCMI_PROTOCOL) +=3D scmi-core.o diff --git
> > a/drivers/firmware/arm_scmi/imx-sm-misc.c
> > b/drivers/firmware/arm_scmi/imx-sm-misc.c
> > new file mode 100644
> > index 000000000000..1b0ec2281518
> > --- /dev/null
> > +++ b/drivers/firmware/arm_scmi/imx-sm-misc.c
> > @@ -0,0 +1,305 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * System control and Management Interface (SCMI) NXP MISC Protocol
> > + *
> > + * Copyright 2024 NXP
> > + */
> > +
> > +#define pr_fmt(fmt) "SCMI Notifications MISC - " fmt
> > +
> > +#include <linux/bits.h>
> > +#include <linux/io.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/scmi_protocol.h>
> > +#include <linux/scmi_imx_protocol.h>
> > +
> > +#include "protocols.h"
> > +#include "notify.h"
> > +
> > +#define SCMI_PROTOCOL_SUPPORTED_VERSION		0x10000
> > +
> > +enum scmi_imx_misc_protocol_cmd {
> > +	SCMI_IMX_MISC_CTRL_SET	=3D 0x3,
> > +	SCMI_IMX_MISC_CTRL_GET	=3D 0x4,
> > +	SCMI_IMX_MISC_CTRL_NOTIFY =3D 0x8,
> > +};
> > +
> > +struct scmi_imx_misc_info {
> > +	u32 version;
> > +	u32 nr_dev_ctrl;
> > +	u32 nr_brd_ctrl;
> > +	u32 nr_reason;
> > +};
> > +
> > +struct scmi_msg_imx_misc_protocol_attributes {
> > +	__le32 attributes;
> > +};
> > +
> > +#define GET_BRD_CTRLS_NR(x)	le32_get_bits((x), GENMASK(31,
> 24))
> > +#define GET_REASONS_NR(x)	le32_get_bits((x), GENMASK(23, 16))
> > +#define GET_DEV_CTRLS_NR(x)	le32_get_bits((x), GENMASK(15, 0))
> > +#define BRD_CTRL_START_ID	BIT(15)
> > +
> > +struct scmi_imx_misc_ctrl_set_in {
> > +	__le32 id;
> > +	__le32 num;
> > +	__le32 value[MISC_MAX_VAL];
> > +};
> > +
> > +struct scmi_imx_misc_ctrl_notify_in {
> > +	__le32 ctrl_id;
> > +	__le32 flags;
> > +};
> > +
> > +struct scmi_imx_misc_ctrl_notify_payld {
> > +	__le32 ctrl_id;
> > +	__le32 flags;
> > +};
> > +
> > +struct scmi_imx_misc_ctrl_get_out {
> > +	__le32 num;
> > +	__le32 *val;
> > +};
> > +
> > +static int scmi_imx_misc_attributes_get(const struct scmi_protocol_han=
dle
> *ph,
> > +					struct scmi_imx_misc_info *mi)
> > +{
> > +	int ret;
> > +	struct scmi_xfer *t;
> > +	struct scmi_msg_imx_misc_protocol_attributes *attr;
> > +
> > +	ret =3D ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0,
> > +				      sizeof(*attr), &t);
> > +	if (ret)
> > +		return ret;
> > +
> > +	attr =3D t->rx.buf;
> > +
> > +	ret =3D ph->xops->do_xfer(ph, t);
> > +	if (!ret) {
> > +		mi->nr_dev_ctrl =3D GET_DEV_CTRLS_NR(attr->attributes);
> > +		mi->nr_brd_ctrl =3D GET_BRD_CTRLS_NR(attr->attributes);
> > +		mi->nr_reason =3D GET_REASONS_NR(attr->attributes);
> > +		dev_info(ph->dev, "i.MX MISC NUM DEV CTRL: %d, NUM
> BRD CTRL: %d,NUM Reason: %d\n",
> > +			 mi->nr_dev_ctrl, mi->nr_brd_ctrl, mi->nr_reason);
> > +	}
> > +
> > +	ph->xops->xfer_put(ph, t);
> > +
> > +	return ret;
> > +}
> > +
> > +static int scmi_imx_misc_ctrl_validate_id(const struct
> scmi_protocol_handle *ph,
> > +					  u32 ctrl_id)
> > +{
> > +	struct scmi_imx_misc_info *mi =3D ph->get_priv(ph);
> > +
> > +	if ((ctrl_id < BRD_CTRL_START_ID) && (ctrl_id > mi->nr_dev_ctrl))
> > +		return -EINVAL;
> > +	if (ctrl_id >=3D BRD_CTRL_START_ID + mi->nr_brd_ctrl)
> > +		return -EINVAL;
> > +
> > +	return 0;
> > +}
> > +
> > +static int scmi_imx_misc_ctrl_notify(const struct scmi_protocol_handle
> *ph,
> > +				     u32 ctrl_id, u32 flags)
> > +{
> > +	struct scmi_imx_misc_ctrl_notify_in *in;
> > +	struct scmi_xfer *t;
> > +	int ret;
> > +
> > +	ret =3D scmi_imx_misc_ctrl_validate_id(ph, ctrl_id);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret =3D ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_CTRL_NOTIFY,
> > +				      sizeof(*in), 0, &t);
> > +	if (ret)
> > +		return ret;
> > +
> > +	in =3D t->tx.buf;
> > +	in->ctrl_id =3D cpu_to_le32(ctrl_id);
> > +	in->flags =3D cpu_to_le32(flags);
> > +
> > +	ret =3D ph->xops->do_xfer(ph, t);
> > +
> > +	ph->xops->xfer_put(ph, t);
> > +
> > +	return ret;
> > +}
> > +
> > +static int
> > +scmi_imx_misc_ctrl_set_notify_enabled(const struct
> scmi_protocol_handle *ph,
> > +				      u8 evt_id, u32 src_id, bool enable) {
> > +	int ret;
> > +
> > +	ret =3D scmi_imx_misc_ctrl_notify(ph, src_id, enable ? evt_id : 0);
> > +	if (ret)
> > +		dev_err(ph->dev, "FAIL_ENABLED - evt[%X] src[%d] -
> ret:%d\n",
> > +			evt_id, src_id, ret);
> > +
> > +	return ret;
> > +}
> > +
> > +static int scmi_imx_misc_ctrl_get_num_sources(const struct
> > +scmi_protocol_handle *ph) {
> > +	return GENMASK(15, 0);
> > +}
> > +
> > +static void *
> > +scmi_imx_misc_ctrl_fill_custom_report(const struct scmi_protocol_handl=
e
> *ph,
> > +				      u8 evt_id, ktime_t timestamp,
> > +				      const void *payld, size_t payld_sz,
> > +				      void *report, u32 *src_id)
> > +{
> > +	const struct scmi_imx_misc_ctrl_notify_payld *p =3D payld;
> > +	struct scmi_imx_misc_ctrl_notify_report *r =3D report;
> > +
> > +	if (sizeof(*p) !=3D payld_sz)
> > +		return NULL;
> > +
> > +	r->timestamp =3D timestamp;
> > +	r->ctrl_id =3D p->ctrl_id;
> > +	r->flags =3D p->flags;
> > +	*src_id =3D r->ctrl_id;
> > +	dev_dbg(ph->dev, "%s: ctrl_id: %d flags: %d\n", __func__,
> > +		r->ctrl_id, r->flags);
> > +
> > +	return r;
> > +}
> > +
> > +static const struct scmi_event_ops scmi_imx_misc_event_ops =3D {
> > +	.get_num_sources =3D scmi_imx_misc_ctrl_get_num_sources,
> > +	.set_notify_enabled =3D scmi_imx_misc_ctrl_set_notify_enabled,
> > +	.fill_custom_report =3D scmi_imx_misc_ctrl_fill_custom_report,
> > +};
> > +
> > +static const struct scmi_event scmi_imx_misc_events[] =3D {
> > +	{
> > +		.id =3D SCMI_EVENT_IMX_MISC_CONTROL_DISABLED,
> > +		.max_payld_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_payld),
> > +		.max_report_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_report),
> > +	},
> > +	{
> > +		.id =3D SCMI_EVENT_IMX_MISC_CONTROL_FALLING_EDGE,
> > +		.max_payld_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_payld),
> > +		.max_report_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_report),
> > +	},
> > +	{
> > +		.id =3D SCMI_EVENT_IMX_MISC_CONTROL_RISING_EDGE,
> > +		.max_payld_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_payld),
> > +		.max_report_sz =3D sizeof(struct
> scmi_imx_misc_ctrl_notify_report),
> > +	}
> > +};
> > +
> > +static struct scmi_protocol_events scmi_imx_misc_protocol_events =3D {
> > +	.queue_sz =3D SCMI_PROTO_QUEUE_SZ,
> > +	.ops =3D &scmi_imx_misc_event_ops,
> > +	.evts =3D scmi_imx_misc_events,
> > +	.num_events =3D ARRAY_SIZE(scmi_imx_misc_events), };
> > +
> > +static int scmi_imx_misc_protocol_init(const struct
> > +scmi_protocol_handle *ph) {
> > +	struct scmi_imx_misc_info *minfo;
> > +	u32 version;
> > +	int ret;
> > +
> > +	ret =3D ph->xops->version_get(ph, &version);
> > +	if (ret)
> > +		return ret;
> > +
> > +	dev_info(ph->dev, "NXP SM MISC Version %d.%d\n",
> > +		 PROTOCOL_REV_MAJOR(version),
> PROTOCOL_REV_MINOR(version));
> > +
> > +	minfo =3D devm_kzalloc(ph->dev, sizeof(*minfo), GFP_KERNEL);
> > +	if (!minfo)
> > +		return -ENOMEM;
> > +
> > +	ret =3D scmi_imx_misc_attributes_get(ph, minfo);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return ph->set_priv(ph, minfo, version); }
> > +
> > +static int scmi_imx_misc_ctrl_get(const struct scmi_protocol_handle *p=
h,
> > +				  u32 ctrl_id, u32 *num, u32 *val) {
> > +	struct scmi_imx_misc_ctrl_get_out *out;
> > +	struct scmi_xfer *t;
> > +	int ret, i;
> > +
> > +	ret =3D scmi_imx_misc_ctrl_validate_id(ph, ctrl_id);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret =3D ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_CTRL_GET,
> sizeof(u32),
> > +				      0, &t);
> > +	if (ret)
> > +		return ret;
> > +
> > +	put_unaligned_le32(ctrl_id, t->tx.buf);
> > +	ret =3D ph->xops->do_xfer(ph, t);
> > +	if (!ret) {
> > +		out =3D t->rx.buf;
> > +		*num =3D le32_to_cpu(out->num);
> > +		for (i =3D 0; i < *num && i < MISC_MAX_VAL; i++)
> > +			val[i] =3D le32_to_cpu(out->val[i]);
> > +	}
> > +
> > +	ph->xops->xfer_put(ph, t);
> > +
> > +	return ret;
> > +}
> > +
> > +static int scmi_imx_misc_ctrl_set(const struct scmi_protocol_handle *p=
h,
> > +				  u32 ctrl_id, u32 num, u32 *val) {
> > +	struct scmi_imx_misc_ctrl_set_in *in;
> > +	struct scmi_xfer *t;
> > +	int ret, i;
> > +
> > +	ret =3D scmi_imx_misc_ctrl_validate_id(ph, ctrl_id);
> > +	if (ret)
> > +		return ret;
> > +
> > +	if (num > MISC_MAX_VAL)
> > +		return -EINVAL;
> > +
> > +	ret =3D ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_CTRL_SET,
> sizeof(*in),
> > +				      0, &t);
> > +	if (ret)
> > +		return ret;
> > +
> > +	in =3D t->tx.buf;
> > +	in->id =3D cpu_to_le32(ctrl_id);
> > +	in->num =3D cpu_to_le32(num);
> > +	for (i =3D 0; i < num; i++)
> > +		in->value[i] =3D cpu_to_le32(val[i]);
> > +
> > +	ret =3D ph->xops->do_xfer(ph, t);
> > +
> > +	ph->xops->xfer_put(ph, t);
> > +
> > +	return ret;
> > +}
> > +
> > +static const struct scmi_imx_misc_proto_ops scmi_imx_misc_proto_ops =
=3D
> {
> > +	.misc_ctrl_set =3D scmi_imx_misc_ctrl_set,
> > +	.misc_ctrl_get =3D scmi_imx_misc_ctrl_get, };
> > +
> > +static const struct scmi_protocol scmi_imx_misc =3D {
> > +	.id =3D SCMI_PROTOCOL_IMX_MISC,
> > +	.owner =3D THIS_MODULE,
> > +	.instance_init =3D &scmi_imx_misc_protocol_init,
> > +	.ops =3D &scmi_imx_misc_proto_ops,
> > +	.events =3D &scmi_imx_misc_protocol_events,
> > +	.supported_version =3D SCMI_PROTOCOL_SUPPORTED_VERSION, };
> > +module_scmi_protocol(scmi_imx_misc);
> > diff --git a/include/linux/scmi_imx_protocol.h
> > b/include/linux/scmi_imx_protocol.h
> > index 90ce011a4429..a69bd4a20f0f 100644
> > --- a/include/linux/scmi_imx_protocol.h
> > +++ b/include/linux/scmi_imx_protocol.h
> > @@ -13,8 +13,14 @@
> >  #include <linux/notifier.h>
> >  #include <linux/types.h>
> >
> > +#define SCMI_PAYLOAD_LEN	100
> > +
> > +#define SCMI_ARRAY(X, Y)	((SCMI_PAYLOAD_LEN - (X)) / sizeof(Y))
> > +#define MISC_MAX_VAL		SCMI_ARRAY(8, uint32_t)
> > +
> >  enum scmi_nxp_protocol {
> >  	SCMI_PROTOCOL_IMX_BBM =3D 0x81,
> > +	SCMI_PROTOCOL_IMX_MISC =3D 0x84,
> >  };
> >
> >  struct scmi_imx_bbm_proto_ops {
> > @@ -42,4 +48,15 @@ struct scmi_imx_bbm_notif_report {
> >  	unsigned int		rtc_id;
> >  	unsigned int		rtc_evt;
> >  };
> > +
> > +struct scmi_imx_misc_ctrl_notify_report {
> > +	ktime_t			timestamp;
> > +	unsigned int		ctrl_id;
> > +	unsigned int		flags;
> > +};
> > +
> > +struct scmi_imx_misc_proto_ops {
> > +	int (*misc_ctrl_set)(const struct scmi_protocol_handle *ph, u32 id,
> u32 num, u32 *val);
> > +	int (*misc_ctrl_get)(const struct scmi_protocol_handle *ph, u32 id,
> > +u32 *num, u32 *val); };
> >  #endif
> >
> > --
> > 2.37.1
> >
> >
> >