Received-SPF: pass (google.com: domain of linux-kernel+bounces-134126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
	<krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo
	<shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi
	<cristian.marussi@arm.com>
CC: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Topic: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Index: AQHah1U59RmV1LBnZEq28+9F7LvjPrFbFSOAgADj6VCAABPlMA==
Date: Sun, 7 Apr 2024 01:50:03 +0000
Message-ID:
 <DU0PR04MB9417786C4A0B2B54947D70E588012@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com>
 <20240405-imx95-bbm-misc-v2-v2-2-9fc9186856c2@nxp.com>
 <9aab8dab-27c4-40b6-b1d5-0a2babe0700d@kernel.org>
 <DU0PR04MB941719A18C3F749E7D180FD888012@DU0PR04MB9417.eurprd04.prod.outlook.com>
In-Reply-To:
 <DU0PR04MB941719A18C3F749E7D180FD888012@DU0PR04MB9417.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?+L7VUj575xfqU6XiMhrJOq5BoQ6SPnA8IUZJEdiIwNo9vYVs3rMLyTWmtutK?=
 =?us-ascii?Q?v+O1Fzyj5zwXn4zoF5A93MzaEdSmcKTUWF9LaV7FiI/+caV4klSRBSoagNV8?=
 =?us-ascii?Q?ZAsI6213pD2jhEf7wJp5HnT6bSRkFhGq1yhdpz0L5rrp+IqJTk++vwa5v4Vh?=
 =?us-ascii?Q?usIpBJIHNL+n0sgd3pyZhe2Ad+5l42uYsXFr2vbC26t2hB7BtD4Y0ORn/rEZ?=
 =?us-ascii?Q?uQdgs/wR4VW6T9AQEE9PiSfxmL6gyaCuiEmpO1mzC0XxW/72INvALm3mXiYI?=
 =?us-ascii?Q?zv4fVevAIXoByuT+cgCfy4tG6I43bUiT3rgt1SZhbUpJkt76DXlN0bpP1dl7?=
 =?us-ascii?Q?M0YoJ1XZp82Gom/yAcNZ3BOsfk7tfx2dzeQPunLm+puIo4Wr/3MpNnhH9cnl?=
 =?us-ascii?Q?yaBwN3+HB+p4mRPIL6948X70+52CNyPFDAKsqrjFUO48R0U8RoUU5vPXfxqB?=
 =?us-ascii?Q?xP5/GqNLSJpQGAj3BsvmHlCsCa7ij3zqkUDNcaUU3+r8SwW+19r9vYDigJHA?=
 =?us-ascii?Q?3GEbp+zDxhYIG9fn6ro6081epPGgjfUSeRl5ccnLJexZuALM2k94vAP0zlJt?=
 =?us-ascii?Q?q8Mo8JusjQ9BXAQgQz7eUACyOFOYGON2JtWV7W+8pb7pLoTRSCrQAtz5ogGb?=
 =?us-ascii?Q?MNGCN12Fo9zHc22o0WFYpO3tDXo/ueRro9IVyTG2qvtGGtx3VIcF0iEeMmNP?=
 =?us-ascii?Q?yO2yKeC0/29opMAG1i/FGAS6WGEyt6tn7+Fc+M990T3kBxYDoFK36/IoMg3e?=
 =?us-ascii?Q?Ij4bztwi6gnEOVHCs/jj6NiWUMCXCQpRRfQF4yOzbDk8uAsII4t9w58DLMN3?=
 =?us-ascii?Q?kthx4OaBvmQqj6o7qdG0pp3OAJ+J49OqZUiwmNeuqn+6d6WQaEt5/K9Vdjvd?=
 =?us-ascii?Q?xB/feR5TDI3luXdbgM5saEowhXZBpXfvbvZXah10Nka2R5OE+r0wbAeTqUxs?=
 =?us-ascii?Q?PWPrL5o3MbO4aqh32H0GXntmhfd+QMapWpEVfr5CheDbiAfIGqJKiF46r9to?=
 =?us-ascii?Q?qgFRUmt4WSf8rsqnAkz0Ty5t+s85/SuDcGjnwsSaaMG7Zksx6rB16z0gsACi?=
 =?us-ascii?Q?JV74M3f6NPh8CVS5wfD3QiGnHgQS1HSFZcSHokJLHyugb5NtZBbQexDKsvjr?=
 =?us-ascii?Q?xvDJxNKK4HkWZ8ftsKhGCzEbkBUlQMLVz2PQaramSTJ6B3PF+wuo/tYzuV86?=
 =?us-ascii?Q?LEqaOh0zv71oGKmAHLFHL6sLbzACF0QETY3oycfpWmFHB0hTT6byuekDclbf?=
 =?us-ascii?Q?zUIH9w2MEpp9A/YIS7MVbP/sTcd3xFTb1FEAAJpGZGYRK/p5ckHn6kq2pNIh?=
 =?us-ascii?Q?mOjzW7d5HlOpYhsBbOySxGcJ3CR9R3dpeSO23r/tG5HGLxsKBpx7NrEPS9tT?=
 =?us-ascii?Q?WTfmgfYJm1THqcrJSDAybVcEJRpWEbYkHzwoHkfec/QjH3V8oLmKNfPJsT22?=
 =?us-ascii?Q?uNn74nVVfvsneIVXY9CepHJpPnJXNpYop9O/yl195DzxmcjjtwdIBr3UDEks?=
 =?us-ascii?Q?iAsRwYKFHmHPnB6QYb0ZIRMPOSiRhU/mTbRUI7D5wvbYxBqWjZf8g7RdAWEr?=
 =?us-ascii?Q?Mkchqm8zyx6eH4B90iE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd9f847c-b4f1-4461-a070-08dc56a50b3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2024 01:50:03.7538
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hJo3Mvz19OLCbXLy8IaG1HkCHp8/YW9ahmm2IJQVpys96+wuipewh1JHsBef7Q1AIpfqRLqOOoP9YqnRClDGMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7621

> Subject: RE: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extensio=
n
> protocol
>=20
> > Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI
> > Extension protocol
> >
> > On 05/04/2024 14:39, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Add i.MX SCMI Extension protocols bindings for:
> > >  - Battery Backed Secure Module(BBSM)
> >
> > Which is what?
>=20
> I should say BBM(BBSM + BBNSM), BBM has RTC and ON/OFF key features,
> but BBM is managed by SCMI firmware and exported to agent by BBM
> protocol. So add bindings for i.MX BBM protocol.
>=20
> Is this ok?
>=20
> >
> > >  - MISC settings such as General Purpose Registers settings.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >  .../devicetree/bindings/firmware/imx,scmi.yaml     | 80
> > ++++++++++++++++++++++
> > >  1 file changed, 80 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > > b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > > new file mode 100644
> > > index 000000000000..7ee19a661d83
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > > @@ -0,0 +1,80 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright
> > > +2024 NXP %YAML 1.2
> > > +---
> > > +$id:
> > > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fd=
e
> > > +vi
> > >
> >
> +cetree.org%2Fschemas%2Ffirmware%2Fimx%2Cscmi.yaml%23&data=3D05%7
> > C02%7Cp
> > >
> >
> +eng.fan%40nxp.com%7C5d16781d3eca425a342508dc562910b7%7C686ea
> > 1d3bc2b4c
> > >
> > +6fa92cd99c5c301635%7C0%7C0%7C638479981570959816%7CUnknown%
> > 7CTWFpbGZsb
> > >
> >
> +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> > 0%3D
> > >
> >
> +%7C0%7C%7C%7C&sdata=3DmWNwPvu2eyF18MroVOBHb%2Fjeo%2BIHfV5V
> > h%2F9ebdx65MM
> > > +%3D&reserved=3D0
> > > +$schema:
> > > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fd=
e
> > > +vi
> > > +cetree.org%2Fmeta-
> > schemas%2Fcore.yaml%23&data=3D05%7C02%7Cpeng.fan%40nx
> > >
> >
> +p.com%7C5d16781d3eca425a342508dc562910b7%7C686ea1d3bc2b4c6fa
> > 92cd99c5c
> > >
> >
> +301635%7C0%7C0%7C638479981570971949%7CUnknown%7CTWFpbGZs
> > b3d8eyJWIjoiM
> > >
> >
> +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> > C%7C%7
> > >
> >
> +C&sdata=3Dv4XnGG00D4I8j5MJvDUVYMRTm7yRrvz0V3fUyc5KAAA%3D&reser
> > ved=3D0
> > > +
> > > +title: i.MX System Control and Management Interface(SCMI) Vendor
> > > +Protocols Extension
> > > +
> > > +maintainers:
> > > +  - Peng Fan <peng.fan@nxp.com>
> > > +
> > > +allOf:
> > > +  - $ref: arm,scmi.yaml#
> >
> > Sorry, but arm,scmi is a final schema. Is your plan to define some
> > common part?
>=20
> No. I just wanna add vendor extension per SCMI spec.
>=20
> 0x80-0xFF:
> Reserved for vendor or platform-specific extensions to this interface
>=20
> Each vendor may have different usage saying id 0x81, so I add i.MX dt-
> schema file.
>=20
> >
> > > +
> > > +properties:
> > > +  protocol@81:
> > > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > > +    unevaluatedProperties: false
> > > +    description:
> > > +      The BBM Protocol is for managing Battery Backed Secure Module
> > (BBSM) RTC
> > > +      and the ON/OFF Key
> > > +
> > > +    properties:
> > > +      reg:
> > > +        const: 0x81
> > > +
> > > +    required:
> > > +      - reg
> > > +
> > > +  protocol@84:
> > > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > > +    unevaluatedProperties: false
> > > +    description:
> > > +      The MISC Protocol is for managing SoC Misc settings, such as
> > > + GPR settings
> >
> > Genera register is not a setting... this is a pleonasm. Please be more
> > specific what is the GPR, MISC protocol etc.
>=20
> The MISC Protocol is for managing SoC Misc settings, such as SAI MCLK/MQS
> in Always On domain BLK CTRL,  SAI_CLK_SEL in WAKEUP BLK CTRL, gpio
> expanders which is under control of SCMI firmware.
>=20
> > > +
> > > +    properties:
> > > +      reg:
> > > +        const: 0x84
> > > +
> > > +      wakeup-sources:
> > > +        description:
> > > +          Each entry consists of 2 integers, represents the source
> > > + and electric signal edge
> >
> > Can you answer questions from reviewers?
>=20
> Sorry. Is this ok?
> minItems: 1
> maxItems: 32
>=20
> >
> > > +        items:
> > > +          items:
> > > +            - description: the wakeup source
> > > +            - description: the wakeup electric signal edge
> > > +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > > +
> > > +    required:
> > > +      - reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    firmware {
> > > +        scmi {
> > > +            compatible =3D "arm,scmi";
> >
> > > +            mboxes =3D <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>;
> > > +            shmem =3D <&scmi_buf0>, <&scmi_buf1>;
> > > +
> > > +            #address-cells =3D <1>;
> > > +            #size-cells =3D <0>;
> > > +
> > > +            protocol@81 {
> > > +                reg =3D <0x81>;
> > > +            };
> > > +
> > > +            protocol@84 {
> > > +                reg =3D <0x84>;
> > > +                wakeup-sources =3D <0x8000 1
> > > +                                  0x8001 1
> > > +                                  0x8002 1
> > > +                                  0x8003 1
> > > +                                  0x8004 1>;
> >
> > Nothing improved... If you are going to ignore reviews, then you will
> > only get NAKed.
>=20
> Sorry, you mean the examples, or the whole dt-schema?

Missed Rob's comment, will use
< > for each entry.

Thanks,
Peng.

>=20
> Thanks,
> Peng.
> >
> > Best regards,
> > Krzysztof