Received-SPF: pass (google.com: domain of linux-kernel+bounces-134225-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 7 Apr 2024 10:35:21 +0300
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: irq_helpers: duplicate IRQ name
Message-ID: <ZhJMuUYwaZbBXFGP@drtxq0yyyyyyyyyyyyydy-3.rev.dnainternet.fi>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="oJylSAUUxXPDKJ0i"
Content-Disposition: inline


--oJylSAUUxXPDKJ0i
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The regulator IRQ helper requires caller to provide pointer to IRQ name
which is kept in memory by caller. All other data passed to the helper
in the regulator_irq_desc structure is copied. This can cause some
confusion and unnecessary complexity.

Make the regulator_irq_helper() to copy also the provided IRQ name
information so caller can discard the name after the call to
regulator_irq_helper() completes.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
 drivers/regulator/irq_helpers.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/irq_helpers.c b/drivers/regulator/irq_helper=
s.c
index fe7ae0f3f46a..5ab1a0befe12 100644
--- a/drivers/regulator/irq_helpers.c
+++ b/drivers/regulator/irq_helpers.c
@@ -352,6 +352,9 @@ void *regulator_irq_helper(struct device *dev,
=20
 	h->irq =3D irq;
 	h->desc =3D *d;
+	h->desc.name =3D devm_kstrdup(dev, d->name, GFP_KERNEL);
+	if (!h->desc.name)
+		return ERR_PTR(-ENOMEM);
=20
 	ret =3D init_rdev_state(dev, h, rdev, common_errs, per_rdev_errs,
 			      rdev_amount);

base-commit: 4cece764965020c22cff7665b18a012006359095
--=20
2.43.2


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--oJylSAUUxXPDKJ0i
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmYSTLMACgkQeFA3/03a
ocXgbQf/erNMcArbV1lK+KEl03lvK0UiZMesY3WPYt150EjHF/RHUTKDeSx98wH5
7HPw1RbV2fQ/Kgx3VbVr2khfYlY8XLTCv89pCAeiSxrPgUd5MadQlYGJf2FLX227
WWk+6d93/sndShwYGyY0OSvalgxcNSUk6Umuk4DF8LCGc3Gw0e+TszWe4TiB8nn0
CMPoZMHiaGoqB3fpha9/XmFdKKTS6hbdu6K6Dk+3QPS2NrGoByq+FWB3xBrUlWZe
dVRUMbUDLVJCWm98W6zNqxehxP7o/jXnlt9dbU0ZnePUKbnvvRYMH8HRjVvP4OFP
27atepDUrBy/G6ozY2Dn26oX558BZA==
=sA4R
-----END PGP SIGNATURE-----

--oJylSAUUxXPDKJ0i--