Received-SPF: pass (google.com: domain of linux-kernel+bounces-134254-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240403142420.2042498-1-chao@kernel.org> <CAHJ8P3LdZXLc2rqeYjvymgYHr2+YLuJ0sLG9DdsJZmwO7deuhw@mail.gmail.com>
 <6a50a23e-8975-43cb-9496-38b6a083c703@kernel.org>
In-Reply-To: <6a50a23e-8975-43cb-9496-38b6a083c703@kernel.org>
From: Zhiguo Niu <niuzhiguo84@gmail.com>
Date: Sun, 7 Apr 2024 16:29:52 +0800
Message-ID: <CAHJ8P3+YPhH9BsQumZFVM=bc_7zb=4oZH85+qG7bA4XJ3vLsFw@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to relocate check condition in f2fs_fallocate()
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, 
	linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 7, 2024 at 3:29=E2=80=AFPM Chao Yu <chao@kernel.org> wrote:
>
> On 2024/4/7 10:11, Zhiguo Niu wrote:
> > On Wed, Apr 3, 2024 at 10:26=E2=80=AFPM Chao Yu <chao@kernel.org> wrote=
:
> >>
> >> compress and pinfile flag should be checked after inode lock held to
> >> avoid race condition, fix it.
> >>
> >> Fixes: 4c8ff7095bef ("f2fs: support data compression")
> >> Fixes: 5fed0be8583f ("f2fs: do not allow partial truncation on pinned =
file")
> >> Signed-off-by: Chao Yu <chao@kernel.org>
> >> ---
> >>   fs/f2fs/file.c | 20 +++++++++++---------
> >>   1 file changed, 11 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> >> index 148bfe3effdf..83a807e25e31 100644
> >> --- a/fs/f2fs/file.c
> >> +++ b/fs/f2fs/file.c
> >> @@ -1820,15 +1820,6 @@ static long f2fs_fallocate(struct file *file, i=
nt mode,
> >>                  (mode & (FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_=
RANGE)))
> >>                  return -EOPNOTSUPP;
> >>
> >> -       /*
> >> -        * Pinned file should not support partial truncation since the=
 block
> >> -        * can be used by applications.
> >> -        */
> >> -       if ((f2fs_compressed_file(inode) || f2fs_is_pinned_file(inode)=
) &&
> >> -               (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RAN=
GE |
> >> -                       FALLOC_FL_ZERO_RANGE | FALLOC_FL_INSERT_RANGE)=
))
> >> -               return -EOPNOTSUPP;
> >> -
> >>          if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |
> >>                          FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RAN=
GE |
> >>                          FALLOC_FL_INSERT_RANGE))
> >> @@ -1836,6 +1827,17 @@ static long f2fs_fallocate(struct file *file, i=
nt mode,
> >>
> >>          inode_lock(inode);
> >>
> >> +       /*
> >> +        * Pinned file should not support partial truncation since the=
 block
> >> +        * can be used by applications.
> >> +        */
> >> +       if ((f2fs_compressed_file(inode) || f2fs_is_pinned_file(inode)=
) &&
> >> +               (mode & (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RAN=
GE |
> >> +                       FALLOC_FL_ZERO_RANGE | FALLOC_FL_INSERT_RANGE)=
)) {
> >> +               ret =3D -EOPNOTSUPP;
> >> +               goto out;
> >> +       }
> >> +
> > Dear Chao,
> > I see  the judgment code "if(!f2fs_compressed_file(inode))" also is
> > before inode_lock in functions
> > f2fs_ioc_decompress_file/f2fs_ioc_compress_file/f2fs_reserve_compress_b=
locks/f2fs_release_compress_blocks.
> > should they are changed together?
>
> Zhiguo,
>
> Thanks for noticing that, I've submitted separated patches for fixing
> because those bugs were introduced by separated commits.
>
> Thanks,
Dear Chao,
You're welcome^^

>
> > thanks=EF=BC=81
> >>          ret =3D file_modified(file);
> >>          if (ret)
> >>                  goto out;
> >> --
> >> 2.40.1
> >>
> >>
> >>
> >> _______________________________________________
> >> Linux-f2fs-devel mailing list
> >> Linux-f2fs-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel