Received-SPF: pass (google.com: domain of linux-kernel+bounces-134271-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH v2 2/3] hugetlb: Convert hugetlb_no_page() to use struct
 vm_fault
From: Muchun Song <muchun.song@linux.dev>
In-Reply-To: <CAOzc2pyOusTc2xj2qF9MN8YeZp0dcbsrtPr96QhmJOJ+hX+CLw@mail.gmail.com>
Date: Sun, 7 Apr 2024 16:59:13 +0800
Cc: Oscar Salvador <osalvador@suse.de>,
 Linux-MM <linux-mm@kvack.org>,
 LKML <linux-kernel@vger.kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Matthew Wilcox (Oracle)" <willy@infradead.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <73DFA2EE-0929-4801-9C7C-A393F7796CE8@linux.dev>
References: <20240401202651.31440-1-vishal.moola@gmail.com>
 <20240401202651.31440-3-vishal.moola@gmail.com>
 <Zg6iG8cxpopXuFCo@localhost.localdomain>
 <CAOzc2pyOusTc2xj2qF9MN8YeZp0dcbsrtPr96QhmJOJ+hX+CLw@mail.gmail.com>
To: Vishal Moola <vishal.moola@gmail.com>


> On Apr 5, 2024, at 03:58, Vishal Moola <vishal.moola@gmail.com> wrote:
>=20
> On Thu, Apr 4, 2024 at 5:49=E2=80=AFAM Oscar Salvador =
<osalvador@suse.de> wrote:
>>=20
>> On Mon, Apr 01, 2024 at 01:26:50PM -0700, Vishal Moola (Oracle) =
wrote:
>>> hugetlb_no_page() can use the struct vm_fault passed in from
>>> hugetlb_fault(). This alleviates the stack by consolidating 7
>>> variables into a single struct.
>>>=20
>>> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
>>> ---
>>> mm/hugetlb.c | 59 =
++++++++++++++++++++++++++--------------------------
>>> 1 file changed, 29 insertions(+), 30 deletions(-)
>>>=20
>>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>>> index 360b82374a89..aca2f11b4138 100644
>>> --- a/mm/hugetlb.c
>>> +++ b/mm/hugetlb.c
>>> @@ -6189,9 +6189,7 @@ static bool hugetlb_pte_stable(struct hstate =
*h, struct mm_struct *mm,
>>>=20
>>> static vm_fault_t hugetlb_no_page(struct mm_struct *mm,
>>>                      struct vm_area_struct *vma,
>>> -                     struct address_space *mapping, pgoff_t idx,
>>> -                     unsigned long address, pte_t *ptep,
>>> -                     pte_t old_pte, unsigned int flags,
>>> +                     struct address_space *mapping,
>>=20
>> AFAICS all this can be self-contained in vm_fault struct.
>> vmf->vma->mm and vmf->vma.
>> I mean, if we want to convert this interface, why not going all the =
way?
>>=20
>> Looks a bit odd some fields yes while some others remain.
>>=20
>> Or am I missing something?
>=20
> Mainly just minimizing code churn, we would either unnecessarily
> change multiple lines using vma or have to declare the variables
> again anyways (or have extra churn I didn't like).

I don't think adding some variables is a problem. I suppose the compiler
could do some optimization for us. So I think it is better to pass
only one argument vmf to hugetlb_no_page(). Otherwise, LGTM.

Muchun,
Thanks.