Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp786025lqe; Sun, 7 Apr 2024 04:03:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUtpTvlVxuYNJ9KmOUniYWflRnVSdiKao3b8LynWD4ajnrbWSJ5tL/Km65BsGv5chj8dPDqNT68MuzWbAbpp2D5oIVTdTaI7kPBPjv6Mg== X-Google-Smtp-Source: AGHT+IG4GNSo4xu+Kc5BAfPWOqFlrAHWhqWaE6x5XCVo+jEmFUPvsZxEjD10e7+RCMP51S8CJtmE X-Received: by 2002:a17:90b:495:b0:2a5:242:6761 with SMTP id bh21-20020a17090b049500b002a502426761mr628153pjb.23.1712487806160; Sun, 07 Apr 2024 04:03:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712487806; cv=pass; d=google.com; s=arc-20160816; b=rsWrqKiUFXRVDFLohLZsbbSZfedERaj8s0kGnR6W5462oFcaE6+Plsm16oVcP6tp04 0sLaPf9QT07epQUMpKqhQYn6t/gpRm+OSt+LxshoBN1u0mluBV4DqdALA5zISb9qZlJD Mmeq6gENLe85FUy9XPiHRuWW1kMS1GOG5Gc+Z8xA/y8ChZvwiEag5QNOTVNRt7DwJFnV umfBNplXs5zm+s/OUvee1+q2DMjr54Ss9ihyYO5zn4eTNziY7hs4Sdb4c9Tb95Fjd8Ip eX5/jbwlWYdEmn/iM0IDpRcV3QyfulU8q+bkZp2JVIfvRHYVuaxVF3XszO1xaMyhOOSr ONtg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=5nwRbexcYOPp30ekgwuJ6VgzDw5dRFusyO6fanHsflY=; fh=JLC0U6KmByfZMVsEYad/2gCf6oxbT/+Mxzv/LCVvCT4=; b=jepo69YhgxizBNYGaY4IFvGO3pElk1lPfD3JM9WeP9E6/1LgtNoex2QQ7LQEj5JEQC lHJvEmhAGxB1ysdsWBWguksk1grECyJfge63z45QEqZqcHMljuGwfAYQ24lpKnK++mDJ IsG7f5vCO9DHc13QLlqAbY4XMaUyGEKFLXnhGBq8WKEGnCsmkqZE8ZRTYRSYthvBiRM4 /If/w4DD9BX7WfXeDQEOpNKD+MuKtwC+Mgj6GVEA4lzq5eRnXukQGaqq/J/qQI6vkRSc waEupLVPg9HH3gf1KbaYZWPuRfPcHXOtdXnPLppty+PtstSPwnUsY0o6hEGn9PyfPI89 xx+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ecy07tw7; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-134347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x19-20020a17090ab01300b002a290022891si4905183pjq.162.2024.04.07.04.03.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 04:03:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ecy07tw7; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-134347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DB4C4B216F7 for ; Sun, 7 Apr 2024 11:03:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC1F021101; Sun, 7 Apr 2024 11:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ecy07tw7" Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B3F18C1F; Sun, 7 Apr 2024 11:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712487788; cv=none; b=RvOl84hVzFcZezNo/tvMVYoDG7fGezpHxBKchWu6BJzKUujOxkIRs8KEYR4Kk02FNfnA1Kke9TQs9M+hi212XyeQQnvS3ZUYPZJ+P0Q53BvDhI4zIggZ5oRZFdABCB81FcQh5in5rczM9ssT0yleCvpFLRwr3lqundfjgSYw+TQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712487788; c=relaxed/simple; bh=2bnSJcE/EunYmSFZYekZyYXjQHtFS370sqqCcC7vL6Y=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AKG/Mtz8+sH92OKzRM61zcokSfllgjWhm0rf3sO9UjoOkX9PgKbPXYKJYwWLkMn2acIrIQqlhqzh84D08u7Qrok1ysX6xjx2GRI+XYbSmvKZrw5L2ye0LZjdNaK8a4V4yfze/3M8xkjYCAiPF01i+mpOseIz4OXP66nArMZ+tVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ecy07tw7; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-78d515ae606so119548585a.0; Sun, 07 Apr 2024 04:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712487786; x=1713092586; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5nwRbexcYOPp30ekgwuJ6VgzDw5dRFusyO6fanHsflY=; b=ecy07tw7AVEF0mjmcrakqx7/p1J6Gsg/zt8FW/T6A2nYxMvqDzldZgF3eyQ089KZRr WDdHI+DZrtyUej6HX6bF2hykZ7/dPaokjx1Ilhj/cBJuAgP3ejPiqG/JOy4sh1YSspUw GvB8rlYF3CJQ+DpcNd0BCcLVzOqwuzeBfSfHmSLFqVckaSKQ5+9EbD3AzsvW532CHszV lvJP3AVqGXvbcstv3XAZDbnDkriPJRsi2ysmDBztAPHuMF4KI9efTaTG2ApDX05YXw0f wX3Xv1LCOtGe0IxjFbmxg6OTamQmmeUR9jo/PhdeMxlklL3ylv+zZF0YI3JNHgEhNcJY EkuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712487786; x=1713092586; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nwRbexcYOPp30ekgwuJ6VgzDw5dRFusyO6fanHsflY=; b=hwxRJ4K0LjBPzRqX+HhlJcUSjcGlSA/iRwIl4jcRh2+WyWQk+FehPRRVLSpXiHaQf7 QwxOEpzLFOGgYDupEyQA17kfc9CedO9S3krNcA7S15W8LRlRatdrYdpVDPh16MJwrbww qC009b3MiU7RMpQ6433pizbfpSPKGCu4qicB5uAdfdBImRlJB1vc3GxL2MokhLW35MR0 Oq4tvfYB3RkNSkrDAPcKCK1nL8AZGxMlKxlDKtlSuIigDto3Dy8Q4/nPK6uUUr74KCAq 7fM2Wd4rkBZvwxQ42EvrcVMkfJi2CMOKKHb7eWCrQbvHPY6TEYv2C05+Y6QCMMXKc5/q ZGaA== X-Forwarded-Encrypted: i=1; AJvYcCUhtZAonl1vbanfv12r4fLVtN4MGgPcDQaiysU9Eug8DMG6geaqUK+W4VBH6QdFABj6XHHOBU6euK4NE31JUzyU7ZtEj/Idql45OuYovRrDzFUCI0fcAYly+Im5qZjl7J89Qj1jetwGDMkR4A== X-Gm-Message-State: AOJu0Yz578Arp00faq8znyd3yZtenocKTI6ZA7c7VwM+HZG3iWttMbFG rY4TLdun9b7h8Z9jEwzn6wpZlAR4kG37FaPtlOUSIh7hpSXVw587p1T09Nj2I1OhsQYR0MnGEZl E7p3ZWtPGQXdGsn/jfxWTtzuhIizcItIwFkc= X-Received: by 2002:a05:6214:b13:b0:699:1b89:178c with SMTP id u19-20020a0562140b1300b006991b89178cmr12331825qvj.2.1712487786390; Sun, 07 Apr 2024 04:03:06 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <000000000000107743061568319c@google.com> <20240406071130.GB538574@ZenIV> <20240407005056.GF538574@ZenIV> In-Reply-To: <20240407005056.GF538574@ZenIV> From: Amir Goldstein Date: Sun, 7 Apr 2024 14:02:54 +0300 Message-ID: Subject: Re: [syzbot] [kernfs?] possible deadlock in kernfs_fop_llseek To: Al Viro Cc: syzbot , brauner@kernel.org, gregkh@linuxfoundation.org, hch@lst.de, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, miklos@szeredi.hu, syzkaller-bugs@googlegroups.com, tj@kernel.org, valesini@yandex-team.ru, Hillf Danton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 7, 2024 at 3:51=E2=80=AFAM Al Viro wr= ote: > > On Sat, Apr 06, 2024 at 11:57:11AM +0300, Amir Goldstein wrote: > > On Sat, Apr 6, 2024 at 10:11=E2=80=AFAM Al Viro wrote: > > > > > > On Sat, Apr 06, 2024 at 12:05:04AM -0700, syzbot wrote: > > > > > > > commit: 3398bf34 kernfs: annotate different lockdep class f= or .. > > > > git tree: https://github.com/amir73il/linux/ vfs-fixes > > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3Dc5cda11= 2a8438056 > > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3D9a5b0ced8= b1bfb238b56 > > > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils f= or Debian) 2.40 > > > > > > > > Note: no patches were applied. > > > > > > > Looks like it fixes the problem: > > https://lore.kernel.org/lkml/000000000000a386f2061562ba6a@google.com/ > > > > Al, > > > > Are you ok with going with your solution? > > Do you want to pick it up through your tree? > > Or shall I post it and ask Christian or Greg to pick it up? > > Umm... I can grab it into #fixes. Cool. Also: #syz dup: possible deadlock in seq_read_iter (3) https://lore.kernel.org/linux-fsdevel/CAJfpegumD0gDXpZwy53pPu54ifOfW-tTBLni= LHep3sW2Z96MjQ@mail.gmail.com/ Thanks, Amir.