Received-SPF: pass (google.com: domain of linux-kernel+bounces-134500-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0bab8b6e-c7e8-47e3-a42c-c8798ba4b6fe@amd.com>
Date: Sun, 7 Apr 2024 09:19:44 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "x86@kernel.org" <x86@kernel.org>,
 "Avadhut.Naik@amd.com" <Avadhut.Naik@amd.com>,
 "John.Allen@amd.com" <John.Allen@amd.com>
Subject: Re: [PATCH v2 16/16] EDAC/mce_amd: Add support for FRU Text in MCA
To: "Luck, Tony" <tony.luck@intel.com>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-17-yazen.ghannam@amd.com>
 <SJ1PR11MB6083683CAEA79F935BFA1B31FC032@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <SJ1PR11MB6083683CAEA79F935BFA1B31FC032@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHVpbm9kSnM1UDFqTXo4bG5nUk1zWEoyK1RMT1MxZ0JIOStrTlpnYjlqR05U?=
 =?utf-8?B?RDVnNWd5cjZpc1MzVEVuZWpsdmtmV0V3YTFFLzZGZ05yN0Jac3JUbThYWDQv?=
 =?utf-8?B?c0xhZ3VLVjVIVUNyQ2JodDBwMHJtWnlXM2FMamsrVStqeGExcmk4NGhJTllk?=
 =?utf-8?B?azNyOXRDWG5GQTRMeFF4TXJHTVZUYUx2MzZJdkFtWlRYTTU3SUZJU3NIVzl6?=
 =?utf-8?B?MDJ2SGFOWTZUOGxEYlViS2Y3K3RGcXd0VlMxWVlYK0xXc2JZZ3ZVZFdZMGtt?=
 =?utf-8?B?K3dyaEZHaTZ0Ui8rUlBxYjlINkp4OWp0d1l0b2pORVVkY00yYjNqMzB1SGxz?=
 =?utf-8?B?LzIzN28rU3gwMVhrQzZnd2RQbXEzR0prNmlXaUltQnRjZi9VR2dXWllDS2dy?=
 =?utf-8?B?YVFBYVQzTXJWclhMWkJHKzVzM3prUE43QzNXS3d5dkFmUDlFRkJxODRIM0xJ?=
 =?utf-8?B?aHJlVTV6Vjl0cFd3WHhrWExWcGppQXI2bEZRaityYlIxVS9aY1JUUTBuY1M2?=
 =?utf-8?B?SmlyRFdVY1VFVFZLZExKbDBQRkEwUWc4MGR0c0FOTEw3VXF2dU83RC9Xbks1?=
 =?utf-8?B?L3JDMlpmSUQ0dzNZK21BVGNiTGp0cXpreUUrVkNueVJ0Rlh0Z0dVRnNSQ0hO?=
 =?utf-8?B?QXhDbnFtUmJUdklhSUljeENrQWpqa3oxTUt3OEFWYkQwZ09hZ0t5QVNqNmt5?=
 =?utf-8?B?bmtzWFNPOTVFRnRyd0dueWp4Q1poQ1gvZ2xkUHMvckVscEJHanhoWUFwZVI0?=
 =?utf-8?B?eUFWWlFhRFZRVExYc0FyN2lzMEJyeEdHMHY1dEZSdnlnay9md1E5alo4dUMr?=
 =?utf-8?B?T0F3SlE1VzBITGduRVdMZXhyeDFvR0ZmT2dxaHlFMzBzK3JRWkxOSkNqVGZY?=
 =?utf-8?B?RUZoaTUyOWppSXdoM01IWnFzbnlUQkQ1aGVUMmRSdG5QUVRRdno0WDc1OHRj?=
 =?utf-8?B?N3RveHVOT2ZkVThpVWNIT0N0ZWNjdW81TGtQckVVemYveDJHa0NFMFF0bUFE?=
 =?utf-8?B?blowZFhuRXBvOVVIRnRsbyt2cW93V2ROS3dVdERBMkU4Y1RydVBqbk81YStS?=
 =?utf-8?B?SldLTWpXUzlBQ3QxRHFOOE5WMUxOeE14N0txSE00aVZPUVNsZVF0TXZMV1BD?=
 =?utf-8?B?YTROV1VUaWorbW5taER6SFcvY3Y3L0V0eXJWWlNMSjBOQ2JwdXltZUNXTmxI?=
 =?utf-8?B?OFdNcVZuU1JUNU1zVzJoei85YWh3d20weWpUUUg0b09meXJUZXJMS0NydWZZ?=
 =?utf-8?B?L3NQV1haaUc2YVRnejhrZ0JmMHhRbFd4SGYrVWFGNFRlb21aODZ1amF6UklQ?=
 =?utf-8?B?Y0ZiZ0JWWmdoRGkzTWxiT1FNellaUHc5SGNBZlhYMEppbGw4cmtvbGMxS2I5?=
 =?utf-8?B?QTZuSng3MFBLd1YrL01LYWg0R2luQk5FMmhHQ256aEo3NVdXK0g4U2YvTWE2?=
 =?utf-8?B?ZkF4RFFwUENwMktzem4wdXlIckZTejgxUktnaHR0aFJUKzZKcldXSzBNbU41?=
 =?utf-8?B?N3MwTHF0eXUwTjF4M0FsZzgzKyt0c1ZzWEV1aEZ6bGFLQmhQcEZRUW5mc2V4?=
 =?utf-8?B?ekZtcWpMbXBLU3FOd3BLWFBJTFFkSnFSb0M4Tllkaytxb2w3MFJhQkFFWFBH?=
 =?utf-8?B?cCtOajF3N2dsUHNvS0gyQUNqWi91SXJ2VXhGRUpYckMxY3VCZG11OHY2QitM?=
 =?utf-8?B?NHJRVjZvaUdvdnVXcHdzaHZTeXFlSDdLZGljblcvVmt6dzhVUXQ4OEV5TlFy?=
 =?utf-8?B?aXdXVmhZQW05WTQ3UlFrK0Z6dmd0TnVRZzAxOGducmc5Wm5UcFpQNFRIeHJU?=
 =?utf-8?B?M0FsTFRWSnZwZmF1WlhVZnk3ZmdVa3FKZWVaYkl3SEtHWHYzRVhzZW5Jb3FI?=
 =?utf-8?B?WUdBZVZlcHJ1eUlFRXRjRUFIZ0xQTzRqcENZU3VQSHpPT0NtNWdlTlcxMzdS?=
 =?utf-8?B?ZWV4ZGlzYXVPM0E3dzUxb3krVnBlanZTS3l4K3RUWjhobWJsb3JKN05xK05B?=
 =?utf-8?B?QmM4QlpXTUEyQ0lZY2J1bW9nNFFYUVFvbE56NUM5eHM2czcwdC9VNXM0bHI4?=
 =?utf-8?B?MEoyZXVmVEpXd2U4RUtsM0cyVm9UOVNNTDhLZ2x2SFNhZEt2Qm9uSzFKZnBj?=
 =?utf-8?Q?yB3sCZcPz+Gyk5GEdTAHJY2fB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 434d3073-13c2-4477-7ec2-08dc57056604
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2024 13:19:47.9760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fvKA77wE3c0CV1CvZ6xcj28PRJ4pEuIv/UlVcfzDMfqY34V/7Ztm1FdljEYxjg+CNSXvgzMkianDqOCYnlTxtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6415


On 4/5/24 12:06, Luck, Tony wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
>> index aa27729f7899..a4d09dda5fae 100644
>> --- a/arch/x86/kernel/cpu/mce/core.c
>> +++ b/arch/x86/kernel/cpu/mce/core.c
>> @@ -207,6 +207,8 @@ static void __print_mce(struct mce_hw_err *err)
>>                        pr_cont("SYND2 %llx ", err->vi.amd.synd2);
>>                if (m->ipid)
>>                        pr_cont("IPID %llx ", m->ipid);
>> +             if (err->vi.amd.config)
> 
> This is in common code. If other vendors start adding their own stuff to the
> "vi" union you might incorrectly print this.  Add a vendor check before looking
> at values inside "m->vi".
>

Yes, agreed. Will do.

Thanks,
Yazen