Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp920763lqe; Sun, 7 Apr 2024 09:41:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUr/23Jv1JZYjjRY/jAxkeHHHkxPZf5gMXu19r4bsuIysI4BUbKUQ6Z4/6A9Iaa2T+q3W0GBzIX8p8vG6+fXNtUR2l+Upq2R3Q4ZXmI+A== X-Google-Smtp-Source: AGHT+IHnZ68LsVktLuBM785YGc2Q3N+ypO9vMFy/xiDSaeUKY06KbiOBl0eYoPoEGpJ/pRT6I+TQ X-Received: by 2002:a05:6a20:9f4e:b0:1a7:5bb9:777b with SMTP id ml14-20020a056a209f4e00b001a75bb9777bmr3415598pzb.43.1712508089590; Sun, 07 Apr 2024 09:41:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712508089; cv=pass; d=google.com; s=arc-20160816; b=hyD8oCl+QcBPNWGj+JYlltzl50urmcg8T0BpFTW0b6nZrLj21SoozHHY4A/E223eHg c2wjrjIRRAmgb014MEMHUAV6wdYN8VbcY6dQCXajeS2c9hxegXiUjWJxG1ILrbTmOc1w 4zU/EFa96gpA5LDjuk5sKxXH9ArE3XrQW3IlfdUXcDktjlIuuYzwJYPla47oAK7j5/zS ZmSd49lX/HVD4BAtJaoJxeuHU6YGcmOgj4MMplNLc56ab0K4w+LSvEykXO70jAyug5z7 QG/4DYkItYdskHGi3mGEWTJnA9Z3y1m4YEa5yUrVl5elIQoNp+P+Md/e6ztic4+X3kam 2KlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=1EYn8kfRF14/k8HdHhmznoxG/OyfGft3VhOXPe5tM8E=; fh=xg15+Dno9z7WmRMhDrTYVXz11Kra4jOESYNfBQfunAw=; b=QXZhBhxo29HsCOJkM0CpzlQ0ax/wp89OexdApcehct9tEjj5cn/l2HV+dXvBs44Pkf uSaHgHzZlB8UY3tWh0KhtcHmqe0NbU/hlvHbPDANdct3t2FiiLeSPtSzRJsQ+MX8bwU4 HODRTZ5vZdwyCmqhJIekJzeCWnb+LB0nymVCR+daHad8VWyuLz4SRA6jId0Y7ApRRyBO PUvwPp8Z3DvvmlI/L9EmnUtzW9K7sSQKAnA9BiovdMywxk9eZ/34AHnexsam3hhfWmck PFK6/TGZj5ymJYsT/jTWkMretJWKzCzhWFBieYQ5as/KK2UK9tXkA6h1no7wQ5JQJHka Z5BA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kATGixdl; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 8-20020a631948000000b005ee3cfc3620si4791400pgz.670.2024.04.07.09.41.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 09:41:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kATGixdl; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D41ABB21D36 for ; Sun, 7 Apr 2024 16:40:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E51D23FBBB; Sun, 7 Apr 2024 16:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kATGixdl" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071BB3FB90; Sun, 7 Apr 2024 16:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712507958; cv=none; b=Woi1rt4gsRDX2+AfhKq72K1afb4bVq9Gy6Z79mbz6hkid+BXtmQ+LjQ4XNmvkVzAYYz364xRRRluT5oPwIwveUUPbZQDAa8OIkyWqdXzueo5t48ZisStV0kU5O67B5kCs5mz7g9ThoZyYsypTzK/vcL2IA3y1zGSQdpxl7ZUN2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712507958; c=relaxed/simple; bh=3EnZEArLHaY7GVMqTk9kRxGVqFNkiaEhhfxqp5dYqxc=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=ba52lbZuPKsKMDHRZ1ihIgR/iyMa5CXbUJI7gy7BHkYIfYDwhOpmRv4mt9uQGI5to4dD3vqopQchYOOXDCL7nx5yekmzRVZ4Aw+0JpmcvV6Pc8WZK0z3iHdvVZUFxHDcVpCS+tHR2zJNMjCZaOCtODn2eUEEQ0zWUg6K13RDckA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kATGixdl; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18B6DC433C7; Sun, 7 Apr 2024 16:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712507957; bh=3EnZEArLHaY7GVMqTk9kRxGVqFNkiaEhhfxqp5dYqxc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=kATGixdldVHBnmMIcZ5RfUahlv9GUuLEZgE+fiqXwa3ToOQ3YR1uDmNYkDsyn1rQG meQT+1J1UuNgcJVNQgmaKhs4hDxt40Vj7epW+COy9NztVDsV7XMC/JMO57wIJ0U9vY RS++a7x7gy2aUeJv4GgbL+79xkz0CNOo1Hc7G+onSfEGcagA0eUIDoZ2yiFQ+UAZZk K1hRyD43dqTGx7lpIBodF+/W7zLNG/wyKtLq4cs1YZ7GGJAPlzJtOseItIJH3IM+CE LuNlpqkhy6v0p+RGLQkLV+vjCjmB96IezpyX5bTzhtL/TTP+DJC9nZ0aN9eKuT7905 uqL9i8Jw1gm+g== From: Vinod Koul To: Eugeniy.Paltsev@synopsys.com, dmaengine@vger.kernel.org, Joao Pinto Cc: Martin.McKenny@synopsys.com, linux-kernel@vger.kernel.org In-Reply-To: <1711536564-12919-1-git-send-email-jpinto@synopsys.com> References: <1711536564-12919-1-git-send-email-jpinto@synopsys.com> Subject: Re: [PATCH RESEND] Avoid hw_desc array overrun in dw-axi-dmac Message-Id: <171250795567.435322.8170668108281183858.b4-ty@kernel.org> Date: Sun, 07 Apr 2024 22:09:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 On Wed, 27 Mar 2024 10:49:24 +0000, Joao Pinto wrote: > I have a use case where nr_buffers = 3 and in which each descriptor is composed by 3 > segments, resulting in the DMA channel descs_allocated to be 9. Since axi_desc_put() > handles the hw_desc considering the descs_allocated, this scenario would result in a > kernel panic (hw_desc array will be overrun). > > To fix this, the proposal is to add a new member to the axi_dma_desc structure, > where we keep the number of allocated hw_descs (axi_desc_alloc()) and use it in > axi_desc_put() to handle the hw_desc array correctly. > > [...] Applied, thanks! [1/1] Avoid hw_desc array overrun in dw-axi-dmac commit: 333e11bf47fa8d477db90e2900b1ed3c9ae9b697 Best regards, -- ~Vinod