Received-SPF: pass (google.com: domain of linux-kernel+bounces-134594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] intel_idle: Add RaptorLake support
From: =?utf-8?B?TMOhc3psw7MgUMOpdGVy?= <peter.laszlo2@gmail.com>
In-Reply-To: <7e2c1da24b48217045e8ad95b739ec96cdce5931.camel@intel.com>
Date: Sun, 7 Apr 2024 19:37:19 +0200
Cc: "smarter3@gmail.com" <smarter3@gmail.com>,
 "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
 "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>,
 "noltari@gmail.com" <noltari@gmail.com>,
 "lenb@kernel.org" <lenb@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "Bityutskiy, Artem" <artem.bityutskiy@intel.com>,
 "Kumar, Vinay" <vinay.kumar@intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BCBB0027-F0E9-42EE-BB43-D50091D9115F@gmail.com>
References: <20230119070205.90047-1-noltari@gmail.com>
 <c79904e98b86b68c87add286aa1487b3f81712b6.camel@intel.com>
 <c7d1eced-d77b-aca7-1422-6eefaf704f3e@gmail.com>
 <7e2c1da24b48217045e8ad95b739ec96cdce5931.camel@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>


> On 20 Aug 2023, at 11:20, Zhang, Rui <rui.zhang@intel.com> wrote:
>=20
> This is still work in progress because there are still some open
> questions that we cannot answer from our measurement, and the table is
> not finalized yet.
>=20
> thanks,
> rui
>=20
>=20

Hi,

I also just stumbled upon this patch series as I was wondering about the =
lack of specific support for RaptorLake in intel_idle. The AlderLake =
specific part of the intel_idle.c code mentions that "On AlderLake C1 =
has to be disabled if C1E is enabled, and vice versa =E2=80=A6. By =
default we enable C1E and disable C1 by marking it with...=E2=80=9D.   =
Without a patch on RaptorLake (which I assume works the same way) this =
cannot be controlled with the preferred_cstates kernel parameter. Also =
on my NUC 13 Pro i5-1340P the latency for C10 looks suspiciously large =
compared to the AlderLake cstates table.

grep . /sys/devices/system/cpu/cpu0/cpuidle/state*/desc
/sys/devices/system/cpu/cpu0/cpuidle/state0/desc:CPUIDLE CORE POLL IDLE
/sys/devices/system/cpu/cpu0/cpuidle/state1/desc:ACPI FFH MWAIT 0x0
/sys/devices/system/cpu/cpu0/cpuidle/state2/desc:ACPI FFH MWAIT 0x21
/sys/devices/system/cpu/cpu0/cpuidle/state3/desc:ACPI FFH MWAIT 0x60

grep . /sys/devices/system/cpu/cpu0/cpuidle/state*/latency
/sys/devices/system/cpu/cpu0/cpuidle/state0/latency:0
/sys/devices/system/cpu/cpu0/cpuidle/state1/latency:1
/sys/devices/system/cpu/cpu0/cpuidle/state2/latency:127
/sys/devices/system/cpu/cpu0/cpuidle/state3/latency:1048

Thanks,
Peter