Received-SPF: pass (google.com: domain of linux-kernel+bounces-134603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Laine Taffin Altman <alexanderaltman@me.com>
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v4] rust: init: remove impl Zeroable for Infallible
Date: Sun, 7 Apr 2024 10:55:49 -0700
Message-Id: <37A7EC35-7889-4378-A30C-126B1AD668C8@me.com>
References: <3ecba34f-95a2-4f18-9729-f9cb3a4366c0@proton.me>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
 Alex Gaynor <alex.gaynor@gmail.com>, rust-for-linux@vger.kernel.org,
 Wedson Almeida Filho <wedsonaf@gmail.com>,
 Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
 =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
 Andreas Hindborg <a.hindborg@samsung.com>,
 Alice Ryhl <aliceryhl@google.com>,
 Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
 lkml <linux-kernel@vger.kernel.org>, stable@vger.kernel.org
In-Reply-To: <3ecba34f-95a2-4f18-9729-f9cb3a4366c0@proton.me>
To: Benno Lossin <benno.lossin@proton.me>

On Apr 7, 2024, at 1:56=E2=80=AFAM, Benno Lossin <benno.lossin@proton.me> wr=
ote:
> =EF=BB=BFOn 04.04.24 19:28, Laine Taffin Altman wrote:
>>> On Apr 4, 2024, at 4:03=E2=80=AFAM, Miguel Ojeda <miguel.ojeda.sandonis@=
gmail.com> wrote:
>>>=20
>>> =EF=BB=BFOn Thu, Apr 4, 2024 at 11:01=E2=80=AFAM Benno Lossin <benno.los=
sin@proton.me> wrote:
>>>>=20
>>>> I don't see this commit in the kernel tree, what did you specify as
>>>> `--base` when running `git format`?
>>>=20
>>> Yeah, I don't have it either, but it seems to apply cleanly.
>>>=20
>>> Cheers,
>>> Miguel
>>=20
>> I ran `git format-patch origin/master --base=3Dorigin/master`.  I
>> can=E2=80=99t imagine how that could have resulted in a nonexistent commi=
t
>> hash?
>=20
> That heavily depends on what `origin/master` is. Is `origin` pointing to
> Torvald's git? In that case it would explain why we don't have that
> commit hash yet.
> Normally you should base your work on the tree listed in the `T:` entry
> of the subsystem in the MAINTAINERS file. In our case it is `rust-next`.
> But no worries, since it applies cleanly it should be fine for this
> patch. Just something to keep in mind if you submit any future patches.
>=20
> --
> Cheers,
> Benno

Ah, that makes sense!  Indeed it was pointing there.  I=E2=80=99ll remember f=
or next time!

Thanks,
Laine=