Received-SPF: pass (google.com: domain of linux-kernel+bounces-134626-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a3bdf335-48f4-4658-bdcf-52affb60b5af@intel.com>
Date: Sun, 7 Apr 2024 12:21:39 -0700
User-Agent: Mozilla Thunderbird
From: Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH v1 5/6] x86/resctrl: Abstract PQR_ASSOC from generic code
To: Peter Newman <peternewman@google.com>, Fenghua Yu <fenghua.yu@intel.com>,
	James Morse <james.morse@arm.com>
CC: Stephane Eranian <eranian@google.com>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, Juri
 Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt
	<rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, "Mel Gorman"
	<mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin
 Schneider <vschneid@redhat.com>, Uros Bizjak <ubizjak@gmail.com>, Mike
 Rapoport <rppt@kernel.org>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, Rick Edgecombe
	<rick.p.edgecombe@intel.com>, Xin Li <xin3.li@intel.com>, Babu Moger
	<babu.moger@amd.com>, Shaopeng Tan <tan.shaopeng@fujitsu.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@intel.com>, Jens Axboe
	<axboe@kernel.dk>, Christian Brauner <brauner@kernel.org>, Oleg Nesterov
	<oleg@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, Tycho Andersen
	<tandersen@netflix.com>, Nicholas Piggin <npiggin@gmail.com>, Beau Belgrave
	<beaub@linux.microsoft.com>, "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	<linux-kernel@vger.kernel.org>
References: <20240325172707.73966-1-peternewman@google.com>
 <20240325172707.73966-6-peternewman@google.com>
Content-Language: en-US
In-Reply-To: <20240325172707.73966-6-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGRQa3JjN1BWZzdwNjRaTDhEanZ2dC9mMTFoblNJYWxDRG1XbFpMY1JKVEQ2?=
 =?utf-8?B?SjBVR0J6VWFrTWNoRXBBaE1qTVpnMjVNOUtTOGxLcGVDNnlEdFdSKzhaYWRL?=
 =?utf-8?B?OVRPa2l6c0hoSmNRbXExVm00VHpJWGNIVmV6ZkdUbUJVRUNPUTZXTmdvTERh?=
 =?utf-8?B?YzJWeDFJOHNxd3BQNVpDdkhFNTljTHFKbHFXUy8zcXJUU3p4dU9UUmpmSExF?=
 =?utf-8?B?RHhhcmhBOTM2cGx5NkdjeDJ3bG1Rd2luc0VSbTFUYnR2dytwcWVySkVmQVFz?=
 =?utf-8?B?UEVhTDRncE9zT0JJUHRLYW5adXg3UFdGRTJvekg3UnBvZ0RZUGpCNHhoYU1Z?=
 =?utf-8?B?bFJTOFhuQkE4a2tXdVZybkQ0SjBLcUE3bWpuc29SN0hxREhMUXA1dzZlUE8z?=
 =?utf-8?B?blFZQVBWbm5QUUNYSmIxVm9OL2VmV25qNlJkZnN5ZVp1Ky9BNUxYcmRYaE1U?=
 =?utf-8?B?SVExbzErazhoTlNVekhFM3FCSG1uVW1aUXFKOUtVWnFYK1hLYjRKeFhyeHpQ?=
 =?utf-8?B?T3pHMXpka0VmY0xPV2JtandnMW9wckVFcCs5RVJsVnBEakwzVWxSR0I0bTFh?=
 =?utf-8?B?MFNCZW5EZXgrWkFWVzB5L1ZKMW1KTFdSeE9zc0pTenB5Y3lGSnJac2NXeXpu?=
 =?utf-8?B?N0lTR0w5ajdkZCsrT0NJKzRQZ3YvWHFtTklwRzNnZWx6ZXFOV0c4dG1TaGdJ?=
 =?utf-8?B?M1NZNURUS2JMMGlScWlNZVVMRWMxZUczNkgwNkxhR21hRURyTFZXRXd1TXdF?=
 =?utf-8?B?MkJXUkRIa1IyWjdxTzV5SVJYMWJSMFFicVhicVdpdHZPaHJnYVhtSEUxZlRH?=
 =?utf-8?B?bWQ0azZrRmVGeGtndFViSlBqQjhaM2R6Wm5QaGNPV0RWMUhzZDhrZnlHMS9G?=
 =?utf-8?B?TEN1L09qcXFaTWRtK0QrMldDZEJMa01KQzRIcEk3d0ptSmhSaWNRcFF2U0hP?=
 =?utf-8?B?ZUc5M2VtdzZiUlJiMkhyVWQrNXdZcVE0dXpDNWZCdFRFbnIrYmJwRXV2MmNn?=
 =?utf-8?B?dlRFejRtNmo0NVF6ZFhLaXEvWHNlNmxmVDZNTkdTVkJwOE54MFB3VEVPMHZQ?=
 =?utf-8?B?VDJtWGNHdHpWVVlHT0wvMklDMVFXLzh3d2ZIYStJaFpCc3pQS1JKeWN1Z2pm?=
 =?utf-8?B?bi9HZDhkcWd5YjN6eGpXbGJMb3BENU1UQkQvbDN4V3RHdXpUZVBOOW5mZzg5?=
 =?utf-8?B?aVFSTUdrbVZITTcyR3lMa3JxbDFjdTNjaUl3UHVsUHJhZ1c5Z1ZhWW14UEw4?=
 =?utf-8?B?Ukp3RWN1T00rb21MV3F1Z2xtZ01pZWdpOWtyczZKM2dNa3lKTy9Rb2ZNTFlE?=
 =?utf-8?B?NG5GTHhpWGpPZ0lOMkprL2RoZXYwUVRZL3lFa041U2U5L2tKOVFzNzBlb1kz?=
 =?utf-8?B?b3BvU0s5a3V6Qkk0MElnWm4xTVkvS05hL0N6RFpQV244ZVJSMEptQUtkWVVJ?=
 =?utf-8?B?VTIvdjJreVBsUEI2S0l1TVFWT2V5dzJVNmVqQjBxWmkzd1lRWGNaZ3ludVNy?=
 =?utf-8?B?ZGtPcEcrU3pEOTVJZ0o1S05lRTJWQkEvNUwxb2xCeStuU1VmaGtTZnVxT2Nn?=
 =?utf-8?B?NEMrUm8vYVRkbWpKN2hVUUd5K1lweEMvNnRicWt4TzhFUTU2cDM1NkQwTytl?=
 =?utf-8?B?L2gyWkpQY3BWWklmNTJ2QlJEU3kzMC9XbUlNVEhGZ2UzcnpORzJuYmU3Zy9p?=
 =?utf-8?B?Q25vb3NLNE1nZHRyVUlCbGowYVNqM2tQVnMrSXhXNU5LNEpyMTh0ZFBUeG10?=
 =?utf-8?B?UHpQclQ2TVBlOE8xR3oxZXVVYmpLNDJCMUNIWitrL3QybzJYS0x3V255d0ZJ?=
 =?utf-8?B?YVJ2VmhuMG96cXZ5OXNYbStHVTlHT2RlZkRXeE55WkRxNzQ4cjFlM3B5cmxk?=
 =?utf-8?B?dzhMVFhLc05BWEJVUEtUTEY1OXU0L1dHZnEvbVhlZTAvTjVXQUt0UlF3d2d6?=
 =?utf-8?B?OXV2K1YxNVN4Rkdvb0M0Vk5kYTBoVEQ2TVdrNHpzZ3JJNmwvbE9SWXUrYVYw?=
 =?utf-8?B?Sm85N1RnV2RpWnR0bE5GNlFrZHQvazFmb3MxbEdYeDFZM0cyWllBdWNWRUt3?=
 =?utf-8?B?ZEpJU0FLZ0ZTQ0t4djZxVDJBOUZVSjZ1R0k1VDJUQ1NLT29NQkR4V1h2djFr?=
 =?utf-8?B?REpsREE5TVBUZnVIdzhIK250c1U5R01MUWx6bkw2eGlLVERBZVZKWXRVQmRZ?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 993e14fa-095b-45d7-f3a9-08dc5737f518
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2024 19:21:42.7728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KrnGvcTZRv8OWYptOc12oSeG4L5/u+JwouxxsCYIUF7dGjFDehtEWydYDKp5YUzok3u/WFsJ9MYWMS901BWIsEyYNz/TFgXEMAYwpxya6Bw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4743
X-OriginatorOrg: intel.com

Hi Peter,

On 3/25/2024 10:27 AM, Peter Newman wrote:
> While CLOSID and RMID originated in RDT, the concept applies to other
> architectures, as it's standard to write allocation and monitoring IDs
> into per-CPU registers.
> 
>  - Rename resctrl_pqr_state and pqr_state to be more
>    architecturally-neutral.
> 
>  - Introduce resctrl_arch_update_cpu() to replace the explicit write to
>    MSR_IA32_PQR_ASSOC in __resctrl_sched_in(). In the case of MPAM,
>    PARTID[_I,D] and PMG are a simple function of closid, rmid, and an
>    internal global.
> 
>  - Update terminology containing explicit references to the PQR_ASSOC
>    register.
> 
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---
>  arch/x86/kernel/cpu/resctrl/core.c        | 11 ++++++++---
>  arch/x86/kernel/cpu/resctrl/internal.h    |  6 +++---
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c |  4 ++--
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 18 +++++++++---------
>  include/linux/resctrl.h                   | 11 +++++++++++
>  5 files changed, 33 insertions(+), 17 deletions(-)

Looks like __rdtgroup_move_task() still refers to the PQR MSR in comments
and it eventually ends up in fs code.

Also found in arch/x86/kernel/process_{32,64}.c:
	/* Load the Intel cache allocation PQR MSR. */

Reinette