Received-SPF: pass (google.com: domain of linux-kernel+bounces-134537-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7a8bc242-d41e-425b-9a62-36835aca7721@infradead.org>
Date: Sun, 7 Apr 2024 08:32:49 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 1/4] include/linux/suspend.h: Only show pm_pr_dbg
 messages at suspend/resume
To: xiongxin <xiongxin@kylinos.cn>, mario.limonciello@amd.com,
 Rafael Wysocki <rafael@kernel.org>, hdegoede@redhat.com,
 linus.walleij@linaro.org
Cc: Basavaraj.Natikar@amd.com, Shyam-sundar.S-k@amd.com,
 linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
 linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
 linux-gpio@vger.kernel.org
References: <20230602073025.22884-1-mario.limonciello@amd.com>
 <20230602073025.22884-1-mario.limonciello@amd.com>
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230602073025.22884-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/7/24 5:49 AM, xiongxin wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> All uses in the kernel are currently already oriented around
> suspend/resume. As some other parts of the kernel may also use these
> messages in functions that could also be used outside of
> suspend/resume, only enable in suspend/resume path.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v3->v4:
>  * add back do/while as it wasn't pointless.  It fixes a warning.
> ---
>  include/linux/suspend.h | 8 +++++---
>  kernel/power/main.c     | 6 ++++++
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index 1a0426e6761c..74f406c53ac0 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -555,6 +555,7 @@ static inline void unlock_system_sleep(unsigned int flags) {}
>  #ifdef CONFIG_PM_SLEEP_DEBUG
>  extern bool pm_print_times_enabled;
>  extern bool pm_debug_messages_on;
> +extern bool pm_debug_messages_should_print(void);
>  static inline int pm_dyn_debug_messages_on(void)
>  {
>  #ifdef CONFIG_DYNAMIC_DEBUG
> @@ -568,14 +569,14 @@ static inline int pm_dyn_debug_messages_on(void)
>  #endif
>  #define __pm_pr_dbg(fmt, ...)					\
>  	do {							\
> -		if (pm_debug_messages_on)			\
> +		if (pm_debug_messages_should_print())		\
>  			printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__);	\
>  		else if (pm_dyn_debug_messages_on())		\
>  			pr_debug(fmt, ##__VA_ARGS__);	\
>  	} while (0)
>  #define __pm_deferred_pr_dbg(fmt, ...)				\
>  	do {							\
> -		if (pm_debug_messages_on)			\
> +		if (pm_debug_messages_should_print())		\
>  			printk_deferred(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__);	\
>  	} while (0)
>  #else
> @@ -593,7 +594,8 @@ static inline int pm_dyn_debug_messages_on(void)
>  /**
>   * pm_pr_dbg - print pm sleep debug messages
>   *
> - * If pm_debug_messages_on is enabled, print message.
> + * If pm_debug_messages_on is enabled and the system is entering/leaving
> + *      suspend, print message.
>   * If pm_debug_messages_on is disabled and CONFIG_DYNAMIC_DEBUG is enabled,
>   *	print message only from instances explicitly enabled on dynamic debug's
>   *	control.
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 3113ec2f1db4..daa535012e51 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -556,6 +556,12 @@ power_attr_ro(pm_wakeup_irq);
>  
>  bool pm_debug_messages_on __read_mostly;
>  
> +bool pm_debug_messages_should_print(void)
> +{
> +	return pm_debug_messages_on && pm_suspend_target_state != PM_SUSPEND_ON;
> 
>> hibernate processes also mostly use the pm_pr_dbg() function, which
>> results in hibernate processes only being able to output such logs
>> through dynamic debug, which is unfriendly to kernels without
>> CONFIG_DYNAMIC_DEBUG configuration.

This part of the patch doesn't look so good. ^^^^^^^^^^^^^^^^^^^^

> 
> +}
> +EXPORT_SYMBOL_GPL(pm_debug_messages_should_print);
> +
>  static ssize_t pm_debug_messages_show(struct kobject *kobj,
>  				      struct kobj_attribute *attr, char *buf)
>  {
> 

-- 
#Randy