Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1048023lqe; Sun, 7 Apr 2024 16:54:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWh/GgDohFtVrTlIXD00qhxkEH75bEYkq6i8h7zEFStlDqrmH5szy3+xUZdph/UiQMXJaOrUH1xGBNRAExwSRcrt/y80x8LWjWdtJ/ccQ== X-Google-Smtp-Source: AGHT+IGFPYsS8VLeM+ycj0gOvrNBv2/LkcIhQ8cI37vWx8w9oMFjsqWqLoiVs0gbsxfjH2NxHnO5 X-Received: by 2002:a17:902:d2c2:b0:1e3:cd26:cf16 with SMTP id n2-20020a170902d2c200b001e3cd26cf16mr9130900plc.51.1712534048352; Sun, 07 Apr 2024 16:54:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712534048; cv=pass; d=google.com; s=arc-20160816; b=S+KXYbmzSwX1PO7SnWwz7runXZBOV52lmEcNvKB1184uv+tiHNOKQ20PmU8E55EeDr iUveAaB6lf2K0mcY/I/Wxcd4lqX5GpUUc6NIiI3fXEukkvEV2QxPVMz0xBhVZmaiIYW4 z17oW0vVdSPbp2pojVuSpju00bEY6TerkCsEjF2yo5aJkCGbdd57XHp7c4/8ISwA9/Hs VZZI8CuNmQe5QAsMzwuJyp593vuPc+0s3PzyL2IJqNvKN9spTkYKCBvQNkdoUJj2ZKvS kHcveh3IJgcj7PWmEFEZL26clG7UuiDCt2V3YtHt/ed7Pzf4mCaNtUl+1cT5sFjKXJ0n bi8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CyQ2yO/2Cg2rLLDVyjeF3Te6D19wgFqq2rU+o/kohiM=; fh=i2y8sJxUSoyRBVHnbVjNxLSYQoFr48qAE2JctYzdi14=; b=STLTJdMNWh2AMpxDG3ZrRPaODPYtZWtk6SmMEiAkAxYEM3mHx7/RN3pPhAZS6CkvMH u9GjwNMP2bjSjjTuTYDcgTvHBMYZFgxYQirZXnRqRqka7+zRyZJ7Fyzf6iYheYnrKLGX cDqnzltyvsdPqbcAx/hQAEBmTsTTc18UcKE6xk4A8pTmm9KFN5rVmWnp4c+jXurV+HnH pFr+uC8hkX2RqLmEeG2CmOFkxbATpb9Ki+nL4IpP1Ly71Z2HDyM8NrnzOtId0wG3jZCF BrHxYDeaT92qicnbOI+u0W9bsYsyCrt4Ji1a6sk19LLMQy9rMbRjVlHE/p56mTCKPnck 4rgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X5mtmvi8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134669-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134669-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w1-20020a170902e88100b001e3e0286372si2817241plg.69.2024.04.07.16.54.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 16:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134669-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X5mtmvi8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134669-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134669-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 38DE828186F for ; Sun, 7 Apr 2024 23:47:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0F1C45946; Sun, 7 Apr 2024 23:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X5mtmvi8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADDD446D3; Sun, 7 Apr 2024 23:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712533611; cv=none; b=ZLGNq33/4BZeWeBHldwi1G+C1x32yaqSsRiTD02VDqJUxTggazGYU4dGL7mIwk83RU2i7O8cb/tJBz7aRKoQnyErk3P1yHz20jn/K6XqAgGBavUdKpjwReMoWPQKlZKv3kE0vxjyF3msnpR8nbAbOfPhUZnk/LFYdv5xvsIemEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712533611; c=relaxed/simple; bh=P+OunsRxmPow7mnjnbhNCSULHtX+QKprpv8k/fKlJkc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mrMFUPh3wJztM42WZxq8eweB3qJeZoOzENAirzCqTpKRGW8PBqKTrpQ7O0LnNW5MASV3CMGCwiRPXpNvILrgkyO9E4lcjkuNlZQ5msHHzQr/PFD64QhrIczWzOggwaJeJeUlF4AovfWaKDXr3HHsR7U2ageQZ7cHpTlXxWPea9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X5mtmvi8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CEDCC433F1; Sun, 7 Apr 2024 23:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712533610; bh=P+OunsRxmPow7mnjnbhNCSULHtX+QKprpv8k/fKlJkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X5mtmvi8tSG2KQEhFYa0jlYBE8HknG/5hgWPYQWYaPPkcXzwCnpAVuSUH2ZQOTqKA fT7fy/cCBaVuucVOTXNIHDytoNtfVUDlTPko5AK3hinSxomPzxr6L23V3Uj9/eLPFF OKSqPK8ptsShZden9yMexeHBaDUlqih0pwTtFgMLmGFXpbbhfyK7YwHQEiWazITIAU mOn1UfMgeIaX/a+lzT/6Al3J6Wkz+N/8xDL/HjJq1JD+U/5LeZ+TaXQLqt7GyGAcfJ wUp6OqYAZYfVuxZ05M6CtWQj1cS/vWYTpKzKWMScxZt9cpRXoAjm4l+P4J4fdV6pf6 kCk7omAoS/Wrw== Date: Sun, 7 Apr 2024 19:46:50 -0400 From: Sasha Levin To: Kees Cook Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sam Ravnborg , davem@davemloft.net, andreas@gaisler.com, masahiroy@kernel.org, nicolas@fjasle.eu, guoren@kernel.org, rmk+kernel@armlinux.org.uk, sparclinux@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.8 69/98] sparc: vdso: Disable UBSAN instrumentation Message-ID: References: <20240329123919.3087149-1-sashal@kernel.org> <20240329123919.3087149-69-sashal@kernel.org> <202403291904.05D45FDD2@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202403291904.05D45FDD2@keescook> On Fri, Mar 29, 2024 at 07:05:37PM -0700, Kees Cook wrote: >On Fri, Mar 29, 2024 at 08:37:40AM -0400, Sasha Levin wrote: >> From: Kees Cook >> >> [ Upstream commit d4be85d068b4418c341f79b654399f7f0891069a ] >> >> The UBSAN instrumentation cannot work in the vDSO since it is executing >> in userspace, so disable it in the Makefile. Fixes the build failures >> such as: >> >> arch/sparc/vdso/vclock_gettime.c:217: undefined reference to `__ubsan_handle_shift_out_of_bounds' >> >> Acked-by: Sam Ravnborg >> Link: https://lore.kernel.org/all/20240224073617.GA2959352@ravnborg.org >> Signed-off-by: Kees Cook >> Signed-off-by: Sasha Levin > >This is harmless to backport, but doesn't do anything. (The UBSAN >changes needing this are only in Linus's tree.) I'll drop this and the rest of the ubsan commits you've pointed out, thanks! -- Thanks, Sasha