Received-SPF: pass (google.com: domain of linux-kernel+bounces-134682-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <62202a1b-0bb8-42f5-8956-cd8ff82b4ff0@linux.alibaba.com>
Date: Mon, 8 Apr 2024 08:30:37 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 06/10] perf/dwc_pcie: Avoid placing cpumask on the
 stack
To: Dawei Li <dawei.li@shingroup.cn>, will@kernel.org, mark.rutland@arm.com,
 yury.norov@gmail.com, linux@rasmusvillemoes.dk
Cc: renyu.zj@linux.alibaba.com, yangyicong@hisilicon.com,
 jonathan.cameron@huawei.com, andersson@kernel.org, konrad.dybcio@linaro.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-arm-msm@vger.kernel.org
References: <20240403155950.2068109-1-dawei.li@shingroup.cn>
 <20240403155950.2068109-7-dawei.li@shingroup.cn>
Content-Language: en-US
From: Shuai Xue <xueshuai@linux.alibaba.com>
In-Reply-To: <20240403155950.2068109-7-dawei.li@shingroup.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2024/4/3 23:59, Dawei Li wrote:
> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
> 
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
> 
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>

Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>

Thank you.

Shuai