Received-SPF: pass (google.com: domain of linux-kernel+bounces-134742-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: shawnguo@kernel.org,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	festevam@denx.de,
	festevam@gmail.com,
	alexander.stein@ew.tq-group.com,
	Frank.li@nxp.com,
	ming.qian@nxp.com
Cc: conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	mchehab@kernel.org,
	hverkuil@xs4all.nl,
	linux-media@vger.kernel.org,
	imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries
Date: Mon,  8 Apr 2024 06:07:33 +0300
Message-Id: <20240408030734.1191069-1-mirela.rabulea@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9OBZKNNlUf/Y2ccS4GTe6CbZvSxHw2oUmqzYBMttmP1vJkt/Lw0L+/iZZwIm?=
 =?us-ascii?Q?7wMyVVI0DDGUnrgju7kpHISBH2I8li0HZsSuPF2w8AelWQ31ScIRW7SXItIj?=
 =?us-ascii?Q?OUoSNHEUBibuDSGI7bCAEmqk7CdU15IRphur7nTWebGkatBhuf3rvVuU3zfG?=
 =?us-ascii?Q?BZd00uKjW/3N+ZuRvjmSNzJcEgbkyeZ/4fAlEVq6hoF/8bEyKjZRDxobeEto?=
 =?us-ascii?Q?QAlZf7nLjcJoGHfYSGo3B9IUZBBBTBPhiaVRkIZTplLYLLluGp24ev5D+UuS?=
 =?us-ascii?Q?X9R2jOTs/0ONpGZjwte5s0oyN5XtCiwLcp+mW+Rro1AVA+gTwGNLomzq3W9H?=
 =?us-ascii?Q?B1PZIq0xAikX802bbK2TslQzJbYzKsepGT8sid540wGML/pnwuUlsUxsO08n?=
 =?us-ascii?Q?h7ngio0/6lWrM27Efu/Nf0WzTn8kB5eu2MvbFlHoEDu8EXbrwY5X1rAWc0jD?=
 =?us-ascii?Q?hOrmeqHJYI4Qx953xCbRMOLN4E1pXGj4p7o4Ws5eo9j7jCcetFGK06xg2RWL?=
 =?us-ascii?Q?ngsqNEo2UHhDoJPuu9k6xy8gp9EAndY5u4sTTCTnYWX4FqYi5LPFCiAKlchf?=
 =?us-ascii?Q?Lg73m0Mcf85IlRvdFgwPCvphK0yS/2Z+J06QvQ6PwtNnT9K7wqt5LJTkxd86?=
 =?us-ascii?Q?wZIuFXQubJq9cmdfE+rBP+nTRRBC30w3k7njhDBx20OHJQDTqym4PUZqJMkD?=
 =?us-ascii?Q?wpR4bYdXBN9QJ01h79LQSarzGvaXb6vXCPFRkd54adAFBSB7batPNy+Y2I1u?=
 =?us-ascii?Q?2wWPn5jFXxpm1OyiJJVSOPZDqrepjUdT41iqYmbzid6SdcnWHwTYkfGvqNTo?=
 =?us-ascii?Q?ZSyHLeppceJMFDeeXqXYR0UCJ9bcW2kFvMb8joXO3GEMoXed4mFQckQ3Okda?=
 =?us-ascii?Q?5PQurh++DuwL8ZwT9wDaODgftfndNSoclzd98O4LOBs2+feFFq/qaGQHbOQx?=
 =?us-ascii?Q?Qbz6r9y/bJUb3a9MCuTjNUG3so4ZJKVgA89h5xYcPbc4Ob5a4eB+boM5dVyh?=
 =?us-ascii?Q?ATcPKqrdIdXWdNA8gNTfsvcwbrwsUX+YWOZyyhu1Ll/1uMgYZmBAhBizkJPM?=
 =?us-ascii?Q?IJQmH3JMmcO070WLfdrNbRZ+LFcNzKYgGQedaRlTwxCq4F6IuTvO9b/dhEbc?=
 =?us-ascii?Q?jAzOyZ4MiSvSY4hIjbG2MxxyrDJHgdmh7DTvRRYn5y/OiiR6UDU0IB4UONXA?=
 =?us-ascii?Q?z5b/IQ5VtCnPUdpsOI1e40/PWxhLAgWGLHzpyBhIizBpbUZgmCl3d3qKMZog?=
 =?us-ascii?Q?MGOwNuMBXyPJdZ91L+fxI7SOoxWmQO+TV7BJyWrTD9lSsA652O5VQgNwo8DA?=
 =?us-ascii?Q?zra04dF6I6yRn1ZDHMKUwzPRcZ2+uzk5YYM9z8YH8bc5ikhWE5uaOUQVD7Xx?=
 =?us-ascii?Q?mx3NZK1ex5Btai6FaabgvQg1HwgHPF96lumE/zlfm1TF7SY798Xq8qgMGr1v?=
 =?us-ascii?Q?R+yizXwiplXgyHeBQfxF4hI9XBzx2cwEuODYYwEiUIBq4UWV9nmnaSc5lzry?=
 =?us-ascii?Q?Ev6aZ3a6ngb4+bfkKoRaGVKhBS0c9U1akgwZrixclFvJ362Db9iqFUkAHoFe?=
 =?us-ascii?Q?Mu2NKeZM69C3xwPy71H+ZO0yLrSQfC6Fu7lNxsku?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30631981-b7a8-4ace-7a8d-08dc577910cd
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9231.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 03:07:46.5612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ys3oc6E56eduFu9QFSoFYyqk1aejKhBwlpLEQt7gaMIDv5piE8sDCr0Q/cIPRs+15wsjXB82BuZ/3vbCBs2BNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7561

From: Fabio Estevam <festevam@gmail.com>

The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need
the PER and IPG clocks to be functional, so add the clock entries.

This also fixes the following schema warning:

imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
---

Changes since v3:
- Add items for clocks (per Krzysztof's feddback)
- Add description for clocks (per Conor's feddback to the other similar patch from Alexander)
- Add "media:" to the subject
- Add Mirela's signed-off
- For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li?

Changes since v2:
- Remove clock-names. (Mirela)

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..cc040feb77d7 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -31,6 +31,14 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    description:
+      The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB),
+      and one clock for it's core engine (AXI, same source as for the wrapper)
+    items:
+      - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per)
+      - description: IP bus clock for register access (ipg)
+
   interrupts:
     description: |
       There are 4 slots available in the IP, which the driver may use
@@ -49,6 +57,7 @@ properties:
 required:
   - compatible
   - reg
+  - clocks
   - interrupts
   - power-domains
 
@@ -56,12 +65,15 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx8-lpcg.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/firmware/imx/rsrc.h>
 
     jpegdec: jpegdec@58400000 {
         compatible = "nxp,imx8qxp-jpgdec";
         reg = <0x58400000 0x00050000 >;
+        clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
@@ -76,6 +88,8 @@ examples:
     jpegenc: jpegenc@58450000 {
         compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
         reg = <0x58450000 0x00050000 >;
+        clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>,
+                 <&img_jpeg__lpcg IMX_LPCG_CLK_4>;
         interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
                      <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.25.1