Received-SPF: pass (google.com: domain of linux-kernel+bounces-134746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e3d64b07-98fc-4d43-a1ef-561cbac58552@nxp.com>
Date: Mon, 8 Apr 2024 06:15:27 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [EXT] Re: [PATCH 1/1] dt-bindings: media: imx-jpeg: add
 clocks,clock-names,slot to fix warning
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Frank Li <Frank.Li@nxp.com>, Mauro Carvalho Chehab <mchehab@kernel.org>,
 Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
 Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>,
 "open list:NXP i.MX 8QXP/8QM JPEG V4L2 DRIVER" <imx@lists.linux.dev>,
 "open list:NXP i.MX 8QXP/8QM JPEG V4L2 DRIVER"
 <linux-media@vger.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@vger.kernel.org>,
 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
 <linux-arm-kernel@lists.infradead.org>,
 open list <linux-kernel@vger.kernel.org>
References: <20240404035205.59492-1-Frank.Li@nxp.com>
 <af602862-5120-4717-adb6-694ada09e8d8@linaro.org>
From: Mirela Rabulea <mirela.rabulea@nxp.com>
In-Reply-To: <af602862-5120-4717-adb6-694ada09e8d8@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dFRhT3dPbjdQa0x3dk96YjJQS2JpbVR4SmYxMXd0ODIvVmsyeHliV0JZZE5w?=
 =?utf-8?B?NlE5VjVkb3VyRWR6a05QbFZQdCtadzltbGt4bTkvQ3Y4RjNSc3lqSzNkOVZS?=
 =?utf-8?B?c2ZKa1pVZVlRWXJ1VTdmZ2ZqYktsaW92c3ZzWEhGN1NhZ0hMNnlkMGVWNjNn?=
 =?utf-8?B?K0loNWpZR0p1RWdFSWpKTElINHc3aXZZUDNoaVhCeDdwM0dCSTlBR21qdkQ0?=
 =?utf-8?B?WnlIbFlvZTdPOVZGbXhXSGF0RU96QVhlSm9LV2k1c3pYOTBpNmFvVmVZcnNT?=
 =?utf-8?B?Y3RGaXhMRUxpL2hFaVZ5SE5sVVVPQmFDN1NZcGpYenlXNzRnMzBGSHRZMlR3?=
 =?utf-8?B?elF0aGMvR2VXN1hQYjJDUU5aODhwSlpvSC9mMUNTQUFHZVg2MUtWVWwwcjdL?=
 =?utf-8?B?czZVbHdsd01yUXdDTFlBSlRkTGFXU3hSMEJhanVtZzF0Q3gxMGl4Y2lHZk5x?=
 =?utf-8?B?SUIwSHdRQk0xaHZtKzE2N2FIbVlobTNGTUFqMjVTQWx6V0hRL3U4S0haNXk4?=
 =?utf-8?B?RkVtaHZqbTlDSGJtR25rSTVwSkJXNFkvY2Z6K1NGNzdwYytmUkNYdGxNWktj?=
 =?utf-8?B?TTVZQndDbjU4aDZVS1VmUHFMRDZOc2FDd0JyUzJqcDVveGliTUk4SStGYWcz?=
 =?utf-8?B?aXJRekNGL0lhS09mNG9qaTVjcEdsejRaSXFyTDcweDhCdytZTFZjRXl6c3RY?=
 =?utf-8?B?RnluRWRocEFvVUVUNWhXSmFLQ0RhQmp2TFB0MWZmOXlmQmxudXBFZWJoTU5u?=
 =?utf-8?B?ZVlTT0ZuZDdhNkpXWVBoUitralYyc25YWGo1UXFwbjBjckFvQWcvMnpaK1Rr?=
 =?utf-8?B?S1Y1b3AxSDI5blBDNEVJS1N4aGVGRWtIOEtYRkNEOVdhcGZQQ25jbnp3NU9p?=
 =?utf-8?B?OUhFeDVXQmFmTDJFbTd1SkRLSFdwTmRtNHdmS1RCSEdrMGRqM1NQcy9oemtF?=
 =?utf-8?B?Tnh4eFRtQmVpdjVQVnJQNzFaVnYxK2c4UXYxRy9nNHU2WEhzb2g2V2xqQ3Zk?=
 =?utf-8?B?b0dDRWdUL2RYcWNod1lONEkzYTg1cXBVbTB4M1VjSkJsL0ZsK0wrd2FJMytY?=
 =?utf-8?B?MkRtUGRyUHhEWW5GeVc4SFcrL1hUenVGalVMeFg5RkhKUEVndnA3MGwxUlBR?=
 =?utf-8?B?dkxTdS83WXBTN0wydmEvZ1oyeDNDc09wNUxxRzdoT05MZ0xQNlAvRnk3TlVT?=
 =?utf-8?B?eFlUTUorOFVHcWV0elo3ODRYSDdaQzd0bW82Z1Q3K0FwaGRBRHRIckxYL2pq?=
 =?utf-8?B?aGVuOE9GT2FGcDNKMjNDekNEZEVrbm1HajkzYWduajFzRkpyKzBwazM5RlVO?=
 =?utf-8?B?MkRFYmdETEtvR2Q5RHJTc1NiWDIwbGpIZlBYWllTRzNsb1FHRldaZWhHWmlQ?=
 =?utf-8?B?U0VXR0RmRmxrR1h0U3owbmlhWUV1M2ZxZVBnMkNlT0NRR3BxZE9ONzIwMGl6?=
 =?utf-8?B?WWxZWHNPSlNqbDhCNjlSTk9mdVI2dnJSdStHT0pPdWU2U0dlalhMZ1NGbDB4?=
 =?utf-8?B?WUJXS1hocnQ0Q29UTjc3WlVPYVN3WEQ0OU16S0ZoT1B5ZFZBRjZrWXgrYyt4?=
 =?utf-8?B?TVJKMTcyQmcrMWljbDRYbTc3TmRFYmhUQjJmS1FkUTJCUjdzYVNhUXQvMlM4?=
 =?utf-8?B?V21EQUFYMmhkTTFRaVJnY0krV0U0VFBaSmdKbXVQOW5xUS82NTdWUFNVNVFw?=
 =?utf-8?B?OU1LbllWQldPd2t2Qkg1dVMyZnV6Nkt3bHpJdEMxbkRqYW5qUDJsK3hqalJN?=
 =?utf-8?B?dGM0Nno4VFpKNXFvQXBMeUZoZ1o4ci9GYU9rZWI4QmpHUHl2bGFScWdUeHNo?=
 =?utf-8?B?ZEZxZ2JiYThiNFNMdDVJK2FoVnoydkQ4OTE2VThoblRCcWcyMHVXZ25Rem5B?=
 =?utf-8?B?SlQ0OFdvU2F5WWNQOU53dlpacFoweW5sT3ZjR01KdnRGN1g4MzFzT2NacFR6?=
 =?utf-8?B?MWMwaDE2aCtBcWErUm9jUUdweGdFY1M3RHpvRTF2Yi93QmpwckZGcXB1aHdl?=
 =?utf-8?B?L3NXV1RKbDR0bUthdG5tRS9aaG1CdFFreldZaUxuYmFtNVVQaU8rVkJMaW5u?=
 =?utf-8?B?Q2FWSVZPTlNKZkZkbzY4SXV3ZTJZL21jNmk4L1pBZnAxMW1Ob2VoY2hoeFVE?=
 =?utf-8?Q?iJIzekJ5OqIQqUsAyA34fBDc1?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fffd9716-f344-42cc-75d0-08dc577a25dd
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9231.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 03:15:31.3667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kw17Th8SAljwRDkXCszAz9uHkcaBtS1bPKm9RXPyFDjoc4YhTV8cQD5izOs5a2S3nTLaUNiz2EGUj0x8GvqwwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8391

Hi Krzysztof,

On 04.04.2024 09:26, Krzysztof Kozlowski wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> On 04/04/2024 05:52, Frank Li wrote:
>> Fix below DTB_CHECK warning.
>>
>> make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
>>    DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
>> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
>>        from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#
> No, that's not the reason to add properties. Add them if they are valid.
>
>
>
>> +  slot:
>> +    description: Certain slot number is used.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    minimum: 0
>> +    maximum: 3
> NAK. Every time.
>
> Fix your DTS instead.
>
> Please read the feedback instead of pushing this stuff for the third time!
>
> https://lore.kernel.org/all/bbb1875b-7980-46aa-80b4-dbaf2a2d5755@linaro.org/
>
> Can NXP take responsibility for this piece of code?

Thanks for feedback.

For the clocks issue, I looked at the patches sent previously by 
Alexander Stein and Fabio Estevam, and the current one:

https://lore.kernel.org/linux-devicetree/?q=dfblob%3A3d9d1db3704+dfblob%3A7899e17aff3

As I also said in the past, I think Fabio's patch was more complete, so 
I took his _v3, I tried to incorporate all the feedback given, and I 
sent a subsequent _v4, here (bindings & dtb):

https://lore.kernel.org/linux-devicetree/20240408030734.1191069-1-mirela.rabulea@nxp.com/


For the slots issue, I will consult with Ming and get back.

Thanks for your patience, and sorry for the inconvenience.


Regards,

Mirela

>
> Best regards,
> Krzysztof
>