Received-SPF: pass (google.com: domain of linux-kernel+bounces-134754-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1f89ebad6dcb2161188354f990d3dad1.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240228185116.1269-1-vamshigajjela@google.com>
References: <20240228185116.1269-1-vamshigajjela@google.com>
Subject: Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
From: Stephen Boyd <sboyd@kernel.org>
Cc: Caleb Connolly <caleb.connolly@linaro.org>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Vamshi Gajjela <vamshigajjela@google.com>
To: Johan Hovold <johan+linaro@kernel.org>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Vamshi Gajjela <vamshigajjela@google.com>
Date: Sun, 07 Apr 2024 20:29:15 -0700
User-Agent: alot/0.10

Quoting Vamshi Gajjela (2024-02-28 10:51:16)
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=3Dxx which is not allocated".
>=20
> Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver=
")
> Cc: stable@vger.kernel.org
> ---

Applied to spmi-next