Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1107461lqe; Sun, 7 Apr 2024 20:30:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV0hyFDFMaTOIwoJsotpJCVPWfyEaGlXmjKA1eDnSfQtixdLuxr0uKdLLGP6VXoNR093MddSsTXZA38XFdY5BTmE9sxTZR4Pid7EuoYXQ== X-Google-Smtp-Source: AGHT+IHpItJAJPxKvJIevl1oLbj1BKg5RuX3ZlFgnRGI7/qbHMeNmWzKI6ff9kdXPThNAaGH+zwj X-Received: by 2002:a50:9507:0:b0:566:18ba:6b80 with SMTP id u7-20020a509507000000b0056618ba6b80mr4970934eda.31.1712547041139; Sun, 07 Apr 2024 20:30:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712547041; cv=pass; d=google.com; s=arc-20160816; b=P/fw0hI4yYd+x9PBj4scoIvb7TiUldVaiFUBiBn0Xm9nhseOW85LIA2Rpxku8Xlmh5 uj2CBzfNo0gRyVR9i2Yue7dPCB0XMdopsvMc+7oVPZ+tIZTz/OIhXRzy1E9bPRO4TZpU fO/AqlEPdWZruLXMjpEOtKjTVoVTWreH5F6y+TWS7tr31h6KUAiEG/8tL5Ue4wsyA9RA 6LyPN6A5u+JEPAQBHw6fS+qQ3szoxOC/oOZ1XFjz9ZjoFLZSoJZ+SLHZ9juscPNnvoqn /VL/5je+OUIO3BZrHORtz/R9Yvb9tMQ5Unyp6DbroijCPUV6/Mb0CRhURi0auNLNjpni BFcw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=1z7RxyFB+uJNVAsDVYm/gfzQrLSD3coa/jjMx+qmw3s=; fh=f5NtJKplNEU+oMWSA/lcctsmOm5Z73p5JJcPTrjH1E8=; b=hEGqqo+paGU0iVPYZFYKz9XgXcNtbtNcrgwWWyiR9G+p0BkhDMBikaDnVV/n3T3Hsr qGnyRXWjugge7nMr8Z1T4g0mXUwgNnRna5X0w9L4ADD8Pu6t61j+55SR7+MVCt8QkRQ5 PZJsNlHcSM5DM2t47nVDbTET5YJTdoh+8fRpDJhrgE+9pbhG4r0R9hyjcYNqzcDe36pf VnbTnB+PzpAtEn+meNkKjnxhnrSyHPfldyg8YdlPgEQAFHdtncStykbfeJcj493cuGcj r6gIidskCSRI76FTxojMLNqCRDbxDMJ53QZmr3ctl7q6DmhFa4foe6A1FnSBmXhEbwvK eAwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t4AuUaYD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134755-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id q9-20020a50c349000000b0056c24dfd1c3si3319506edb.686.2024.04.07.20.30.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 20:30:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=t4AuUaYD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134755-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D8D4B1F21D35 for ; Mon, 8 Apr 2024 03:30:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6EE9379EA; Mon, 8 Apr 2024 03:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t4AuUaYD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979A37462; Mon, 8 Apr 2024 03:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712547031; cv=none; b=E1wV98uorEI2SMKDOA4/dDm4KZAiJhelRWXzSe55eey5hM/Myk0TXQtJaYD0NcHqzs6ar+TpAwl7AVqEzDSP3KGNPWv09o7IvcnN9H/XLf/ntkyust2gmZSbmyvSEvpZ/Djo/VYa2vgpcLOosjSU1Xr8ULZACv667rM8v62tyFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712547031; c=relaxed/simple; bh=1z7RxyFB+uJNVAsDVYm/gfzQrLSD3coa/jjMx+qmw3s=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=oORPW/LtHz4BIdQqsbQq/QhWinmKKGKY3FxcLOHisVZXw7oT1L6qXmAcntjMEr93zMxOcZPgYyRzz7GvsoigmI4V8+fpKZPlxxQy8XUW0LROWB/E2rXHbileCZp4RPu+pIPJugdncvBGzDGr31d2bXc28KeUmKFkqh36MNSAD4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t4AuUaYD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0931DC433F1; Mon, 8 Apr 2024 03:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712547031; bh=1z7RxyFB+uJNVAsDVYm/gfzQrLSD3coa/jjMx+qmw3s=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=t4AuUaYDz29c5TeUHRPr8a3xGe3S0s3eijZg1QJCC5BkLKdRh1+7DJ8Gptsu/W2dA pr93GZt2TwjD/pJ6z72MOB4CpTZBrmUv2MtWtYjl6QHUTYcw71kv5kWVQiMRQjFFVF lLZZ3y8UP9boMYaF7qCovQwtWxs3n6/1fZ7SXFDtmuAsm3wZ0euUZH98FoW1Y4BKSo 8Uf6R+P8PBMBry1kcwAAqL+1Sn3k26aTkPUruJG34OpSr7T1sW5uODWOzXZgsw0E0T Ar6wUuf55mGCl3BD7XduIg3SV5ar38sDzgrw16QFaskjbB9sJbW8/JEJxnekdqb2Lq 9UAnJGw2tEHtg== Message-ID: <02b7818fff2dd5f0cf923e500fd5b569.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <82a0768e-95b0-4091-bdd1-14c3e893726b@web.de> References: <82a0768e-95b0-4091-bdd1-14c3e893726b@web.de> Subject: Re: [PATCH] spmi: pmic-arb: Replace three IS_ERR() calls by null pointer checks in spmi_pmic_arb_probe() From: Stephen Boyd Cc: LKML , Dmitry Baryshkov To: AngeloGioacchino Del Regno , Bjorn Andersson , David Collins , Fei Shao , Greg Kroah-Hartman , Markus Elfring , Peng Wu , Vinod Koul , kernel-janitors@vger.kernel.org Date: Sun, 07 Apr 2024 20:30:28 -0700 User-Agent: alot/0.10 Quoting Markus Elfring (2024-02-04 01:24:18) > From: Markus Elfring > Date: Sun, 4 Feb 2024 09:39:48 +0100 >=20 > The devm_ioremap() function does not return error pointers. > It returns NULL on error. > This issue was detected once more also by using the Coccinelle software. >=20 > Update three checks (and corresponding error codes) for failed > function calls accordingly. >=20 > Fixes: ffdfbafdc4f4 ("spmi: Use devm_spmi_controller_alloc()") > Fixes: 231601cd22bd ("spmi: pmic-arb: Add support for PMIC v7") > Signed-off-by: Markus Elfring > --- Applied to spmi-next