Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1123860lqe; Sun, 7 Apr 2024 21:33:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV1GHNgDgvGnreBbhwVYeYskJeqELO9Z2nNeAlCWPeOmOzZsDl/beYMYybtWCRih6anXV/sbrqoQAPkys3dEvZFHgCG6bGfQgwAiUb9MQ== X-Google-Smtp-Source: AGHT+IHoMprczQBu24U8CjSS7aoaDrrgJlJG8kBaRs6bULgQNVS4WFvHf7Z3Vr6Zi/cThtuDfik3 X-Received: by 2002:a9d:6258:0:b0:6e7:39ab:a96b with SMTP id i24-20020a9d6258000000b006e739aba96bmr8225800otk.24.1712550788340; Sun, 07 Apr 2024 21:33:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712550788; cv=pass; d=google.com; s=arc-20160816; b=cJ5Eu6lQkRHp8+nVNuV4XJpxZtCQnfFvxmvpk0kYN+QhKKa3OnllbP5QMrvOT070y8 hncZjidKVqbbrxs+NxHB+g0+lEIihwdr9oGr8bnXIQTd8AGsSG62w4Y6ISTy5LuFR9A3 AmP+A4zoEE3xpbyzVE2X2yNbzrcv6v7dRyWjYlbKcTG4/OI7xS7pPtTJpe387qR0kZaG uplkGzllv9G7OyiqCMR+oI5mfND9vuJRHbIgXsSxmVAkWi8EKP8pMFflPYhIvq54SGWT 7SJFoElGS2u4G0COhsHIJAl2LnsmfOmvw8c6rXeZlRf+2pOhAmslgmPQjAvD1MQkHJ0z eCNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=aWjHFP4FIwQxUWAPVoONDZq/MeuxzTLfwG/YafjPU/Y=; fh=gEyTpZF2qNxg8LXwOxP5tgKWbJ/meZzS93Vnw/SA2HY=; b=nflB1THnqaySzaE8DQStZAJhF0gIJpIeuK+eELLt5hEbpraeSqmjfJ4kimcAFXfeq8 n1VGG/fH4aznFmvy+KRcoa7e8Y8/HCgCJi/JzISVl322HkFPiMebgLCrLWulk17YHMl5 qvy6x4Etq3AR/z+DCjypdf77jgIbyCdU4UCqagbdxM7pui2mEoWVvCMp6BTt8tlw8Vw3 appZDC/1jSC0UFOmdCT+iEIrEIo5c7XjDSv9RGTLLZgIC2NOfVM5x6lFNzBdgKcisL2A Sa7rHBvNzqRSAhAiY1E/WlLrP7iGLLDWRfqWX9VOsg7TDTVxv5Af0Nm7JNBmrcz2mI+F IEPw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oprSFMRv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-134793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id b5-20020a63cf45000000b005e45abbc54asi5537311pgj.186.2024.04.07.21.33.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 21:33:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oprSFMRv; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-134793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134793-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 541B4B21F76 for ; Mon, 8 Apr 2024 04:32:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63C332576E; Mon, 8 Apr 2024 04:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oprSFMRv" Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71AE3749C for ; Mon, 8 Apr 2024 04:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712550660; cv=none; b=TZ69nQdEnezvBi4NaLFzLF6/EjC46CmVKtyFB/WcBZoAm/ZtAC99eTQZprnN6QzqQCP1FPJlRFc8LmeLKfGS/AgKR4n/3BEhRQH9q7dzAwdzALbCE/9o7X/ohCZAApIabvVE2c7Q/XwMtujcLWu3a2syNoU4SxEKxz/tuAtdjQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712550660; c=relaxed/simple; bh=AiMHop6LtWh5la59tUhjUjvEK/UQiD8uM+1Bb2RGdcc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CRhe04/qEjdEEALbxcnzwgRRMO2GsMrVsXnsVjSBnYD7B9YOnG22ChzIQopsmBVq4eWbIuFNpvHfGv+yi7ZTfOrLwVZJnCIHPAmrcJN8ORTzA4GprPexri15wSknR9T5cB21wmnRl0xwCYVDZ9M/hwYF33lEjL/XmKr1bV6HOYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oprSFMRv; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-516d0162fa1so4637308e87.3 for ; Sun, 07 Apr 2024 21:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712550655; x=1713155455; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aWjHFP4FIwQxUWAPVoONDZq/MeuxzTLfwG/YafjPU/Y=; b=oprSFMRvTiJHEr15KFMeVH6QzEY8VIK5o6rXJOV9drS8/jr/Gcat7RmxgnQUw0r8f9 /ZAMr3XUYmuMQT9hkqRvrG0XaLmDchMZq6+d1DwLGF/073mgvM36Fl9lChwudvr7D+yI ScKMSgyXvEemCk53MIdRWoAPAobSemwSEW5QMbpxKAV66wIxmxu5wz6fbHzQ1/1KSGtj onoBRaExBfQN8PBMRF0oQadN7tmFpvT/ty3cxSxhWMbIqTT/DMGw8lUfiGJKTI5hUB2I KgBZVjOuApNDR0nm5GLtNmFKAbI10fakqP/SktnJ7Qzac95mz+2oXsjfQhAz88DUeeIt VxVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712550655; x=1713155455; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aWjHFP4FIwQxUWAPVoONDZq/MeuxzTLfwG/YafjPU/Y=; b=Ts3te+Nxp91xIiGxtTOyYySFrg6Q/39pe+FztF6k5dNeCLRkkR8x+wYgWQpdD4VAjq MilHMhnRfBwdfIoxuSBexblJDjYp794gqMz9OtKzJK3vaZl8hVGkLT5W6KMzXWfpVq72 my4K1V7nd1DND995aRXWFQBjGXqy9ge52G7HnZVoPAFFuTHxIZtsBZz8n+v6QIOYwRch seZdXROJHVDpDR+osbvCDeKIEU154rWb+BQfZ/KzI/HmbXVO+mXhZnHBIU4DTh4+NPp9 pwQq3glN1WPDT2GXgll/2ZDj4RUDx4WkFRhXgczqjWeqLh51L6k5H/9XnyoyemSFsoUh CRwQ== X-Forwarded-Encrypted: i=1; AJvYcCWHzUnMLLNpTJiygOiF28XuWwkHvlfYb/QXAJSkAi5A6R6dvnBwKArFPHHgTsljipE7pcx6chGQ3Z/teTy08flb1zZEydYbPADbYVZr X-Gm-Message-State: AOJu0YyuPJgCyfEUPPh85zeUYFqP0/6CemrQ07s4i9+Flx0GnNlv4Q47 5j/kD2x3HxE6Au4W/3ixLITw7wxPjHnBxd+ZuRvpCyh+e279LeLiCi+U2AqdLkg= X-Received: by 2002:a19:644e:0:b0:513:aef9:7159 with SMTP id b14-20020a19644e000000b00513aef97159mr5407151lfj.39.1712550655691; Sun, 07 Apr 2024 21:30:55 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id g13-20020ac2538d000000b005132f12ee7asm1033207lfh.174.2024.04.07.21.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 21:30:55 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 07:30:52 +0300 Subject: [PATCH 4/5] usb: typec: ucsi: make it orientation-aware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240408-ucsi-orient-aware-v1-4-95a74a163a10@linaro.org> References: <20240408-ucsi-orient-aware-v1-0-95a74a163a10@linaro.org> In-Reply-To: <20240408-ucsi-orient-aware-v1-0-95a74a163a10@linaro.org> To: Heikki Krogerus , Greg Kroah-Hartman Cc: Neil Armstrong , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=AiMHop6LtWh5la59tUhjUjvEK/UQiD8uM+1Bb2RGdcc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmE3L7IPs4Dy2cixnuxh6PbWMygAc34bJSsBTiS g87Qu8asz6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZhNy+wAKCRCLPIo+Aiko 1Wx+B/wL9D5rVVtyDGr8tJVBflDFYn+l/8QkHU+8lO8IayWT9KG+uOtsC1LnOmRspt6imRaDueZ JhbpbaOf6eL12HEDTo1MdSVR17h7wlk2hOaR4eBhVmbHocM50U7svsxLYiQ3GQFIQc7z+fBZJLk R7rf5B/Jt3TmYSG/ccUI4k6N8fK3QBLZJNPypICKqxXJmSjiol0fTJV+fH01FioNAA/f+YtFUnW mbzFsQid+kMnK7VL3ETL8JrCDzX8BciHnn4feM+b+h+d4bY1RurXYkwXX8lKLz6WV7eyEiydsJg Hp6tpehb5SQJcETvzry2zv3gtbe5SA3MGnxwc7QNWKIOQbFr X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The UCSI 1.0 is not orientation aware. Only UCSI 2.0 has added orientation status to GET_CONNECTOR_STATUS data. However the glue code can be able to detect cable orientation on its own (and report it via corresponding typec API). Add a flag to let UCSI mark registered ports as orientation aware. Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/ucsi/ucsi.c | 2 ++ drivers/usb/typec/ucsi/ucsi.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 7ad544c968e4..6f5adc335980 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1551,6 +1551,8 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con) cap->svdm_version = SVDM_VER_2_0; cap->prefer_role = TYPEC_NO_PREFERRED_ROLE; + cap->orientation_aware = !!(ucsi->quirks & UCSI_ORIENTATION_AWARE); + if (con->cap.op_mode & UCSI_CONCAP_OPMODE_AUDIO_ACCESSORY) *accessory++ = TYPEC_ACCESSORY_AUDIO; if (con->cap.op_mode & UCSI_CONCAP_OPMODE_DEBUG_ACCESSORY) diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h index 6599fbd09bee..e92be45e4c1c 100644 --- a/drivers/usb/typec/ucsi/ucsi.h +++ b/drivers/usb/typec/ucsi/ucsi.h @@ -410,6 +410,7 @@ struct ucsi { unsigned long quirks; #define UCSI_NO_PARTNER_PDOS BIT(0) /* Don't read partner's PDOs */ #define UCSI_DELAY_DEVICE_PDOS BIT(1) /* Reading PDOs fails until the parter is in PD mode */ +#define UCSI_ORIENTATION_AWARE BIT(2) /* UCSI is orientation aware */ }; #define UCSI_MAX_SVID 5 -- 2.39.2