Received-SPF: pass (google.com: domain of linux-kernel+bounces-134795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <90ac6d2dce33e8078db7cb5681fb94d7.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240325210025.1448717-3-cristian.marussi@arm.com>
References: <20240325210025.1448717-1-cristian.marussi@arm.com> <20240325210025.1448717-3-cristian.marussi@arm.com>
Subject: Re: [PATCH v2 2/5] clk: scmi: Add support for state control restricted clocks
From: Stephen Boyd <sboyd@kernel.org>
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, souvik.chakravarty@arm.com, mturquette@baylibre.com, Cristian Marussi <cristian.marussi@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Sun, 07 Apr 2024 21:48:59 -0700
User-Agent: alot/0.10

Quoting Cristian Marussi (2024-03-25 14:00:22)
> Some exposed SCMI Clocks could be marked as non-supporting state changes.
> Configure a clk_ops descriptor which does not provide the state change
> callbacks for such clocks when registering with CLK framework.
>=20
> CC: Michael Turquette <mturquette@baylibre.com>
> CC: Stephen Boyd <sboyd@kernel.org>
> CC: linux-clk@vger.kernel.org
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
>  drivers/clk/clk-scmi.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
> index d5d369b052bd..fc9603988d91 100644
> --- a/drivers/clk/clk-scmi.c
> +++ b/drivers/clk/clk-scmi.c
> @@ -18,6 +18,7 @@
> =20
>  enum scmi_clk_feats {
>         SCMI_CLK_ATOMIC_SUPPORTED,
> +       SCMI_CLK_STATE_CTRL_FORBIDDEN,

Can it be positive, i.e. SCMI_CLK_STATE_CTRL_SUPPORTED?

>         SCMI_CLK_MAX_FEATS
>  };
> =20
> @@ -230,15 +231,19 @@ scmi_clk_ops_alloc(struct device *dev, unsigned lon=
g feats_key)
>          * only the prepare/unprepare API, as allowed by the clock framew=
ork
>          * when atomic calls are not available.
>          */
> -       if (feats_key & BIT(SCMI_CLK_ATOMIC_SUPPORTED)) {
> -               ops->enable =3D scmi_clk_atomic_enable;
> -               ops->disable =3D scmi_clk_atomic_disable;
> -               ops->is_enabled =3D scmi_clk_atomic_is_enabled;
> -       } else {
> -               ops->prepare =3D scmi_clk_enable;
> -               ops->unprepare =3D scmi_clk_disable;
> +       if (!(feats_key & BIT(SCMI_CLK_STATE_CTRL_FORBIDDEN))) {
> +               if (feats_key & BIT(SCMI_CLK_ATOMIC_SUPPORTED)) {
> +                       ops->enable =3D scmi_clk_atomic_enable;
> +                       ops->disable =3D scmi_clk_atomic_disable;
> +               } else {
> +                       ops->prepare =3D scmi_clk_enable;
> +                       ops->unprepare =3D scmi_clk_disable;
> +               }
>         }
> =20
> +       if (feats_key & BIT(SCMI_CLK_ATOMIC_SUPPORTED))
> +               ops->is_enabled =3D scmi_clk_atomic_is_enabled;
> +
>         /* Rate ops */
>         ops->recalc_rate =3D scmi_clk_recalc_rate;
>         ops->round_rate =3D scmi_clk_round_rate;
> @@ -288,6 +293,9 @@ scmi_clk_ops_select(struct scmi_clk *sclk, bool atomi=
c_capable,
>         if (atomic_capable && ci->enable_latency <=3D atomic_threshold)
>                 feats_key |=3D BIT(SCMI_CLK_ATOMIC_SUPPORTED);
> =20
> +       if (ci->state_ctrl_forbidden)

Then this is negated.

> +               feats_key |=3D BIT(SCMI_CLK_STATE_CTRL_FORBIDDEN);
> +
>         /* Lookup previously allocated ops */
>         ops =3D clk_ops_db[feats_key];