Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1139268lqe; Sun, 7 Apr 2024 22:30:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFBwq0Mx7V57oaX9P5ag5qzsN1NBkKTjFGP0PBNOt0toqIRmQDPAeB6HC5lgVU0aACNk//SxYdU1WjLxNHe6GxHpehGEFY38gsnVv5fA== X-Google-Smtp-Source: AGHT+IFoDZtBaVK4il8nrGuDAtE1vMD0d4nMBBPIvet8MkrK8LoCP3kAH72/aJ+Pnm2xxV7h7x0S X-Received: by 2002:a17:903:32d1:b0:1e4:1fb8:321f with SMTP id i17-20020a17090332d100b001e41fb8321fmr2484126plr.20.1712554213312; Sun, 07 Apr 2024 22:30:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712554213; cv=pass; d=google.com; s=arc-20160816; b=AcjFtCejetn+xgAkbJHoG8s9dclTctGX6mPSA/C9RHrK9vqSX0gUYELyEdGdW0P7oh SjcBsSOT53IIeYZuHL3FMabKVHnFfdPseQmJm3P9YCTPeh+5VAepiPWFYWiBGrll2XmQ fHqh1Qw/qNGjWHbYvPo6DQAXP8txhaYyUAPTDXclYlVSenVG5AHELtOjsQeVyYl2ttCd JyPtMFAcy1tYLDmuxIq8j3PLbayyMnYlgGX50/EwAn8MMbFAdTKFsdRwh16NxIh9HAxL KZUVyP8ZHwKaAyNbHPBCpxn8rlYKR9002JJZawLrwX3jarKQTBzhwYY1zhupeid89Ges 7tSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=iMWIRrwu8jzlwq3GFwobpQXIdHqfklC2x5296qQNRHU=; fh=LmazhCAKqQypUF/lwKeHeEzRBEXVsGahOMxam8Ot3v0=; b=IH9e9aPSRaZdkX6SwpHlIiSWtbXcGo1lQrMGBTRphUzybPDa3P91vjE1+1a+b4L2dw 8Pb3YPxrddn6I4CVXX2XS9lV+pWN0+l83XeBWAvbtNGXIB+RAfEsDO1Xzo2B+X6wuF5z BgTtXTbsme6m+et+R4nP7dthbYHOJ+kxtCiVHJe3GwDy2Rqzosnu/iEgl3BIk21oWmkj CTUG5XIDLkKCJYvs/+AHtndPZvWuVPMzIUOMcBWRt0rr21snZpd7HTOCZ3XRW7jbSzk0 KyAS5JbvG/3lMyoqz1O500YOwLBIwkbjjd1i5XgF+R0Fw+BF21s6YIg0XN9Hqf0Za8jj A6qw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=UsKnHN5d; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-134801-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134801-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i17-20020a17090332d100b001e41c8728f2si1342867plr.1.2024.04.07.22.30.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 22:30:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134801-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=UsKnHN5d; arc=pass (i=1 spf=pass spfdomain=ellerman.id.au dkim=pass dkdomain=ellerman.id.au); spf=pass (google.com: domain of linux-kernel+bounces-134801-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134801-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 30835B2153E for ; Mon, 8 Apr 2024 05:30:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A00A279D8; Mon, 8 Apr 2024 05:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="UsKnHN5d" Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6146F111A8; Mon, 8 Apr 2024 05:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712554199; cv=none; b=jGhLTzZA7aJAsoG2NIqaSO1Ntn4xeApQ6jHNE0N1XJKpdhmQ2/qZ7JT7/LKHLuWVtd79PHVy/DjaKf0hhvoH58hsMDyaUqMZfZcx7iM1Tlk2InWkv4SoiNwzAdV0LvDDz+dFVZaY+1nm4yGqBfQvOnQ/LzyPXc5XEQK48ahqOkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712554199; c=relaxed/simple; bh=taPtZ4H9ZcND3oGrS9y6pAeVaLjbudmAuFy8q/qklMc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=AhcPJiOhqkknT2flLxT47252ybQxFq5G/eCzTDtAOoaxKlZ93vPxlMmYgrUwDCt40PCs7S0mAcus8I5tsuztoYsg78473wEw+J7y6NUbDMDfeFTPoW0KLvUqcvmdXuf104tRWMgH5kUtd6vcqBCg8p1u/VGbcKk3wrz+gZQOLKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au; spf=pass smtp.mailfrom=ellerman.id.au; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b=UsKnHN5d; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ellerman.id.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1712554197; bh=iMWIRrwu8jzlwq3GFwobpQXIdHqfklC2x5296qQNRHU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UsKnHN5dUA5W0rjVFcwQj5HDYvEHusqogP0tHn2kalVa91OM2idgYC2m6oywCccHn 20FOcjzQeTxSX/TNcljO0PtQeHSikB6hwmGZLi9+pdBhaigjbzBmhfzSCowQyox1AB M8ZC6Nl7a6+sbocmAHfxGj/Xlr1fxJqAzI6XPx5zHMntsMAgYheeHS13xKkMzmkym4 t0VtffZzOe60AjdZZOuo8CgV1vpgZWyrEhAKfjbc1xIOmg8wyIdPmQbyOubEnH1tHG UDV589rMWSfeRpqkCEgEaUPYy9XmYedZWEuZI4rNpfpGoTdTsMJjIgT+i3tzqHjXuh AYWYO2yb9DORA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VCd2X6SD4z4wd3; Mon, 8 Apr 2024 15:29:56 +1000 (AEST) From: Michael Ellerman To: Finn Thain Cc: Greg Kroah-Hartman , Jiri Slaby , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, Benjamin Herrenschmidt , Andy Shevchenko Subject: Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood In-Reply-To: <2cb53463-897b-8f3f-7238-9fe87622b54d@linux-m68k.org> References: <0df45bedded1249f6c6ec2c2fb0d9879da1841b7.1712273040.git.fthain@linux-m68k.org> <87v84w7be3.fsf@mail.lhotse> <2cb53463-897b-8f3f-7238-9fe87622b54d@linux-m68k.org> Date: Mon, 08 Apr 2024 15:29:56 +1000 Message-ID: <87sezwbewb.fsf@mail.lhotse> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Finn Thain writes: > On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> I assume you have tested this on an actual pmac, as well as qemu? >> > > I tested the patched driver and its console functionality using Zilog SCC > hardware in a Mac IIci, as well as QEMU's q800 virtual machine. > > That should suffice from a code coverage point-of-view, since > pmz_receive_chars() is portable and independent of CONFIG_PPC_PMAC. > > Moreover, I don't know how to get my PowerMac G3 to execute the kludge > that's to be removed here. I can't prove it's impossible, though. Thanks. That's good enough for me. Acked-by: Michael Ellerman (powerpc) cheers