Received-SPF: pass (google.com: domain of linux-kernel+bounces-134839-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 8 Apr 2024 09:35:18 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jackson Chui <jacksonchui.qwerty@gmail.com>
Cc: Alex Elder <elder@ieee.org>, Johan Hovold <johan@kernel.org>,
	Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Clear up precedence for gcam logging
 macros
Message-ID: <e037e303-47b3-4758-914c-980ebe88d450@moroto.mountain>
References: <20240404001627.94858-1-jacksonchui.qwerty@gmail.com>
 <658e1f40-d1eb-4ba7-9ba3-0aa05a1ed06e@ieee.org>
 <ZhBrff8qkkmum4wc@jc-ubuntu-dev-korn-1>
 <5eb3afe2-da7b-4f98-aac2-bff529a02cea@moroto.mountain>
 <5e1c5156-d906-4473-970b-bff71e4dcd96@ieee.org>
 <ZhHOKkqVIdsuZ-4Q@mba15m2.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhHOKkqVIdsuZ-4Q@mba15m2.local>

On Sat, Apr 06, 2024 at 06:35:22PM -0400, Jackson Chui wrote:
> > 					-Alex
> 
> Dan, Alex I think both of you are spot on.
> 
> I like the suggestion of adding 'gcam_dev()' as an accessor
> function and directly calling to 'dev_*'. I'm busy this weekend
> but will send out a new patch with this change next week.

Nah, don't bother with adding the gcam_dev() function.  Like Alex says,
it's only 4 characters shorter.  Just get rid of the macros and do:

                dev_err(&gcam->bundle->dev,
                        "Unsupported unsolicited event: %u\n", op->type);

regards,
dan carpenter