Received-SPF: pass (google.com: domain of linux-kernel+bounces-134844-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Liao, Bard" <bard.liao@intel.com>
To: Vinod Koul <vkoul@kernel.org>, Bard Liao <yung-chuan.liao@linux.intel.com>
CC: "linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pierre-louis.bossart@linux.intel.com" <pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH 4/7] soundwire: reconcile dp0_prop and dpn_prop
Thread-Topic: [PATCH 4/7] soundwire: reconcile dp0_prop and dpn_prop
Thread-Index: AQHaf1w3hJjp48qcEUmF4FwP+Ai227FZm1SAgARktRA=
Date: Mon, 8 Apr 2024 06:39:05 +0000
Message-ID: <CH3PR11MB8436016A3DE30D26823E320BFF002@CH3PR11MB8436.namprd11.prod.outlook.com>
References: <20240326090122.1051806-1-yung-chuan.liao@linux.intel.com>
 <20240326090122.1051806-5-yung-chuan.liao@linux.intel.com>
 <Zg_hcQ2RUBpkA_DG@matsya>
In-Reply-To: <Zg_hcQ2RUBpkA_DG@matsya>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LkJit0oTF//BfDm46qUYQgJpkKZ0hETIpJue2vF3DFwwn+e3g+MDJGbh84GE?=
 =?us-ascii?Q?oBPErivlulzfIAYEhq+1Yc0h7qVKJfIw7do+e7bkycIltcGpJTUBN3gso860?=
 =?us-ascii?Q?pfOXryWJdw789jiHZEsc0O8ScNwY27EWejG/v5BZP6sWGdradYGW4c4Hfwei?=
 =?us-ascii?Q?TChGjRLYzNoVJJnc7jtUvBkyY9Kyo6ukTMX+ZJY027THF2cS1Swc4UlSWslS?=
 =?us-ascii?Q?7p9f8w1/wGHtZPbRKcIqUyeZZzckV1hriWQyUaTVDef06Zwe8t5wuPme5iIJ?=
 =?us-ascii?Q?d4oTnRbLBw37wlswYlbdhxd/NNso1HQtHGwzd7+ZEjpH9XlKU7VvAV7bI7M9?=
 =?us-ascii?Q?nlBKIhR2jtbAY6IPu5LOrnZs4rPGXjtYdsweN37DBj+ByQgiSba/iH3ULDqv?=
 =?us-ascii?Q?71NTiPocWtuuvOdnpQ51RF2wxo7Ve7sE57lwNene2gCs4iSVrdiZ8XlGELsJ?=
 =?us-ascii?Q?yH7Q+rtiu4rOJ5U5cGbRJSc7NlGoKyWpGXvSSXTu4XQOgIZk2FoPss1F2SEn?=
 =?us-ascii?Q?Jm1pt94t9UNOqhoN6R9udX5Xi7luXOrTmqoHIeBWv6mcOB5u8YylvuUdoX7j?=
 =?us-ascii?Q?+BL/otn+b7FtuzcJcEglZ84s1sgAgD4gSPD9Mr2vfga98gtfQjKtFyTKZFM/?=
 =?us-ascii?Q?aAj0bSTIdzFHl+sLfJ3+d3OlHKJCoKM8gipkX/upZH2RxvqTcuxwxhxuJwXD?=
 =?us-ascii?Q?oTR0fT1RC77aAr7klD8La0Tjz59AebQ5ZCaXtbIuruMlRqkpnSynHHYKVx0N?=
 =?us-ascii?Q?ukPGkWxAvn+L9bg13lqNlTyCxYHqvspLC4Qm47LoGkCYV2bHEPNCAtXhs8qm?=
 =?us-ascii?Q?oFePeZ9BRAyKIC6J+ghwaGsA9O1HJZXkqEpDlmRNAeiGcbPP1/bHOoySDTCB?=
 =?us-ascii?Q?eu9XGbjJkz655HrAOuvVatandLFuzNelZwUvY3/WCnVB16VAe3L+NrZ7LGy/?=
 =?us-ascii?Q?n8WBg13uZzA/wZJ3qbAqyTD5QUQm9kePT7RvaSBogsovhwP4V7Q3GrBy2XVQ?=
 =?us-ascii?Q?KcADbF5Bud+04RctbmS3J66yiIokDasiFISwFeC7yA8OmbKlioHZNuse7G8z?=
 =?us-ascii?Q?i1XomCVJQWUpfz/Hr55BIhdAjDYiws6Y/y6BTHC1gPdWL0Ph/NqIB91fUvvp?=
 =?us-ascii?Q?NxtYStcLzXhm+iVPk1Y6MuFo6P5LxGhfO10xqbzXD/Zek6JazTU8C1FnPg+A?=
 =?us-ascii?Q?tGW8L8LlYYz6etnS50qU7NYcsxwY3F+/z6pXC8acZpz8HPysPrXXBHR9Gnyz?=
 =?us-ascii?Q?h1Gd/Gxll206QV2N5vSUVy5S1a7jRM/l4KN67WQxgCu8iq3+4JHP2sD3mcSP?=
 =?us-ascii?Q?1vnrpNzVXOAI2MhAmy2MZpgTsRoXKyMSGrgvf98VTwWPjoipG0/Hlvv5qPSd?=
 =?us-ascii?Q?m8K3Q+rkH8lozUelPtcCsSpY7Sql5uxnTf3m+xVsnHMxSD0m2heu7YnmJDhL?=
 =?us-ascii?Q?Fa8Xcm4Oq1MWhT5GPE1/6TypCyE/gXl7TTc65GNx+Ke0J7MJ32tGWeP9/PdS?=
 =?us-ascii?Q?Uxk4hOEYKy1wYYoNQ0oocThHITmAWepkZ7NjHF7ikpcLQZIXvhmeoTWV2tkH?=
 =?us-ascii?Q?Ea8EmfZwuqql98UhiRQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8436.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d2beef7-f5f1-4f2f-0a98-08dc57969631
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2024 06:39:05.6062
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LdaM0F18HlDQ0as8xotzVSaAa7N7dt2LKnvXT2I+YpTaja1pbxN5yk78yMQO9HGWm2xHqNmE6NUpzsoGSq/hkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8686
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Friday, April 5, 2024 7:33 PM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; pierre-
> louis.bossart@linux.intel.com; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH 4/7] soundwire: reconcile dp0_prop and dpn_prop
>=20
> On 26-03-24, 09:01, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> >
> > The definitions for DP0 are missing a set of fields that are required
> > to reuse the same configuration code as DPn.
> >
> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.c=
om>
> > Reviewed-by: Rander Wang <rander.wang@intel.com>
> > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> > ---
> >  include/linux/soundwire/sdw.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sd=
w.h
> > index e5d0aa58e7f6..e3a4bccc2a7e 100644
> > --- a/include/linux/soundwire/sdw.h
> > +++ b/include/linux/soundwire/sdw.h
> > @@ -235,7 +235,8 @@ enum sdw_clk_stop_mode {
> >   * @BRA_flow_controlled: Slave implementation results in an OK_NotRead=
y
> >   * response
> >   * @simple_ch_prep_sm: If channel prepare sequence is required
> > - * @imp_def_interrupts: If set, each bit corresponds to support for
> > +  * @ch_prep_timeout: Port-specific timeout value, in milliseconds
> > +  * @imp_def_interrupts: If set, each bit corresponds to support for
>=20
> why is this line modified? seems to be same as previous and leading
> space added which might not be correct

Thanks for pointing this out. Sent v2 to fix it.

>=20
>=20
> >   * implementation-defined interrupts
> >   *
> >   * The wordlengths are specified by Spec as max, min AND number of
> > @@ -249,6 +250,7 @@ struct sdw_dp0_prop {
> >  	u32 *words;
> >  	bool BRA_flow_controlled;
> >  	bool simple_ch_prep_sm;
> > +	u32 ch_prep_timeout;
> >  	bool imp_def_interrupts;
> >  };
> >
> > --
> > 2.34.1
>=20
> --
> ~Vinod