Received-SPF: pass (google.com: domain of linux-kernel+bounces-134855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <17e04ad9-350a-4f6e-b932-9881b7898c5a@linaro.org>
Date: Mon, 8 Apr 2024 08:48:14 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/9] MIPS: debug: Implement low-level debugging
 functions
To: Jiaxun Yang <jiaxun.yang@flygoat.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240326-mips_debug_ll-v2-0-b64abc76f2a1@flygoat.com>
 <20240326-mips_debug_ll-v2-2-b64abc76f2a1@flygoat.com>
Content-Language: en-US
From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>
In-Reply-To: <20240326-mips_debug_ll-v2-2-b64abc76f2a1@flygoat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 26/3/24 21:35, Jiaxun Yang wrote:
> Currently we have three sets of early debugging functions
> for MIPS: zboot putc/puts, cps-vec-ns16550, and prom_putc.
> 
> This is a attempt to bring them all to one by providing
> a interface similar to arm's debug_ll, which is very portable
> and allows you to support new platforms easily.
> 
> Two examples of output interfaces are provided, including
> 8250 uart and MIPS UHI semihosting, which already covered
> most of the platforms.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>   arch/mips/Kconfig.debug        |  80 +++++++++++++++++++++++++
>   arch/mips/include/debug/8250.S |  60 +++++++++++++++++++
>   arch/mips/include/debug/uhi.S  |  48 +++++++++++++++
>   arch/mips/kernel/Makefile      |   2 +
>   arch/mips/kernel/debug.S       | 130 +++++++++++++++++++++++++++++++++++++++++
>   5 files changed, 320 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>