Received-SPF: pass (google.com: domain of linux-kernel+bounces-134868-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <6f8ab03f-7755-4044-81a1-6269aa9a62ed@gmail.com>
Date: Mon, 8 Apr 2024 15:00:46 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable_node
To: David Hildenbrand <david@redhat.com>, alexs@kernel.org,
 Matthew Wilcox <willy@infradead.org>, Andrea Arcangeli
 <aarcange@redhat.com>, Izik Eidus <izik.eidus@ravellosystems.com>,
 Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, ryncsn@gmail.com
Cc: Hugh Dickins <hughd@google.com>, Chris Wright <chrisw@sous-sol.org>
References: <20240325124904.398913-1-alexs@kernel.org>
 <20240325124904.398913-15-alexs@kernel.org>
 <ad50bc5d-d2be-4017-83e7-6fdc45ac1659@redhat.com>
Content-Language: en-US
From: Alex Shi <seakeel@gmail.com>
In-Reply-To: <ad50bc5d-d2be-4017-83e7-6fdc45ac1659@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 4/5/24 3:32 PM, David Hildenbrand wrote:
> On 25.03.24 13:49, alexs@kernel.org wrote:
>> From: "Alex Shi (tencent)" <alexs@kernel.org>
>>
>> Remove the func since all caller are gone. Also remove the
>> VM_BUG_ON_PAGE() because it's not applicable for a folio.
> 
> Ehm, it is for small folios that we are working with here.
> 
> Please keep that check and convert it into a warn.
> 
> VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio);

will take it. Thanks!

> 
>> -    page->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM);
>> -}
>> -
>>   static inline void folio_set_stable_node(struct folio *folio,
>>                        struct ksm_stable_node *stable_node)
>>   {
>> -    set_page_stable_node(&folio->page, stable_node);
>> +    folio->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM);
>>   }
>>     #ifdef CONFIG_SYSFS
> 
>