Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1184433lqe; Mon, 8 Apr 2024 00:47:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWt9nzIHGh1QPJXH498rN4Se0JvJ9h1Ywgi0AnEK0CaOx8R9L4pXNK0tvq3RWrG2kbVoUn8qWXj1RZKj1LFPfK9U+SkHoj9/KGkUqhKXw== X-Google-Smtp-Source: AGHT+IGjMvj3zmflS+yQ6FOVzlJ1v/pTJIYXTQU390jrkgKVmkDnKsKf5mHTXEBBxQEfklWs5Hxx X-Received: by 2002:ac8:5d07:0:b0:434:67d9:db7f with SMTP id f7-20020ac85d07000000b0043467d9db7fmr11142311qtx.29.1712562474759; Mon, 08 Apr 2024 00:47:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712562474; cv=pass; d=google.com; s=arc-20160816; b=Ufjp374PRzwKb3YzxwuDUMV1BP0zUXcfVgd6j1m1Ou1cNYZKmZ3iHAGygLiu5XpXK7 trTXoxp000Dza6IZlFqIvOrLf38AZiKQ+2n3go0Eh4qB5YjFkSRpR0ZWN5yqlWRZo5gx UwhBV9Nu4bnlhJckbs0DHeShqCec068BMUdyiIJ10losJAi5pltvKpNv5snEab5+oAvH iq1kyveZMxLQEALoA79yuZSx/PaFsZypAHVrVVFwltRa2imZ2BrfWr5AauJmwt6HR2MJ 2R1ALsyYmGhH7VrrSETqAMqfNBuW7xhW0GMRSq/hsnLeOqkH5BZZ9mEIaQlXRxGrzFuI Kucw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KSmyF627jU+jgKZ2SBisxq/IjFaNZDRMZJaV2RGOJRo=; fh=5uQC1kxbadLX26Wv1pJxToniMELNAivPw0D74OhJJ6Q=; b=t4GTuENtz5tpd7SRqLigMAVnQBSZop60ydKI5YwnjIeJhNhAzRPYOj29c6uJtB+emD XQvwts/0AB2Wbs0w6Y908NShRppVOe+mASGKaRZaZc6D8SwfHV0gLEmZNzI2Bfk5cLsU oJn8UdrrRPxsI6Kx8t8XdjqTdRz7hQaTq69Vr0eUfT5lA2hbt3wrlKTn7IWl9D6PB0Sy QT3gZ9rw/R2BFlZBuQwrg41/6ctxFE8spqa9vPhML+RaDtAwQ7ICIqos809M8RtMofGv 1YDoRyQvaUyKF4DN2Giyw5ARHsFO9QwkbVcBHpHdOENePVwUjqP5ZFj2XmUtqBF2jTZu iokw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XnGEn2r6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134931-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o11-20020ac85a4b000000b004349bf16b99si2046543qta.363.2024.04.08.00.47.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 00:47:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XnGEn2r6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-134931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134931-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 71E3F1C22495 for ; Mon, 8 Apr 2024 07:47:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9B0D741C7C; Mon, 8 Apr 2024 07:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XnGEn2r6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE14C44C71; Mon, 8 Apr 2024 07:43:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712562238; cv=none; b=UrspQwYc5R3Plzc5WkorjnQBFxmIbq28mcHrIGP7TE3/rmXrvCyJWCHWunu/KE6v4kdAVB1/y+XxJtUjdfTz5RgSuhvjFLgtFHHWsWAqswxxVHFJV9U8QnV4AbHSbjHji4SmyhfEqhZuSfhyyKKDdnIUb2OUakDzHO2ipmnHYbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712562238; c=relaxed/simple; bh=UtcdCMkPCpBNj87XfIejQin+4GfBWMf0J39189pE9XE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UdPT6l33HyXDGMWIbyyrQrekfFgsb70CPoa1VIr+DKBBZSztxwtj2byDOscn9FvOno8rqK8e51xmkGKSaIc+POf0O2W/APAZrQVY7lgmWoLMkOccAuL8XgcEmYkTfrzJs5XLFwAxlKZq7uS5f/VYY2ivkZL2FErTjCrGeoB3oWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XnGEn2r6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C4CC433F1; Mon, 8 Apr 2024 07:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712562238; bh=UtcdCMkPCpBNj87XfIejQin+4GfBWMf0J39189pE9XE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XnGEn2r6FJO9E+j0JcXC84uJNjDS4I7r0Zbbw0TWDqzabGYsMTGXslYlGFawh9S+j 5MFUnvTsz2VsaRd3PLMpuSgjd/sWvtDxZKeC+5OiQH6/ZtqYLyEFapCzcDx1X8KiuC tzE52AhjUWzAU6OcYg6795WL+u5+gZHm5DsW1ssAFIvU8LFKLqUP8w5mue2gkoPkay 4WhialH/Z5q2jrz/145WAYksy7Rfs86o00UY0S96n5Lt8AE8wYrHe7H9NUJyAmNTpx VaZvOdNEeZJC3phY2w+u4ITmILhwDrjcJEDrHLo2mKPRlPqj9k6tt3CdBSerUARBAC v1jIpS3aC0utg== Date: Mon, 8 Apr 2024 08:43:52 +0100 From: Simon Horman To: Catalin Popescu Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, m.felsch@pengutronix.de, bsp-development.geo@leica-geosystems.com Subject: Re: [PATCH net-next v3] net: phy: dp8382x: keep WOL settings across suspends Message-ID: <20240408074352.GZ26556@kernel.org> References: <20240404130516.2897310-1-catalin.popescu@leica-geosystems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240404130516.2897310-1-catalin.popescu@leica-geosystems.com> On Thu, Apr 04, 2024 at 03:05:16PM +0200, Catalin Popescu wrote: > Unlike other ethernet PHYs from TI, PHY dp8382x has WOL enabled > at reset. The driver explicitly disables WOL in config_init callback > which is called during init and during resume from suspend. Hence, > WOL is unconditionally disabled during resume, even if it was enabled > before the suspend. We make sure that WOL configuration is persistent > across suspends. > > Signed-off-by: Catalin Popescu > --- > Changes in v3: > - rename function _dp83822_set_wol to dp83822_config_wol Reviewed-by: Simon Horman